<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> <p class="MsoNormal">This is now clarified in an ACPI spec ECR (<a href="https://bugzilla.tianocore.org/show_bug.cgi?id=3335">https://bugzilla.tianocore.org/show_bug.cgi?id=3335</a>). The example will be updated in a future spec errata to use ResourceProducer.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">I think this patch can resume as it is not gated by the spec anymore.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Andrei Warkentin <awarkentin@vmware.com> <br> <b>Sent:</b> Thursday, April 8, 2021 10:25 AM<br> <b>To:</b> Jeremy Linton <Jeremy.Linton@arm.com>; devel@edk2.groups.io<br> <b>Cc:</b> Ard Biesheuvel <Ard.Biesheuvel@arm.com>; leif@nuviainc.com; pete@akeo.ie; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com><br> <b>Subject:</b> Re: [PATCH 0/3] SD+USB perf/DMA fixes<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:Consolas;color:black">I think Linux's behavior needs to be reconciled with the ACPI spec, which uses _DMA with ResourceConsumer, not ResourceProducer.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:Consolas;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:Consolas;color:black">A<o:p></o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> <p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Jeremy Linton <</span><a href="mailto:jeremy.linton@arm.com">jeremy.linton@arm.com</a><span style="color:black">><br> <b>Sent:</b> Thursday, April 8, 2021 12:58 AM<br> <b>To:</b> </span><a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a><span style="color:black"> <</span><a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a><span style="color:black">><br> <b>Cc:</b> </span><a href="mailto:ard.biesheuvel@arm.com">ard.biesheuvel@arm.com</a><span style="color:black"> <</span><a href="mailto:ard.biesheuvel@arm.com">ard.biesheuvel@arm.com</a><span style="color:black">>; </span><a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a><span style="color:black"> <</span><a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a><span style="color:black">>; </span><a href="mailto:pete@akeo.ie">pete@akeo.ie</a><span style="color:black"> <</span><a href="mailto:pete@akeo.ie">pete@akeo.ie</a><span style="color:black">>; </span><a href="mailto:samer.el-haj-mahmoud@arm.com">samer.el-haj-mahmoud@arm.com</a><span style="color:black"> <</span><a href="mailto:samer.el-haj-mahmoud@arm.com">samer.el-haj-mahmoud@arm.com</a><span style="color:black">>; Andrei Warkentin <</span><a href="mailto:awarkentin@vmware.com">awarkentin@vmware.com</a><span style="color:black">>; Jeremy Linton <</span><a href="mailto:jeremy.linton@arm.com">jeremy.linton@arm.com</a><span style="color:black">><br> <b>Subject:</b> [PATCH 0/3] SD+USB perf/DMA fixes</span> <o:p></o:p></p> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt">A large part of why the emmc & dwc2 usb<br> controllers haven't been working properly is<br> because the "bus" _DMA was incorrectly tagged<br> as a consumer, when it needs to be a producer.<br> <br> That is why linux has been dropping the<br> translation value portions of _DMA().<br> <br> Since the emmc2 dma (with the old B0 SoC), and the<br> dwc2 is expected to work, lets add matching 30 bit<br> IORT entries for them.<br> <br> Finally, in the shuffle the high speed cap bit override<br> was dropped from the linux patches, and I failed<br> to add it back to the firmware values, this caused<br> the wifi perf to be lower than it should have been.<br> <br> Jeremy Linton (3):<br> Platform/RaspberryPi/Acpitables: Enable Arasan hispeed mode<br> Platform/RaspberryPi/AcpiTables: Add further named components<br> Platform/RaspberryPi/AcpiTables: Correct _DMA consumer<br> <br> Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +-<br> Platform/RaspberryPi/AcpiTables/Emmc.asl | 2 +-<br> Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 ++++++++++++++++++++++++++++++-<br> Platform/RaspberryPi/AcpiTables/Sdhc.asl | 2 +-<br> 4 files changed, 46 insertions(+), 4 deletions(-)<br> <br> -- <br> 2.13.7<o:p></o:p></p> </div> </div> </div> </div> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/74672">View/Reply Online (#74672)</a> | | <a target="_blank" href="https://groups.io/mt/81935641/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>