<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> + Ard’s new e-mail address<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Andrei Warkentin <awarkentin@vmware.com> Sent: Thursday, April 8, 2021 10:17 AM To: Jeremy Linton <Jeremy.Linton@arm.com>; devel@edk2.groups.io Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; leif@nuviainc.com; pete@akeo.ie; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com> Subject: Re: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components<o:p></o:p> </div> </div> <o:p> </o:p> <div> Reviewed-by: Andrei Warkentin <<a href="mailto:awarkentin@vmware.com">awarkentin@vmware.com</a>><o:p></o:p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> From: Jeremy Linton <<a href="mailto:jeremy.linton@arm.com">jeremy.linton@arm.com</a>> Sent: Thursday, April 8, 2021 12:58 AM To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> Cc: <a href="mailto:ard.biesheuvel@arm.com">ard.biesheuvel@arm.com</a> <<a href="mailto:ard.biesheuvel@arm.com">ard.biesheuvel@arm.com</a>>; <a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a> <<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>>; <a href="mailto:pete@akeo.ie">pete@akeo.ie</a> <<a href="mailto:pete@akeo.ie">pete@akeo.ie</a>>; <a href="mailto:samer.el-haj-mahmoud@arm.com">samer.el-haj-mahmoud@arm.com</a> <<a href="mailto:samer.el-haj-mahmoud@arm.com">samer.el-haj-mahmoud@arm.com</a>>; Andrei Warkentin <<a href="mailto:awarkentin@vmware.com">awarkentin@vmware.com</a>>; Jeremy Linton <<a href="mailto:jeremy.linton@arm.com">jeremy.linton@arm.com</a>> Subject: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> Add some additional IORT nodes for the USB & EMMC devices, realistically we probably only need to have a single node with the lowest AddressSizeLimit but this is conceptually "cleaner" should anyone actually try and use these values rather than the _DMA provided ones. Signed-off-by: Jeremy Linton <<a href="mailto:jeremy.linton@arm.com">jeremy.linton@arm.com</a>> --- Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 ++++++++++++++++++++++++++++++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc b/Platform/RaspberryPi/AcpiTables/Iort.aslc index 00720194bb..810307ae37 100644 --- a/Platform/RaspberryPi/AcpiTables/Iort.aslc +++ b/Platform/RaspberryPi/AcpiTables/Iort.aslc @@ -20,6 +20,8 @@ typedef struct { typedef struct { EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort; RPI4_NC_NODE NamedCompNode; + RPI4_NC_NODE NamedCompNode2; + RPI4_NC_NODE NamedCompNode3; } RPI4_IO_REMAPPING_STRUCTURE; STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = { @@ -27,7 +29,7 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = { ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE, RPI4_IO_REMAPPING_STRUCTURE, EFI_ACPI_IO_REMAPPING_TABLE_REVISION), - 1, // NumNodes + 3, // NumNodes sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset 0 // Reserved }, { @@ -50,6 +52,46 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = { }, { "<a href="file://_SB_.SCB0.XHC0">\\_SB_.SCB0.XHC0</a>" // ObjectName } + }, { + // gpu/dwc usb named component node + { + { + EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type + sizeof (RPI4_NC_NODE), // Length + 0x0, // Revision + 0x0, // Reserved + 0x0, // NumIdMappings + 0x0, // IdReference + }, + 0x0, // Flags + 0x0, // CacheCoherent + 0x0, // AllocationHints + 0x0, // Reserved + 0x0, // MemoryAccessFlags + 30, // AddressSizeLimit + }, { + "<a href="file://_SB_.GDV0.USB0">\\_SB_.GDV0.USB0</a>" // ObjectName + } + }, { + // emmc2 named component node + { + { + EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type + sizeof (RPI4_NC_NODE), // Length + 0x0, // Revision + 0x0, // Reserved + 0x0, // NumIdMappings + 0x0, // IdReference + }, + 0x0, // Flags + 0x0, // CacheCoherent + 0x0, // AllocationHints + 0x0, // Reserved + 0x0, // MemoryAccessFlags + 30, // AddressSizeLimit + }, { + "<a href="file://_SB_.GDV1.SDC3">\\_SB_.GDV1.SDC3</a>" // ObjectName + } } }; -- 2.13.7<o:p></o:p> </div> </div> </div> </div> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/74893">View/Reply Online (#74893)</a> | | <a target="_blank" href="https://groups.io/mt/81935644/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>