<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">I'm checking out the PREBUILD and POSTBUILD option in a DSC. I can launch my scripts, etc.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">When there is a POSTBUILD error, build.py properly says the build failed, but build.py is still returning 0 (success). MyBuild.LaunchPostBuild() execution does not look like it affects ReturnCode which is returned at the end of Main.
"Conclusion" is updated though to indicate a failure. Any ideas? I assume build.py should return non-zero if POSTBUILD fails.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">From end of edk-stable202011build.py:Main()<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> if ReturnCode == 0:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> try:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> MyBuild.LaunchPostbuild()<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> Conclusion = "Done"<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> except:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> Conclusion = "Failed"<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> elif ReturnCode == ABORT_ERROR:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> Conclusion = "Aborted"<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> else:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> Conclusion = "Failed"<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> FinishTime = time.time()<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> BuildDuration = time.gmtime(int(round(FinishTime - StartTime)))<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> BuildDurationStr = ""<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> if BuildDuration.tm_yday > 1:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> BuildDurationStr = time.strftime("%H:%M:%S", BuildDuration) + ", %d day(s)" % (BuildDuration.tm_yday - 1)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> else:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> BuildDurationStr = time.strftime("%H:%M:%S", BuildDuration)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> if MyBuild is not None:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> if not BuildError:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> MyBuild.BuildReport.GenerateReport(BuildDurationStr, LogBuildTime(MyBuild.AutoGenTime), LogBuildTime(MyBuild.MakeTime), LogBuildTime(MyBuild.GenFdsTime))<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> EdkLogger.SetLevel(EdkLogger.QUIET)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> EdkLogger.quiet("\n- %s -" % Conclusion)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> EdkLogger.quiet(time.strftime("Build end time: %H:%M:%S, %b.%d %Y", time.localtime()))<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> EdkLogger.quiet("Build total time: %s\n" % BuildDurationStr)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> Log_Agent.kill()<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> Log_Agent.join()<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> return ReturnCode<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">master is the same code:<o:p></o:p></p>
<p class="MsoNormal"><a href="https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/build/build.py#L2738">https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/build/build.py#L2738</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><b><span style="color:black;text-transform:uppercase">Garrett Kirkendall</span></b><span style="font-size:10.0pt;color:black"><br>
SMTS Firmware Engineer<br>
7171 Southwest Parkway, Austin, TX 78735 USA <br>
</span><b><span style="font-size:14.0pt;color:black">AMD</span></b><span style="font-size:10.0pt;color:black">
</span><a href="https://www.facebook.com/AMD"><span style="font-size:10.0pt;color:#7030A0">facebook</span></a><span style="font-size:10.0pt;color:#7030A0"> |
</span><a href="http://www.amd.com/"><span style="font-size:10.0pt;color:#7030A0">amd.com</span></a><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/74909">View/Reply Online (#74909)</a> | | <a target="_blank" href="https://groups.io/mt/82729650/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>