<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-GB" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> Hi Sayanta,<o:p></o:p> <o:p> </o:p> Thanks for confirming.<o:p></o:p> <o:p> </o:p> With that.<o:p></o:p> <o:p> </o:p> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com><o:p></o:p> <o:p> </o:p> Regards,<o:p></o:p> <o:p> </o:p> Sami Mujawar<o:p></o:p> <o:p> </o:p> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Sayanta Pattanayak <Sayanta.Pattanayak@arm.com> Date: Wednesday, 26 May 2021 at 19:15 To: Sami Mujawar <Sami.Mujawar@arm.com>, devel@edk2.groups.io <devel@edk2.groups.io> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>, nd <nd@arm.com> Subject: RE: [edk2-platforms][PATCH V1 3/3] Platform/Sgi: enable support for UEFI secure boot<o:p></o:p> </div> <div> Hi Sami, Thanks for the review and suggestion. Please find my reply inline. > > Hi Sayanta, > > Thank you for this patch. > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 24/05/2021 06:23 PM, Sayanta Pattanayak wrote: > > Enable the use of UEFI secure boot for Arm's Neoverse reference design > > platforms. The UEFI authenticated variable store uses NOR flash 2 > > which is accessible from Standalone MM context residing in a secure > partition. > > > > Signed-off-by: Sayanta Pattanayak <sayanta.pattanayak@arm.com> > > --- > > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 31 > +++++++++++++++++++ > > Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 32 > ++++++++++++++++++++ > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 15 +++++++++ > > Platform/ARM/SgiPkg/PlatformStandaloneMm2.dsc | 15 +++++++++ > > Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 5 +++ > > Platform/ARM/SgiPkg/SgiPlatform.fdf | 9 +++++- > > 6 files changed, 106 insertions(+), 1 deletion(-) > > <...> > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > > +!endif > > diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > > b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > > index 3389ff676a91..6839ec35da8a 100644 > > --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > > +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > > @@ -59,6 +59,19 @@ > > > HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmH > obLib.inf > > > MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/Stan > daloneMmServicesTableLib.inf > > > > > MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAll > ocati > > onLib/StandaloneMmMemoryAllocationLib.inf > > +!if $(SECURE_STORAGE_ENABLE) == TRUE > > + > > +AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.i > > +nf > > + BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > + IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > > + > > > +NorFlashPlatformLib|Platform/ARM/SgiPkg/Library/NorFlashLib/Standalon > > +eMmNorFlashLib.inf > > + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > [SAMI] There is a recent patch series that adds ARMv8.5 FEAT_RNG support > to BaseRngLib > see > <a href="https://github.com/tianocore/edk2/commit/9301e5644cef5a5234f71b178373"> https://github.com/tianocore/edk2/commit/9301e5644cef5a5234f71b178373</a> > dd508cabb9ee. > Can this be used instead of BaseRngLibTimerLib? BaseRngLibTimerLib is for > non-production use so it would be good to avoid. > Indeed, this would require that Sgi platforms are ARMv8.5 or above. If not, > then can we conditionally use BaseRngLibTimerLib for platforms that do not > support FEAT_RNG. > [/SAMI] Current SGI platforms with secureboot are of pre ARMv8.5. For ARMv8.5 and above SGI platform, will follow the conditional approach. Regards, Sayanta <...><o:p></o:p> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/75668">View/Reply Online (#75668)</a> | | <a target="_blank" href="https://groups.io/mt/83062022/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>