<div dir="ltr"><br><br>On Thu, May 27, 2021 at 2:07 PM Leif Lindholm <<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>> wrote:<br>><br>> On Wed, May 26, 2021 at 22:14:03 +0200, Laszlo Ersek wrote:<br>> > Bugzilla: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=2122">https://bugzilla.tianocore.org/show_bug.cgi?id=2122</a><br>> > Repo: <a href="https://pagure.io/lersek/edk2.git">https://pagure.io/lersek/edk2.git</a><br>> > Branch: xen_split_bz_2122<br>> ><br>> > This patch set removes dynamic Xen enlightenment from the following<br>> > platforms:<br>> ><br>> > OvmfPkg/OvmfPkgIa32.dsc<br>> > OvmfPkg/OvmfPkgIa32X64.dsc<br>> > OvmfPkg/OvmfPkgX64.dsc<br>> ><br>> > In Xen guests, the following platform should be used:<br>> ><br>> > OvmfPkg/OvmfXen.dsc<br>> ><br>> > Please see more details / references in the bugzilla ticket.<br>> ><br>> > NOOPT build savings:<br>> ><br>> > - Ia32: PEIFV 1536 bytes, DXEFV 130288 bytes<br>> > - Ia32X64: PEIFV 1536 bytes, DXEFV 140912 bytes<br>> > - X64: PEIFV 1664 bytes, DXEFV 140912 bytes<br>> > - Xen: PEIFV 256 bytes, DXEFV 69504 bytes<br>> ><br>> > Functional testing:<br>> ><br>> > - Booted a Fedora guest on OvmfPkgIa32X64 on QEMU/KVM, compared verbose<br>> > logs before-after. Memory allocations were satisfied at different<br>> > addresses, as expected, plus the Xen drivers were absent. No<br>> > differences otherwise.<br>> ><br>> > - Booted a RHEL guest on ArmVirtQemu on AARCH64. Memory allocations were<br>> > satisfied at different addresses, as expected.<br>> ><br>> > - Xen regression-testing was not done; I'm requesting feedback.<br>> ><br>> > Build testing / bisectability: at every stage, the series builds with<br>> > the following script:<br>> ><br>> > > #!/bin/bash<br>> > > set -e -u -C<br>> > ><br>> > > build -b DEBUG -t GCC5 -p ArmVirtPkg/ArmVirtKvmTool.dsc -a AARCH64<br>> > > build -b DEBUG -t GCC5 -p ArmVirtPkg/ArmVirtKvmTool.dsc -a ARM<br>> > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemu.dsc -a AARCH64<br>> > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemu.dsc -a ARM<br>> > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemuKernel.dsc -a AARCH64<br>> > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemuKernel.dsc -a ARM<br>> > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtXen.dsc -a AARCH64<br>> > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtXen.dsc -a ARM<br>> > > build -b NOOPT -t GCC5 -p OvmfPkg/AmdSev/AmdSevX64.dsc -a X64<br>> > > build -b NOOPT -t GCC5 -p OvmfPkg/Bhyve/BhyveX64.dsc -a X64<br>> > > build -b NOOPT -t GCC5 -p OvmfPkg/OvmfPkgIa32.dsc -a IA32<br>> > > build -b NOOPT -t GCC5 -p OvmfPkg/OvmfPkgIa32X64.dsc -a IA32 -a X64<br>> > > build -b NOOPT -t GCC5 -p OvmfPkg/OvmfPkgX64.dsc -a X64<br>> > > build -b NOOPT -t GCC5 -p OvmfPkg/OvmfXen.dsc -a X64<br>> ><br>> > The patches in the series were formatted with the following options, for<br>> > posting:<br>> ><br>> > --stat=1000 --stat-graph-width=20 --find-copies-harder -U6<br>> ><br>> > (The option "--find-copies-harder" is not the best for presenting every<br>> > single patch in the series, in isolation, but taken globally for the<br>> > entire series, it is the most helpful option.)<br>> ><br>> > Some patches advance with really small steps, in order to cut down on a<br>> > subsequent "meaty" patch. Personally I don't like reviewing code<br>> > movement patches, so I did my best to (a) keep that to a minimum, and<br>> > (b) present it as unintrusively as possible.<br>> ><br>> > The CC list is a bit long; the reason is that I kept touching up<br>> > "Maintainers.txt", and the "OvmfPkg/Bhyve" and "OvmfPkg/AmdSev"<br>> > platforms as well (whenever it made sense).<br>><br>> I presume I was primarily cc:d for the Maintainers.txt bit?<br><div>> For that (patches 11, 12, 21):</div><div>> Reviewed-by: Leif Lindholm <<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>><br></div><div><br></div><div>Gah. Also for 32,39/43:<br></div><div>Reviewed-by: Leif Lindholm <<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>></div><div><br></div><div>Sorry, I think that's all of them.<br></div><div><br></div><div>/</div><div> Leif<br></div></div>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/75813">View/Reply Online (#75813)</a> | | <a target="_blank" href="https://groups.io/mt/83110232/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>