<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-GB" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> Hi Pierre,<o:p></o:p> <o:p> </o:p> Thank you for this patch series.<o:p></o:p> <o:p> </o:p> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com><o:p></o:p> <o:p> </o:p> Regards,<o:p></o:p> <o:p> </o:p> Sami Mujawar<o:p></o:p> <o:p> </o:p> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com> Date: Tuesday, 1 June 2021 at 23:05 To: devel@edk2.groups.io <devel@edk2.groups.io>, dandan.bi@intel.com <dandan.bi@intel.com>, gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>, michael.d.kinney@intel.com <michael.d.kinney@intel.com>, Sami Mujawar <Sami.Mujawar@arm.com>, Alexei Fedorov <Alexei.Fedorov@arm.com> Subject: [PATCH v1 0/2] Define AML_NAME_SEG_SIZE<o:p></o:p> </div> <div> From: Pierre Gondois <Pierre.Gondois@arm.com> There is currently multiple AML_NAME_SEG_SIZE define in the edk2 repository. One in the MdeModulePkg and one in the DynamicTablesPkg package. Since the value can be inferred from the ACPI specification, it could be moved to MdePkg/Include/IndustryStandard/ and avoid re-definitions The two patches should be merged at once to avoid having multiple definitions of AML_NAME_SEG_SIZE. The changes can be seen at: <a href="https://github.com/PierreARM/edk2/tree/1750_Add_AML_NAMESEG_SIZE_v1">https://github.com/PierreARM/edk2/tree/1750_Add_AML_NAMESEG_SIZE_v1</a> The results of the CI can be seen at: <a href="https://github.com/tianocore/edk2/pull/1681">https://github.com/tianocore/edk2/pull/1681</a> Pierre Gondois (2): MdePkg/MdeModulePkg: Move AML_NAME_SEG_SIZE definition DynamicTablesPkg: Use AML_NAME_SEG_SIZE define .../Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c | 4 ++-- .../AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c | 4 ++-- DynamicTablesPkg/Library/Common/AmlLib/AmlDefines.h | 9 +-------- MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiSdt.h | 1 - MdePkg/Include/IndustryStandard/AcpiAml.h | 7 ++++++- 5 files changed, 11 insertions(+), 14 deletions(-) -- 2.17.1<o:p></o:p> </div> </div> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/75963">View/Reply Online (#75963)</a> | | <a target="_blank" href="https://groups.io/mt/83245166/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>