<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=gb2312">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Hao,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
For this patch, can I keep your reviewed-by?</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I just added<span style="color:rgb(32, 31, 30);font-family:"Microsoft Yahei UI", Verdana, Simsun, "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif;font-size:14.6667px;background-color:rgb(255, 255, 255);display:inline !important"> ExceptionList
in MdeModulePkg\MdeModulePkg.ci.yaml, to avoid CI failure.</span></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color:rgb(32, 31, 30);font-family:"Microsoft Yahei UI", Verdana, Simsun, "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif;font-size:14.6667px;background-color:rgb(255, 255, 255);display:inline !important"><br>
</span></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color:rgb(32, 31, 30);font-family:"Microsoft Yahei UI", Verdana, Simsun, "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif;font-size:14.6667px;background-color:rgb(255, 255, 255);display:inline !important">Thanks</span></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color:rgb(32, 31, 30);font-family:"Microsoft Yahei UI", Verdana, Simsun, "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif;font-size:14.6667px;background-color:rgb(255, 255, 255);display:inline !important">Zhiguang</span></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>发件人:</b> devel@edk2.groups.io <devel@edk2.groups.io> 代表 Zhiguang Liu <zhiguang.liu@intel.com><br>
<b>发送时间:</b> 2021年6月15日 17:12<br>
<b>收件人:</b> devel@edk2.groups.io <devel@edk2.groups.io><br>
<b>抄送:</b> Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com><br>
<b>主题:</b> [edk2-devel] [Patch V5 2/9] MdeModulePkg: Add new structure for the PCI Root Bridge Info Hob</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">V5:<br>
Add ExceptionList in MdeModulePkg\MdeModulePkg.ci.yaml, to avoid open CI<br>
issue, because UID and HID are terms which are already used in current<br>
source code.<br>
<br>
Cc: Michael D Kinney <michael.d.kinney@intel.com><br>
Cc: Liming Gao <gaoliming@byosoft.com.cn><br>
Cc: Jian J Wang <jian.j.wang@intel.com><br>
Cc: Hao A Wu <hao.a.wu@intel.com><br>
Reviewed-by: Hao A Wu <hao.a.wu@intel.com><br>
Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com><br>
---<br>
MdeModulePkg/Include/UniversalPayload/PciRootBridges.h | 91 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++<br>
MdeModulePkg/MdeModulePkg.ci.yaml | 2 ++<br>
MdeModulePkg/MdeModulePkg.dec | 6 ++++++<br>
3 files changed, 99 insertions(+)<br>
<br>
diff --git a/MdeModulePkg/Include/UniversalPayload/PciRootBridges.h b/MdeModulePkg/Include/UniversalPayload/PciRootBridges.h<br>
new file mode 100644<br>
index 0000000000..3a7aae82d4<br>
--- /dev/null<br>
+++ b/MdeModulePkg/Include/UniversalPayload/PciRootBridges.h<br>
@@ -0,0 +1,91 @@<br>
+/** @file<br>
<br>
+ This file defines the structure for the PCI Root Bridges.<br>
<br>
+<br>
<br>
+ Copyright (c) 2021, Intel Corporation. All rights reserved.<BR><br>
<br>
+ SPDX-License-Identifier: BSD-2-Clause-Patent<br>
<br>
+<br>
<br>
+ @par Revision Reference:<br>
<br>
+ - Universal Payload Specification 0.75 (<a href="https://universalpayload.github.io/documentation/">https://universalpayload.github.io/documentation/</a>)<br>
<br>
+**/<br>
<br>
+<br>
<br>
+#ifndef UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGES_H_<br>
<br>
+#define UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGES_H_<br>
<br>
+<br>
<br>
+#include <UniversalPayload/UniversalPayload.h><br>
<br>
+<br>
<br>
+#pragma pack(1)<br>
<br>
+<br>
<br>
+//<br>
<br>
+// (Base > Limit) indicates an aperture is not available.<br>
<br>
+//<br>
<br>
+typedef struct {<br>
<br>
+ //<br>
<br>
+ // Base and Limit are the device address instead of host address when<br>
<br>
+ // Translation is not zero<br>
<br>
+ //<br>
<br>
+ UINT64 Base;<br>
<br>
+ UINT64 Limit;<br>
<br>
+ //<br>
<br>
+ // According to UEFI 2.7, Device Address = Host Address + Translation,<br>
<br>
+ // so Translation = Device Address - Host Address.<br>
<br>
+ // On platforms where Translation is not zero, the subtraction is probably to<br>
<br>
+ // be performed with UINT64 wrap-around semantics, for we may translate an<br>
<br>
+ // above-4G host address into a below-4G device address for legacy PCIe device<br>
<br>
+ // compatibility.<br>
<br>
+ //<br>
<br>
+ // NOTE: The alignment of Translation is required to be larger than any BAR<br>
<br>
+ // alignment in the same root bridge, so that the same alignment can be<br>
<br>
+ // applied to both device address and host address, which simplifies the<br>
<br>
+ // situation and makes the current resource allocation code in generic PCI<br>
<br>
+ // host bridge driver still work.<br>
<br>
+ //<br>
<br>
+ UINT64 Translation;<br>
<br>
+} UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGE_APERTURE;<br>
<br>
+<br>
<br>
+///<br>
<br>
+/// Payload PCI Root Bridge Information HOB<br>
<br>
+///<br>
<br>
+typedef struct {<br>
<br>
+ UINT32 Segment; ///< Segment number.<br>
<br>
+ UINT64 Supports; ///< Supported attributes.<br>
<br>
+ ///< Refer to EFI_PCI_ATTRIBUTE_xxx used by GetAttributes()<br>
<br>
+ ///< and SetAttributes() in EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL.<br>
<br>
+ UINT64 Attributes; ///< Initial attributes.<br>
<br>
+ ///< Refer to EFI_PCI_ATTRIBUTE_xxx used by GetAttributes()<br>
<br>
+ ///< and SetAttributes() in EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL.<br>
<br>
+ BOOLEAN DmaAbove4G; ///< DMA above 4GB memory.<br>
<br>
+ ///< Set to TRUE when root bridge supports DMA above 4GB memory.<br>
<br>
+ BOOLEAN NoExtendedConfigSpace; ///< When FALSE, the root bridge supports<br>
<br>
+ ///< Extended (4096-byte) Configuration Space.<br>
<br>
+ ///< When TRUE, the root bridge supports<br>
<br>
+ ///< 256-byte Configuration Space only.<br>
<br>
+ UINT64 AllocationAttributes; ///< Allocation attributes.<br>
<br>
+ ///< Refer to EFI_PCI_HOST_BRIDGE_COMBINE_MEM_PMEM and<br>
<br>
+ ///< EFI_PCI_HOST_BRIDGE_MEM64_DECODE used by GetAllocAttributes()<br>
<br>
+ ///< in EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL.<br>
<br>
+ UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGE_APERTURE Bus; ///< Bus aperture which can be used by the root bridge.<br>
<br>
+ UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGE_APERTURE Io; ///< IO aperture which can be used by the root bridge.<br>
<br>
+ UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGE_APERTURE Mem; ///< MMIO aperture below 4GB which can be used by the root bridge.<br>
<br>
+ UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGE_APERTURE MemAbove4G; ///< MMIO aperture above 4GB which can be used by the root bridge.<br>
<br>
+ UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGE_APERTURE PMem; ///< Prefetchable MMIO aperture below 4GB which can be used by the root bridge.<br>
<br>
+ UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGE_APERTURE PMemAbove4G; ///< Prefetchable MMIO aperture above 4GB which can be used by the root bridge.<br>
<br>
+ UINT32 HID; ///< PnP hardware ID of the root bridge. This value must match the corresponding<br>
<br>
+ ///< _HID in the ACPI name space.<br>
<br>
+ UINT32 UID; ///< Unique ID that is required by ACPI if two devices have the same _HID.<br>
<br>
+ ///< This value must also match the corresponding _UID/_HID pair in the ACPI name space.<br>
<br>
+} UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGE;<br>
<br>
+<br>
<br>
+typedef struct {<br>
<br>
+ UNIVERSAL_PAYLOAD_GENERIC_HEADER Header;<br>
<br>
+ BOOLEAN ResourceAssigned;<br>
<br>
+ UINT8 Count;<br>
<br>
+ UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGE RootBridge[0];<br>
<br>
+} UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGES;<br>
<br>
+<br>
<br>
+#pragma pack()<br>
<br>
+<br>
<br>
+#define UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGES_REVISION 1<br>
<br>
+<br>
<br>
+extern GUID gUniversalPayloadPciRootBridgeInfoGuid;<br>
<br>
+<br>
<br>
+#endif // UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGES_H_<br>
<br>
diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePkg.ci.yaml<br>
index 45783f12c1..4c71468bd3 100644<br>
--- a/MdeModulePkg/MdeModulePkg.ci.yaml<br>
+++ b/MdeModulePkg/MdeModulePkg.ci.yaml<br>
@@ -16,6 +16,8 @@<br>
## "<ErrorID>", "<KeyWord>"<br>
<br>
## ]<br>
<br>
"ExceptionList": [<br>
<br>
+ "8005", "UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGE.UID",<br>
<br>
+ "8005", "UNIVERSAL_PAYLOAD_PCI_ROOT_BRIDGE.HID",<br>
<br>
],<br>
<br>
## Both file path and directory path are accepted.<br>
<br>
"IgnoreFiles": [<br>
<br>
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec<br>
index 8d38383915..5cee4e159a 100644<br>
--- a/MdeModulePkg/MdeModulePkg.dec<br>
+++ b/MdeModulePkg/MdeModulePkg.dec<br>
@@ -404,6 +404,12 @@<br>
## Include/Guid/MigratedFvInfo.h<br>
<br>
gEdkiiMigratedFvInfoGuid = { 0xc1ab12f7, 0x74aa, 0x408d, { 0xa2, 0xf4, 0xc6, 0xce, 0xfd, 0x17, 0x98, 0x71 } }<br>
<br>
<br>
<br>
+ #<br>
<br>
+ # GUID defined in UniversalPayload<br>
<br>
+ #<br>
<br>
+ ## Include/UniversalPayload/PciRootBridges.h<br>
<br>
+ gUniversalPayloadPciRootBridgeInfoGuid = { 0xec4ebacb, 0x2638, 0x416e, { 0xbe, 0x80, 0xe5, 0xfa, 0x4b, 0x51, 0x19, 0x01 }}<br>
<br>
+<br>
<br>
[Ppis]<br>
<br>
## Include/Ppi/AtaController.h<br>
<br>
gPeiAtaControllerPpiGuid = { 0xa45e60d1, 0xc719, 0x44aa, { 0xb0, 0x7a, 0xaa, 0x77, 0x7f, 0x85, 0x90, 0x6d }}<br>
<br>
-- <br>
2.30.0.windows.2<br>
<br>
<br>
<br>
-=-=-=-=-=-=<br>
Groups.io Links: You receive all messages sent to this group.<br>
View/Reply Online (#76506): <a href="https://edk2.groups.io/g/devel/message/76506">
https://edk2.groups.io/g/devel/message/76506</a><br>
Mute This Topic: <a href="https://groups.io/mt/83551777/1779286">https://groups.io/mt/83551777/1779286</a><br>
Group Owner: devel+owner@edk2.groups.io<br>
Unsubscribe: <a href="https://edk2.groups.io/g/devel/unsub">https://edk2.groups.io/g/devel/unsub</a> [zhiguang.liu@intel.com]<br>
-=-=-=-=-=-=<br>
<br>
<br>
</div>
</span></font></div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/76514">View/Reply Online (#76514)</a> | | <a target="_blank" href="https://groups.io/mt/83551873/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>