<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">- Bret <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="border:none;padding:0in"><b>From: </b><a href="mailto:spbrogan@outlook.com">Sean Brogan</a><br>
<b>Sent: </b>Tuesday, June 15, 2021 9:00 AM<br>
<b>To: </b><a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; <a href="mailto:kuqin12@gmail.com">
kuqin12@gmail.com</a><br>
<b>Cc: </b><a href="mailto:sean.brogan@microsoft.com">Sean Brogan</a>; <a href="mailto:Bret.Barkelew@microsoft.com">
Bret Barkelew</a>; <a href="mailto:michael.d.kinney@intel.com">Kinney, Michael D</a>;
<a href="mailto:gaoliming@byosoft.com.cn">Liming Gao</a><br>
<b>Subject: </b>[EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters</p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please update the signed-off-by to include yours.<br>
<br>
Reviewed-by: Sean Brogan <sean.brogan@microsoft.com><br>
<br>
Thanks<br>
Sean<br>
<br>
<br>
On 6/11/2021 10:04 PM, Kun Qin wrote:<br>
> From: Sean Brogan <sean.brogan@microsoft.com><br>
> <br>
> REF: <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3454&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C436f445e3f774d2549b608d930169d05%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637593696216659744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pJiLG4bZ8gYR0MjDuNTmuT3NgRjq%2FZRMnTi1sT67VqM%3D&reserved=0">
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3454&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C436f445e3f774d2549b608d930169d05%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637593696216659744%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pJiLG4bZ8gYR0MjDuNTmuT3NgRjq%2FZRMnTi1sT67VqM%3D&reserved=0</a><br>
> <br>
> On Linux the shell expands the wildcard paths and causes multiple files<br>
> to be missed. This change adds additional quotes to defer expansion in<br>
> order to bring parity in cspell result.<br>
> <br>
> Cc: Sean Brogan <sean.brogan@microsoft.com><br>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com><br>
> Cc: Michael D Kinney <michael.d.kinney@intel.com><br>
> Cc: Liming Gao <gaoliming@byosoft.com.cn><br>
> <br>
> Signed-off-by: Sean Brogan <sean.brogan@microsoft.com><br>
> ---<br>
> .pytool/Plugin/SpellCheck/SpellCheck.py | 3 ++-<br>
> 1 file changed, 2 insertions(+), 1 deletion(-)<br>
> <br>
> diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py b/.pytool/Plugin/SpellCheck/SpellCheck.py<br>
> index 43365441b91c..97b240ef747c 100644<br>
> --- a/.pytool/Plugin/SpellCheck/SpellCheck.py<br>
> +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py<br>
> @@ -133,7 +133,8 @@ class SpellCheck(ICiBuildPlugin):<br>
> #<br>
> relpath = os.path.relpath(abs_pkg_path)<br>
> cpsell_paths = " ".join(<br>
> - [f"{relpath}/**/{x}" for x in package_relative_paths_to_spell_check])<br>
> + # Double quote each path to defer expansion to cspell parameters<br>
> + [f'"{relpath}/**/{x}"' for x in package_relative_paths_to_spell_check])<br>
> <br>
> # Make the config file<br>
> config_file_path = os.path.join(<br>
> <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/76530">View/Reply Online (#76530)</a> | | <a target="_blank" href="https://groups.io/mt/83559790/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>