<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Reviewed-by: Daniel Schaefer <daniel.schaefer@hpe.com> </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Abner Chang <abner.chang@hpe.com> Sent: Thursday, July 1, 2021 11:50 To: devel@edk2.groups.io <devel@edk2.groups.io>; gjb@semihalf.com <gjb@semihalf.com> Cc: leif@nuviainc.com <leif@nuviainc.com>; ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>; Samer.El-Haj-Mahmoud@arm.com <Samer.El-Haj-Mahmoud@arm.com>; sunny.Wang@arm.com <sunny.Wang@arm.com>; mw@semihalf.com <mw@semihalf.com>; upstream@semihalf.com <upstream@semihalf.com>; jiewen.yao@intel.com <jiewen.yao@intel.com>; jian.j.wang@intel.com <jian.j.wang@intel.com>; min.m.xu@intel.com <min.m.xu@intel.com>; lersek@redhat.com <lersek@redhat.com>; sami.mujawar@arm.com <sami.mujawar@arm.com>; afish@apple.com <afish@apple.com>; ray.ni@intel.com <ray.ni@intel.com>; jordan.l.justen@intel.com <jordan.l.justen@intel.com>; rebecca@bsdio.com <rebecca@bsdio.com>; grehan@freebsd.org <grehan@freebsd.org>; thomas.abraham@arm.com <thomas.abraham@arm.com>; chasel.chiu@intel.com <chasel.chiu@intel.com>; nathaniel.l.desimone@intel.com <nathaniel.l.desimone@intel.com>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; eric.dong@intel.com <eric.dong@intel.com>; michael.d.kinney@intel.com <michael.d.kinney@intel.com>; zailiang.sun@intel.com <zailiang.sun@intel.com>; yi.qian@intel.com <yi.qian@intel.com>; graeme@nuviainc.com <graeme@nuviainc.com>; rad@semihalf.com <rad@semihalf.com>; pete@akeo.ie <pete@akeo.ie> Subject: Re: [edk2-devel] [edk2-platforms PATCH v4 11/12] RISC-V Platforms: add SecureBootVariableLib class resolution <div> </div> </div> <div class="BodyFragment"> <div class="PlainText">Reviewed-by: Abner Chang <abner.chang@hpe.com> > -----Original Message----- > From: devel@edk2.groups.io [<a href="mailto:devel@edk2.groups.io">mailto:devel@edk2.groups.io</a>] On Behalf Of > Grzegorz Bernacki > Sent: Wednesday, June 30, 2021 8:34 PM > To: devel@edk2.groups.io > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer.El-Haj- > Mahmoud@arm.com; sunny.Wang@arm.com; mw@semihalf.com; > upstream@semihalf.com; jiewen.yao@intel.com; jian.j.wang@intel.com; > min.m.xu@intel.com; lersek@redhat.com; sami.mujawar@arm.com; > afish@apple.com; ray.ni@intel.com; jordan.l.justen@intel.com; > rebecca@bsdio.com; grehan@freebsd.org; thomas.abraham@arm.com; > chasel.chiu@intel.com; nathaniel.l.desimone@intel.com; > gaoliming@byosoft.com.cn; eric.dong@intel.com; > michael.d.kinney@intel.com; zailiang.sun@intel.com; yi.qian@intel.com; > graeme@nuviainc.com; rad@semihalf.com; pete@akeo.ie; Grzegorz > Bernacki <gjb@semihalf.com> > Subject: [edk2-devel] [edk2-platforms PATCH v4 11/12] RISC-V Platforms: > add SecureBootVariableLib class resolution > > The edk2 patch > SecurityPkg: Create library for setting Secure Boot variables. > > removes generic functions from SecureBootConfigDxe and places > them into SecureBootVariableLib. This patch adds SecureBootVariableLib > mapping for each RICS-V platform which uses SecureBootConfigDxe. > > Signed-off-by: Grzegorz Bernacki <gjb@semihalf.com> > --- > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 + > > Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > index b91823ceeb..fc5ba2a07f 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > @@ -122,6 +122,7 @@ > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTp > mMeasurementLib.inf > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > + > SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureB > ootVariableLib.inf > !else > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tp > mMeasurementLibNull.inf > > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableL > ibNull.inf > diff --git > a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d > sc > b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540. > dsc > index 0eafe29880..71add8ff9a 100644 > --- > a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d > sc > +++ > b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540. > dsc > @@ -122,6 +122,7 @@ > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTp > mMeasurementLib.inf > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > + > SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureB > ootVariableLib.inf > !else > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tp > mMeasurementLibNull.inf > > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableL > ibNull.inf > -- > 2.25.1 > > > > > </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/77388">View/Reply Online (#77388)</a> | | <a target="_blank" href="https://groups.io/mt/83891041/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>