<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Thank you Andrew, you are right. I missed the fact that there are 2 INFs in there.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Andrew Fish <afish@apple.com> <br>
<b>Sent:</b> Wednesday, July 14, 2021 9:14 PM<br>
<b>To:</b> edk2-devel-groups-io <devel@edk2.groups.io>; Arti Gupta <arti.gupta@microsoft.com><br>
<b>Subject:</b> [EXTERNAL] Re: [edk2-devel] BaseCryptLib in ARM incorrectly marked as a DXE_DRIVER<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Arti,<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Can you be a little more specific? Which INF file? How is it used? Sorry I don’t know a lot about this library. <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">The different INF files pull in different allocation strategies for the common library code. <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FCryptoPkg%2FLibrary%2FBaseCryptLib%2FRuntimeCryptLib.inf&data=04%7C01%7Carti.gupta%40microsoft.com%7C9a0bceb1743449d13bdf08d947470322%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637619193528251436%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=l8ZQyxKzbJtGrcdwBpr9ayjex0NZ0k%2FoYW6QxHsClPI%3D&reserved=0">https://github.com/tianocore/edk2/blob/master/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf</a><o:p></o:p></p>
</div>
<div>
<table class="MsoNormalTable" border="0" cellspacing="0" cellpadding="0" style="border-collapse:collapse;box-sizing: border-box;border-spacing: 0px;tab-size: 8;caret-color: rgb(36, 41, 46)">
<tbody>
<tr style="box-sizing: border-box">
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
<tr style="box-sizing: border-box">
<td valign="top" style="padding:0in 7.5pt 0in 7.5pt;box-sizing: border-box;color:var(--color-text-primary);overflow:visible" id="LC64">
<p class="MsoNormal" style="line-height:15.0pt"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif;color:black">SysCall/RuntimeMemAllocation.c
</span><span style="font-size:9.0pt;font-family:Consolas;color:#24292E"><o:p></o:p></span></p>
</td>
</tr>
<tr style="box-sizing: border-box">
<td width="50" nowrap="" valign="top" style="width:37.5pt;padding:0in 7.5pt 0in 7.5pt;box-sizing: border-box;color:var(--color-diff-blob-num-text);cursor:pointer;min-width: 50px;-webkit-user-select: none" id="L65">
</td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="color:black"><a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FCryptoPkg%2FLibrary%2FBaseCryptLib%2FBaseCryptLib.inf&data=04%7C01%7Carti.gupta%40microsoft.com%7C9a0bceb1743449d13bdf08d947470322%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637619193528251436%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=%2FLD37K8PZCqCDzNWL53WQPwx5PYMZYIvtCA0lT88RsM%3D&reserved=0">https://github.com/tianocore/edk2/blob/master/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf</a></span><o:p></o:p></p>
</div>
<table class="MsoNormalTable" border="0" cellspacing="0" cellpadding="0" style="border-collapse:collapse;box-sizing: border-box;border-spacing: 0px;tab-size: 8;caret-color: rgb(36, 41, 46)">
<tbody>
<tr style="box-sizing: border-box">
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
<tr style="box-sizing: border-box">
<td valign="top" style="padding:0in 7.5pt 0in 7.5pt;box-sizing: border-box;color:var(--color-text-primary);overflow:visible" id="LC58">
<p class="MsoNormal" style="line-height:15.0pt"><span style="font-size:9.0pt;font-family:Consolas;color:#24292E">SysCall/BaseMemAllocation.c<o:p></o:p></span></p>
</td>
</tr>
</tbody>
</table>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">The most important line in the INF is:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:Consolas;color:#24292E;background:white">LIBRARY_CLASS = BaseCryptLib|DXE_RUNTIME_DRIVER</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">or<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<table class="MsoNormalTable" border="0" cellspacing="0" cellpadding="0" style="border-collapse:collapse;box-sizing: border-box;border-spacing: 0px;tab-size: 8;caret-color: rgb(36, 41, 46)">
<tbody>
<tr style="box-sizing: border-box">
<td style="padding:.75pt .75pt .75pt .75pt"></td>
</tr>
<tr style="box-sizing: border-box">
<td valign="top" style="padding:0in 7.5pt 0in 7.5pt;box-sizing: border-box;color:var(--color-text-primary);overflow:visible" id="LC22">
<p class="MsoNormal" style="line-height:15.0pt"><span style="font-size:9.0pt;font-family:Consolas;color:#24292E">LIBRARY_CLASS = BaseCryptLib|DXE_DRIVER DXE_CORE UEFI_APPLICATION UEFI_DRIVER<o:p></o:p></span></p>
</td>
</tr>
</tbody>
</table>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">The list after the | is what module types this library can be linked into. I don’t remember what issue a wrong MODULE_TYPE for a library would cause. I think the LIBRARY_CLASS list may override the MODULE_TYPE in terms of how this library
gets consumed. <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Andrew Fish<o:p></o:p></p>
<div>
<p class="MsoNormal"><br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On Jul 14, 2021, at 1:34 PM, Arti Gupta via <a href="https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgroups.io%2F&data=04%7C01%7Carti.gupta%40microsoft.com%7C9a0bceb1743449d13bdf08d947470322%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637619193528261394%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=H%2BE00BTI2lFvJjRtlz2pendG2ZHh4pO8zMvVffUT1Vg%3D&reserved=0">
groups.io</a> <<a href="mailto:arti.gupta=microsoft.com@groups.io">arti.gupta=microsoft.com@groups.io</a>> wrote:<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">Hello,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">I am seeing that the BaseCryptLib in ARM is declared as a DXE_DRIVER instead of a DXE_RUNTIME_DRIVER, however it has a RuntimeMemAllocation.c which registers for the virtualaddresschange event so that tells me that the lib is expected to
live in runtime. Is this bug known? What are the next steps for getting this fixed?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Thanks,<br>
Arti<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"></o:p></span></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/77842">View/Reply Online (#77842)</a> | | <a target="_blank" href="https://groups.io/mt/84264574/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>