<div dir="auto"><div>Yes, we can. I will drop this patch for this  uefipayload batch and send another one for support DISABLE_GCC_MMX_SSE in tools_de.txt.</div><div dir="auto"><br></div><div dir="auto">--</div><div dir="auto">Cheng-Chieh <br><br><div class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">On Thu, Jul 22, 2021, 12:35 AM Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Are those flags needed for all packages that build with GCC?<br>
<br>
Should this be moved into tools_def.txt?<br>
<br>
Mike<br>
<br>
> -----Original Message-----<br>
> From: <a href="mailto:devel@edk2.groups.io" target="_blank" rel="noreferrer">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank" rel="noreferrer">devel@edk2.groups.io</a>> On Behalf Of Cheng-Chieh Huang via <a href="http://groups.io" rel="noreferrer noreferrer" target="_blank">groups.io</a><br>
> Sent: Wednesday, July 21, 2021 6:23 AM<br>
> To: <a href="mailto:devel@edk2.groups.io" target="_blank" rel="noreferrer">devel@edk2.groups.io</a><br>
> Cc: Cheng-Chieh Huang <<a href="mailto:chengchieh@google.com" target="_blank" rel="noreferrer">chengchieh@google.com</a>><br>
> Subject: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation<br>
> <br>
> This will allow we compile payload using gcc8<br>
> <br>
> Signed-off-by: Cheng-Chieh Huang <<a href="mailto:chengchieh@google.com" target="_blank" rel="noreferrer">chengchieh@google.com</a>><br>
> ---<br>
>  UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +++++<br>
>  1 file changed, 5 insertions(+)<br>
> <br>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc<br>
> index 8aa5f18cd35c..fa41c5a24af5 100644<br>
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc<br>
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc<br>
> @@ -30,6 +30,8 @@ [Defines]<br>
>    DEFINE PS2_KEYBOARD_ENABLE          = FALSE<br>
>    DEFINE UNIVERSAL_PAYLOAD            = FALSE<br>
> <br>
> +  DEFINE DISABLE_MMX_SSE              = FALSE<br>
> +<br>
>    #<br>
>    # SBL:      UEFI payload for Slim Bootloader<br>
>    # COREBOOT: UEFI payload for coreboot<br>
> @@ -96,6 +98,9 @@ [BuildOptions]<br>
>    *_*_*_CC_FLAGS                 = -D DISABLE_NEW_DEPRECATED_INTERFACES<br>
>  !if $(BOOTLOADER) == "LINUXBOOT"<br>
>    *_*_*_CC_FLAGS                 = -D LINUXBOOT_PAYLOAD<br>
> +!endif<br>
> +!if $(DISABLE_MMX_SSE)<br>
> +  *_*_*_CC_FLAGS                 = -mno-mmx -mno-sse<br>
>  !endif<br>
>    GCC:*_UNIXGCC_*_CC_FLAGS       = -DMDEPKG_NDEBUG<br>
>    GCC:RELEASE_*_*_CC_FLAGS       = -DMDEPKG_NDEBUG<br>
> --<br>
> 2.32.0.402.g57bb445576-goog<br>
> <br>
> <br>
> <br>
> <br>
> <br>
<br>
</blockquote></div></div></div>


 <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr>   Groups.io Links:<p>   You receive all messages sent to this group.    <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/78038">View/Reply Online (#78038)</a> |    |  <a target="_blank" href="https://groups.io/mt/84357537/1813853">Mute This Topic</a>  | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>    <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |  <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>  [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>