<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="ProgId" content="Word.Document"> <meta name="Generator" content="Microsoft Word 15"> <meta name="Originator" content="Microsoft Word 15"> <link rel="File-List" href="cid:filelist.xml@01D77FA7.7EF17BA0"><link rel="Edit-Time-Data" href="cid:editdata.mso"><style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="tab-interval:.5in;word-wrap:break-word"> <div class="WordSection1"> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman"">Can you provide details on why this flag was needed in the <span class="SpellE">UefiPayloadPkg</span> use case?<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman""><o:p> </o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman"">If the newer versions of the GCC compilers are injecting use of MMX/SSE instructions from optimization of C code, then we need to unconditionally disable that usage in tools_def.txt.<span style="mso-spacerun:yes"> </span>The only place MMX/SSE instructions can be used is in NASM files with proper save/restore of the MMX/SSE state.<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman""><o:p> </o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman"">Here is an example with use of xmm0 that is saved/restored on the stack.<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman""><o:p> </o:p></span></p> <p class="MsoNormal" style="text-indent:.5in"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman""><a href="https://github.com/tianocore/edk2/blob/master/MdePkg/Library/BaseMemoryLibSse2/X64/CopyMem.nasm">https://github.com/tianocore/edk2/blob/master/MdePkg/Library/BaseMemoryLibSse2/X64/CopyMem.nasm</a><o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman""><o:p> </o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman"">Mike<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman""><o:p> </o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="mso-fareast-font-family:"Times New Roman"">From:</span></b><span style="mso-fareast-font-family:"Times New Roman""> Cheng-Chieh Huang <chengchieh@google.com> <br> <b>Sent:</b> Friday, July 23, 2021 4:17 AM<br> <b>To:</b> gaoliming <gaoliming@byosoft.com.cn><br> <b>Cc:</b> devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com><br> <b>Subject:</b> Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal">I got what you mean by "Tools_def.txt doesn’t support build flag" now. I thought the parser does support some sort of if/else condition, but it seems to be not the case. Alternatively, we can do this during the copy (from template to tools_def.txt), but everytime we need to recreate tools_def.txt which is not ideal).<o:p></o:p></p> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">In that case, I think we should just roll back to only doing this in UefiPayloadPkg.dsc. If other packs want to add these flags, they will need to do it on their own.<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">On Fri, Jul 23, 2021 at 6:29 PM gaoliming <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>> wrote:<o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;mso-border-left-alt:solid #CCCCCC .75pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:DengXian;mso-fareast-language:ZH-CN">How do you add this support in tools_def? Can you give the proposal for it?</span><span style="mso-fareast-language:ZH-CN"><o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:DengXian;mso-fareast-language:ZH-CN"> </span><span style="mso-fareast-language:ZH-CN"><o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:DengXian;mso-fareast-language:ZH-CN">Thanks</span><span style="mso-fareast-language:ZH-CN"><o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:DengXian;mso-fareast-language:ZH-CN">Liming</span><span style="mso-fareast-language:ZH-CN"><o:p></o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-outline-level:1"> <b><span lang="ZH-CN" style="font-family:DengXian;mso-fareast-language:ZH-CN">发件人</span></b><b><span style="font-family:DengXian;mso-fareast-language:ZH-CN">:</span></b><span style="font-family:DengXian;mso-fareast-language:ZH-CN"> Cheng-Chieh Huang <<a href="mailto:chengchieh@google.com" target="_blank">chengchieh@google.com</a>> <br> <b><span lang="ZH-CN">发送时间</span>:</b> 2021<span lang="ZH-CN">年</span>7<span lang="ZH-CN">月</span>22<span lang="ZH-CN">日</span> 10:35<br> <b><span lang="ZH-CN">收件人</span>:</b> gaoliming <<a href="mailto:gaoliming@byosoft.com.cn" target="_blank">gaoliming@byosoft.com.cn</a>><br> <b><span lang="ZH-CN">抄送</span>:</b> <a href="mailto:devel@edk2.groups.io" target="_blank"> devel@edk2.groups.io</a>; Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" target="_blank">michael.d.kinney@intel.com</a>><br> <b><span lang="ZH-CN">主题</span>:</b> Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation</span><span style="mso-fareast-language:ZH-CN"><o:p></o:p></span></p> </div> </div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN"> <o:p></o:p></span></p> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN">I mean, I will submit a patch to support DISABLE_GCC_MMX_SSE in tools_def. What do you think?<o:p></o:p></span></p> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN"> <o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN">--<o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN">Cheng-Chieh<o:p></o:p></span></p> </div> </div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN"> <o:p></o:p></span></p> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN">On Thu, Jul 22, 2021 at 9:28 AM gaoliming <<a href="mailto:gaoliming@byosoft.com.cn" target="_blank">gaoliming@byosoft.com.cn</a>> wrote:<o:p></o:p></span></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:10.5pt;font-family:DengXian;mso-fareast-language:ZH-CN">Tools_def.txt doesn<span lang="ZH-CN">’</span>t support build flag </span><span style="mso-fareast-language:ZH-CN">DISABLE_GCC_MMX_SSE. If this flag is moved into BaseTools\Conf\tools_def.template, -mno-mmx -mno-sse option will be the default GCC options. That means all platforms will apply them. <o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN"> <o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN">Thanks<o:p></o:p></span></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN">Liming<o:p></o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-outline-level:1"> <b><span lang="ZH-CN" style="font-family:DengXian;mso-fareast-language:ZH-CN">发件人</span></b><b><span style="font-family:DengXian;mso-fareast-language:ZH-CN">:</span></b><span style="font-family:DengXian;mso-fareast-language:ZH-CN"> <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>> <b><span lang="ZH-CN">代表 </span></b>Cheng-Chieh Huang via <a href="http://groups.io" target="_blank"> groups.io</a><br> <b><span lang="ZH-CN">发送时间</span>:</b> 2021<span lang="ZH-CN">年</span>7<span lang="ZH-CN">月</span>22<span lang="ZH-CN">日</span> 1:43<br> <b><span lang="ZH-CN">收件人</span>:</b> Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" target="_blank">michael.d.kinney@intel.com</a>><br> <b><span lang="ZH-CN">抄送</span>:</b> <a href="mailto:devel@edk2.groups.io" target="_blank"> devel@edk2.groups.io</a><br> <b><span lang="ZH-CN">主题</span>:</b> Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation</span><span style="mso-fareast-language:ZH-CN"><o:p></o:p></span></p> </div> </div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN"> <o:p></o:p></span></p> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN">Yes, we can. I will drop this patch for this uefipayload batch and send another one for support DISABLE_GCC_MMX_SSE in tools_de.txt.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN"> <o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN">--<o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;margin-bottom:12.0pt"><span style="mso-fareast-language:ZH-CN">Cheng-Chieh <o:p></o:p></span></p> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN">On Thu, Jul 22, 2021, 12:35 AM Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" target="_blank">michael.d.kinney@intel.com</a>> wrote:<o:p></o:p></span></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt"> <p class="MsoNormal" style="mso-margin-top-alt:auto;margin-bottom:12.0pt"><span style="mso-fareast-language:ZH-CN">Are those flags needed for all packages that build with GCC?<br> <br> Should this be moved into tools_def.txt?<br> <br> Mike<br> <br> > -----Original Message-----<br> > From: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>> On Behalf Of Cheng-Chieh Huang via <a href="http://groups.io" target="_blank">groups.io</a><br> > Sent: Wednesday, July 21, 2021 6:23 AM<br> > To: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a><br> > Cc: Cheng-Chieh Huang <<a href="mailto:chengchieh@google.com" target="_blank">chengchieh@google.com</a>><br> > Subject: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation<br> > <br> > This will allow we compile payload using gcc8<br> > <br> > Signed-off-by: Cheng-Chieh Huang <<a href="mailto:chengchieh@google.com" target="_blank">chengchieh@google.com</a>><br> > ---<br> > UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +++++<br> > 1 file changed, 5 insertions(+)<br> > <br> > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc<br> > index 8aa5f18cd35c..fa41c5a24af5 100644<br> > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc<br> > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc<br> > @@ -30,6 +30,8 @@ [Defines]<br> > DEFINE PS2_KEYBOARD_ENABLE = FALSE<br> > DEFINE UNIVERSAL_PAYLOAD = FALSE<br> > <br> > + DEFINE DISABLE_MMX_SSE = FALSE<br> > +<br> > #<br> > # SBL: UEFI payload for Slim Bootloader<br> > # COREBOOT: UEFI payload for coreboot<br> > @@ -96,6 +98,9 @@ [BuildOptions]<br> > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES<br> > !if $(BOOTLOADER) == "LINUXBOOT"<br> > *_*_*_CC_FLAGS = -D LINUXBOOT_PAYLOAD<br> > +!endif<br> > +!if $(DISABLE_MMX_SSE)<br> > + *_*_*_CC_FLAGS = -mno-mmx -mno-sse<br> > !endif<br> > GCC:*_UNIXGCC_*_CC_FLAGS = -DMDEPKG_NDEBUG<br> > GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG<br> > --<br> > 2.32.0.402.g57bb445576-goog<br> > <br> > <br> > <br> > <br> > <o:p></o:p></span></p> </blockquote> </div> </div> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-fareast-language:ZH-CN"><o:p></o:p></span></p> </div> </div> </div> </div> </blockquote> </div> </div> </div> </div> </blockquote> </div> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/78140">View/Reply Online (#78140)</a> | | <a target="_blank" href="https://groups.io/mt/84401664/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>