<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style></style></head><body lang=ZH-CN link=blue vlink=purple style='word-wrap:break-word'><div class=WordSection1><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:等线'>How do you add this support in tools_def? Can you give the proposal for it?<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:等线'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:等线'>Thanks<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:等线'>Liming<o:p></o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span style='font-size:11.0pt;font-family:等线'>发件人<span lang=EN-US>:</span></span></b><span lang=EN-US style='font-size:11.0pt;font-family:等线'> Cheng-Chieh Huang <chengchieh@google.com> <br></span><b><span style='font-size:11.0pt;font-family:等线'>发送时间<span lang=EN-US>:</span></span></b><span lang=EN-US style='font-size:11.0pt;font-family:等线'> 2021</span><span style='font-size:11.0pt;font-family:等线'>年<span lang=EN-US>7</span>月<span lang=EN-US>22</span>日<span lang=EN-US> 10:35<br></span><b>收件人<span lang=EN-US>:</span></b><span lang=EN-US> gaoliming <gaoliming@byosoft.com.cn><br></span><b>抄送<span lang=EN-US>:</span></b><span lang=EN-US> devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com><br></span><b>主题<span lang=EN-US>:</span></b><span lang=EN-US> Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation<o:p></o:p></span></span></p></div></div><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><div><p class=MsoNormal><span lang=EN-US>I mean, I will submit a patch to support DISABLE_GCC_MMX_SSE in tools_def. What do you think?<o:p></o:p></span></p><div><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p></div><div><p class=MsoNormal><span lang=EN-US>--<o:p></o:p></span></p></div><div><p class=MsoNormal><span lang=EN-US>Cheng-Chieh<o:p></o:p></span></p></div></div><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><div><div><p class=MsoNormal><span lang=EN-US>On Thu, Jul 22, 2021 at 9:28 AM gaoliming <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>> wrote:<o:p></o:p></span></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><div><div><p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><span lang=EN-US style='font-size:10.5pt;font-family:等线'>Tools_def.txt doesn</span><span style='font-size:10.5pt;font-family:等线'>’<span lang=EN-US>t support build flag </span></span><span lang=EN-US>DISABLE_GCC_MMX_SSE. If this flag is moved into BaseTools\Conf\tools_def.template, -mno-mmx -mno-sse option will be the default GCC options. That means all platforms will apply them. <o:p></o:p></span></p><p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><span lang=EN-US> <o:p></o:p></span></p><p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><span lang=EN-US>Thanks<o:p></o:p></span></p><p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><span lang=EN-US>Liming<o:p></o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><b><span style='font-size:11.0pt;font-family:等线'>发件人<span lang=EN-US>:</span></span></b><span lang=EN-US style='font-size:11.0pt;font-family:等线'> <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>> </span><b><span style='font-size:11.0pt;font-family:等线'>代表 </span></b><span lang=EN-US style='font-size:11.0pt;font-family:等线'>Cheng-Chieh Huang via <a href="http://groups.io" target="_blank">groups.io</a><br></span><b><span style='font-size:11.0pt;font-family:等线'>发送时间<span lang=EN-US>:</span></span></b><span lang=EN-US style='font-size:11.0pt;font-family:等线'> 2021</span><span style='font-size:11.0pt;font-family:等线'>年<span lang=EN-US>7</span>月<span lang=EN-US>22</span>日<span lang=EN-US> 1:43<br></span><b>收件人<span lang=EN-US>:</span></b><span lang=EN-US> Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" target="_blank">michael.d.kinney@intel.com</a>><br></span><b>抄送<span lang=EN-US>:</span></b><span lang=EN-US> <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a><br></span><b>主题<span lang=EN-US>:</span></b><span lang=EN-US> Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation</span></span><span lang=EN-US><o:p></o:p></span></p></div></div><p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><span lang=EN-US> <o:p></o:p></span></p><div><div><p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><span lang=EN-US>Yes, we can. I will drop this patch for this uefipayload batch and send another one for support DISABLE_GCC_MMX_SSE in tools_de.txt.<o:p></o:p></span></p></div><div><p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><span lang=EN-US> <o:p></o:p></span></p></div><div><p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><span lang=EN-US>--<o:p></o:p></span></p></div><div><p class=MsoNormal style='mso-margin-top-alt:auto;margin-bottom:12.0pt'><span lang=EN-US>Cheng-Chieh <o:p></o:p></span></p><div><div><p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><span lang=EN-US>On Thu, Jul 22, 2021, 12:35 AM Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com" target="_blank">michael.d.kinney@intel.com</a>> wrote:<o:p></o:p></span></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt'><p class=MsoNormal style='mso-margin-top-alt:auto;margin-bottom:12.0pt'><span lang=EN-US>Are those flags needed for all packages that build with GCC?<br><br>Should this be moved into tools_def.txt?<br><br>Mike<br><br>> -----Original Message-----<br>> From: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>> On Behalf Of Cheng-Chieh Huang via <a href="http://groups.io" target="_blank">groups.io</a><br>> Sent: Wednesday, July 21, 2021 6:23 AM<br>> To: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a><br>> Cc: Cheng-Chieh Huang <<a href="mailto:chengchieh@google.com" target="_blank">chengchieh@google.com</a>><br>> Subject: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation<br>> <br>> This will allow we compile payload using gcc8<br>> <br>> Signed-off-by: Cheng-Chieh Huang <<a href="mailto:chengchieh@google.com" target="_blank">chengchieh@google.com</a>><br>> ---<br>> UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +++++<br>> 1 file changed, 5 insertions(+)<br>> <br>> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc<br>> index 8aa5f18cd35c..fa41c5a24af5 100644<br>> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc<br>> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc<br>> @@ -30,6 +30,8 @@ [Defines]<br>> DEFINE PS2_KEYBOARD_ENABLE = FALSE<br>> DEFINE UNIVERSAL_PAYLOAD = FALSE<br>> <br>> + DEFINE DISABLE_MMX_SSE = FALSE<br>> +<br>> #<br>> # SBL: UEFI payload for Slim Bootloader<br>> # COREBOOT: UEFI payload for coreboot<br>> @@ -96,6 +98,9 @@ [BuildOptions]<br>> *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES<br>> !if $(BOOTLOADER) == "LINUXBOOT"<br>> *_*_*_CC_FLAGS = -D LINUXBOOT_PAYLOAD<br>> +!endif<br>> +!if $(DISABLE_MMX_SSE)<br>> + *_*_*_CC_FLAGS = -mno-mmx -mno-sse<br>> !endif<br>> GCC:*_UNIXGCC_*_CC_FLAGS = -DMDEPKG_NDEBUG<br>> GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG<br>> --<br>> 2.32.0.402.g57bb445576-goog<br>> <br>> <br>> <br>> <br>> <o:p></o:p></span></p></blockquote></div></div></div><div><p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><span lang=EN-US><o:p></o:p></span></p></div></div></div></div></blockquote></div></div></div></body></html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/78129">View/Reply Online (#78129)</a> | | <a target="_blank" href="https://groups.io/mt/84398177/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>