<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Segoe UI";
panose-1:2 11 5 2 4 2 4 2 2 3;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:-apple-system;
panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
h2
{mso-style-priority:9;
mso-style-link:"Heading 2 Char";
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:18.0pt;
font-family:"Calibri",sans-serif;
font-weight:bold;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
code
{mso-style-priority:99;
font-family:"Courier New";}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
font-size:10.0pt;
font-family:"Courier New";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
span.EmailStyle24
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.Heading2Char
{mso-style-name:"Heading 2 Char";
mso-style-priority:9;
mso-style-link:"Heading 2";
font-family:"Calibri",sans-serif;
font-weight:bold;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:540556733;
mso-list-template-ids:2007634940;}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:1.0in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:"Courier New";
mso-bidi-font-family:"Times New Roman";}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:1.5in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">+ NetworkPkg Maitainer/Reviewer<o:p></o:p></p>
<p class="MsoNormal">Hi Zachary,<o:p></o:p></p>
<p class="MsoNormal">I notice you pushed the patch to <a href="https://github.com/tianocore/edk2/pull/1834">
https://github.com/tianocore/edk2/pull/1834</a><o:p></o:p></p>
<p class="MsoNormal">But according to “The developer process for the EDK II project" In <a href="https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process">https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process</a><o:p></o:p></p>
<p class="MsoNormal">Normally we send the patch by mail, I recommend you send the patch by mail too(use
<code><b><span style="font-size:10.0pt;font-family:Consolas;color:#24292E">git send-email *.patch)</span></b></code>:<o:p></o:p></p>
<h2 style="mso-margin-top-alt:.25in;margin-right:0in;margin-bottom:12.0pt;margin-left:0in;background:white">
<span style="font-size:16.5pt;font-family:-apple-system;color:#24292E">The developer process for the EDK II project<o:p></o:p></span></h2>
<ol style="margin-top:0in;box-sizing: border-box;font-variant-ligatures: normal;font-variant-caps: normal;orphans: 2;text-align:start;widows: 2;-webkit-text-stroke-width: 0px;text-decoration-thickness: initial;text-decoration-style: initial;text-decoration-color: initial;word-spacing:0px" start="1" type="1">
<li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level1 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Setup the EDK II tree if you do not have one<o:p></o:p></span></li><ul type="circle">
<li class="MsoNormal" style="color:#24292E;mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">This is document on the <a href="https://github.com/tianocore/tianocore.github.io/wiki/SourceForge-to-Github-Quick-Start">SourceForge to Github Quick Start</a> page<o:p></o:p></span></li></ul>
<li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level1 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Create and checkout a topic branch for new feature or bug fix<o:p></o:p></span></li></ol>
<p style="mso-margin-top-alt:0in;margin-right:0in;margin-bottom:0in;margin-left:.5in;background:white;box-sizing: border-box">
<code><span style="font-size:10.0pt;font-family:Consolas;color:#24292E">$ git checkout -b <new-dev-branch> origin/master</span></code><span style="font-size:12.0pt;font-family:-apple-system;color:#24292E"><o:p></o:p></span></p>
<ol style="margin-top:0in" start="3" type="1">
<li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level1 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Make changes in the working tree<o:p></o:p></span></li><li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level1 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Break up working tree changes into independent commits that do not break <em><span style="font-family:-apple-system">git bisect</span></em><o:p></o:p></span></li><ul style="margin-top:0in;box-sizing: border-box" type="circle">
<li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system"><a href="https://github.com/tianocore/tianocore.github.io/wiki/Commit-Partitioning" title="wikilink">Commit-Partitioning</a><o:p></o:p></span></li><li style="color:#24292E;margin-top:0in;margin-bottom:0in;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">To stage all modifications: </span><code><span style="font-size:10.0pt;font-family:Consolas">$ git add -u</span></code><span style="font-size:12.0pt;font-family:-apple-system"><o:p></o:p></span></li><li style="color:#24292E;margin-top:0in;margin-bottom:0in;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">To add new files: </span><code><span style="font-size:10.0pt;font-family:Consolas">$ git add <path-to-new-file></span></code><span style="font-size:12.0pt;font-family:-apple-system"><o:p></o:p></span></li><li style="color:#24292E;margin-top:0in;margin-bottom:0in;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">To have git prompt you to selectively stage changes: </span><code><span style="font-size:10.0pt;font-family:Consolas">$ git add -p</span></code><span style="font-size:12.0pt;font-family:-apple-system"><o:p></o:p></span></li></ul>
<li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level1 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Follow the commit message template given below when writing commit messages<o:p></o:p></span></li><ul style="margin-top:0in;box-sizing: border-box" type="circle">
<li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system"><a href="https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format" title="wikilink">Commit-Message-Format</a><o:p></o:p></span></li><li style="color:#24292E;margin-top:0in;margin-bottom:0in;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">To commit staged changes: </span><code><span style="font-size:10.0pt;font-family:Consolas">$ git commit</span></code><span style="font-size:12.0pt;font-family:-apple-system"><o:p></o:p></span></li><ul type="square">
<li class="MsoNormal" style="color:#24292E;mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level3 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Add the </span><code><span style="font-size:10.0pt;font-family:Consolas">-s</span></code><span style="font-size:12.0pt;font-family:-apple-system"> parameter to automatically append your Signed-off-by
tag to the commit message.<o:p></o:p></span></li></ul>
</ul>
<li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level1 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Use the ‘PatchCheck.py’ script under ‘edk2\BaseTools\Scripts’ directory to verify the commits are correctly formatted<o:p></o:p></span></li><ul style="margin-top:0in;box-sizing: border-box" type="circle">
<li style="color:#24292E;margin-top:0in;margin-bottom:0in;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">To check the latest changes: </span><code><span style="font-size:10.0pt;font-family:Consolas">$ python BaseTools/Scripts/PatchCheck.py -<N></span></code><span style="font-size:12.0pt;font-family:-apple-system"><o:p></o:p></span></li><ul type="square">
<li class="MsoNormal" style="color:#24292E;mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;mso-list:l0 level3 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">For example, 2 changes would be: </span><code><span style="font-size:10.0pt;font-family:Consolas">$ python BaseTools/Scripts/PatchCheck.py -2</span></code><span style="font-size:12.0pt;font-family:-apple-system"><o:p></o:p></span></li></ul>
<li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">It is strongly recommended that you run PatchCheck.py after each commit. You can then easily amend the commit to correct any issues.<o:p></o:p></span></li></ul>
<li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level1 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Get the latest changes from origin<o:p></o:p></span></li></ol>
<p style="mso-margin-top-alt:0in;margin-right:0in;margin-bottom:0in;margin-left:.5in;background:white;box-sizing: border-box">
<code><span style="font-size:10.0pt;font-family:Consolas;color:#24292E">$ git fetch origin</span></code><span style="font-size:12.0pt;font-family:-apple-system;color:#24292E"><o:p></o:p></span></p>
<p style="mso-margin-top-alt:12.0pt;margin-right:0in;margin-bottom:12.0pt;margin-left:.5in;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system;color:#24292E">Note: This updates origin/master, but not your local master branch. (origin/master may have newer commits than master.)<o:p></o:p></span></p>
<ol style="margin-top:0in" start="8" type="1">
<li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level1 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Rebase the topic branch onto master branch<o:p></o:p></span></li></ol>
<p style="mso-margin-top-alt:0in;margin-right:0in;margin-bottom:0in;margin-left:.5in;background:white;box-sizing: border-box">
<code><span style="font-size:10.0pt;font-family:Consolas;color:#24292E">$ git rebase origin/master</span></code><span style="font-size:12.0pt;font-family:-apple-system;color:#24292E"><o:p></o:p></span></p>
<ol style="margin-top:0in" start="9" type="1">
<li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level1 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Create patch (serial) to the <a href="https://github.com/tianocore/tianocore.github.io/wiki/edk2-devel">edk2-devel</a> mailing list<o:p></o:p></span></li><ul style="margin-top:0in;box-sizing: border-box" type="circle">
<li style="color:#24292E;margin-top:0in;margin-bottom:0in;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Clean out any old patches: </span><code><span style="font-size:10.0pt;font-family:Consolas">$ rm *.patch</span></code><span style="font-size:12.0pt;font-family:-apple-system"><o:p></o:p></span></li><li style="color:#24292E;margin-top:0in;margin-bottom:0in;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Generate new patch files: </span><code><span style="font-size:10.0pt;font-family:Consolas">$ git format-patch -M --thread origin/master</span></code><span style="font-size:12.0pt;font-family:-apple-system"><o:p></o:p></span></li><ul style="margin-top:0in;box-sizing: border-box" type="square">
<li style="color:#24292E;margin-top:0in;margin-bottom:0in;mso-list:l0 level3 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Add the </span><code><span style="font-size:10.0pt;font-family:Consolas">--cover-letter</span></code><span style="font-size:12.0pt;font-family:-apple-system"> parameter for long patch series. (Be sure
to edit the cover-letter.)<o:p></o:p></span></li><li style="color:#24292E;margin-top:0in;margin-bottom:0in;mso-list:l0 level3 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Add the </span><code><span style="font-size:10.0pt;font-family:Consolas">--subject-prefix="PATCH v2"</span></code><span style="font-size:12.0pt;font-family:-apple-system"> if you are sending out a second
version of the patch series.<o:p></o:p></span></li></ul>
<li style="color:#24292E;margin-top:0in;margin-bottom:0in;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<code><b><span style="font-size:10.0pt;font-family:Consolas">$ git send-email *.patch</span></b></code><b><span style="font-size:12.0pt;font-family:-apple-system"><o:p></o:p></span></b></li></ul>
<li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level1 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Modify local commits based on the review feedbacks and repeat steps 3 to 9<o:p></o:p></span></li><ul style="margin-top:0in;box-sizing: border-box" type="circle">
<li style="color:#24292E;margin-top:0in;margin-bottom:0in;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">For the latest commit, you can use </span><code><span style="font-size:10.0pt;font-family:Consolas">$ git commit --amend</span></code><span style="font-size:12.0pt;font-family:-apple-system"><o:p></o:p></span></li><li style="color:#24292E;margin-top:0in;margin-bottom:0in;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">For multiple commits use </span><code><span style="font-size:10.0pt;font-family:Consolas">$ git rebase -i origin/master</span></code><span style="font-size:12.0pt;font-family:-apple-system"><o:p></o:p></span></li><li style="color:#24292E;margin-top:12.0pt;margin-bottom:12.0pt;mso-list:l0 level2 lfo1;background:white;box-sizing: border-box">
<span style="font-size:12.0pt;font-family:-apple-system">Consult your git gurus on edk2-devel or irc channel if you have questions.<o:p></o:p></span></li></ul>
</ol>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Heng<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Clark-williams, Zachary <zachary.clark-williams@intel.com>
<br>
<b>Sent:</b> Friday, July 23, 2021 11:15 AM<br>
<b>To:</b> devel@edk2.groups.io<br>
<b>Cc:</b> Goetz, Philippe C <philippe.c.goetz@intel.com>; Nagar, Rupa <rupa.nagar@intel.com>; Luo, Heng <heng.luo@intel.com>; Zhuang, Qihua <qihua.zhuang@intel.com>; Lu, James <james.lu@intel.com><br>
<b>Subject:</b> Adding HTTP boot IO timeout programmability from PcdHttpIoTimeout<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hello,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review the attached filed EDK2 tracker for feature enablement of programmable timeout of the HTTP boot IO timer.<o:p></o:p></p>
<p style="margin-bottom:12.0pt;background:white"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#24292E">NetworkPkg-HttpBoot: Making the HTTP IO timeout value programmable with PCD.<br>
REF: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=3507">https://bugzilla.tianocore.org/show_bug.cgi?id=3507</a><o:p></o:p></span></p>
<p style="mso-margin-top-alt:0in;margin-right:0in;margin-bottom:12.0pt;margin-left:0in;background:white;box-sizing: border-box;font-variant-ligatures: normal;font-variant-caps: normal;orphans: 2;text-align:start;widows: 2;-webkit-text-stroke-width: 0px;text-decoration-thickness: initial;text-decoration-style: initial;text-decoration-color: initial;word-spacing:0px">
<span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#24292E">HTTP boot has a default set forced timeout value of 5 seconds for getting the recovery image from a remote source. This change allows the HTTP boot flow to get the IO timeout value
from the PcdHttpIoTimeout. PcdHttpIoTimeout value is set in the OneClickRecovery driver from the value provided by CSME.<o:p></o:p></span></p>
<pre style="background:white;box-sizing: border-box;overflow-wrap: normal;background-color:var(--color-bg-tertiary);border-radius: 6px;overflow:auto"><code><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;border:none windowtext 1.0pt;padding:0in">PcdHttpIoTimeout minimum value 0.5 seconds</span></code><code><span style="font-size:9.0pt;font-family:Consolas;border:none windowtext 1.0pt;padding:0in"><o:p></o:p></span></code></pre>
<pre style="background:white"><code><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;border:none windowtext 1.0pt;padding:0in">PcdHttpIoTimeout maximum value 120 seconds<o:p></o:p></span></code></pre>
<pre style="background:white"><code><span style="font-size:9.0pt;font-family:Consolas;color:#24292E;border:none windowtext 1.0pt;padding:0in">PcdHttpIoTimeout default value 5 seconds</span></code><o:p></o:p></pre>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thank you,<o:p></o:p></p>
<p class="MsoNormal">Zack<o:p></o:p></p>
</div>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/78162">View/Reply Online (#78162)</a> | | <a target="_blank" href="https://groups.io/mt/84394505/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>