<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=windows-1252"> </head> <body> <div class="moz-cite-prefix">On 7/27/21 12:25 PM, Yao, Jiewen wrote: </div> <blockquote type="cite" cite="mid:PH0PR11MB4885567FA2317371B6637C138CE99@PH0PR11MB4885.namprd11.prod.outlook.com"> <meta http-equiv="Content-Type" content="text/html; charset=windows-1252"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)">  <style>@font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face {font-family:DengXian; panose-1:2 1 6 0 3 1 1 1 1 1;}@font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;}@font-face {font-family:"\@DengXian"; panose-1:2 1 6 0 3 1 1 1 1 1;}p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0in; font-size:11.0pt; font-family:"Calibri",sans-serif;}a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;}span.EmailStyle20 {mso-style-type:personal-reply; font-family:"Calibri",sans-serif; color:windowtext;}.MsoChpDefault {mso-style-type:export-only; font-size:10.0pt;}div.WordSection1 {page:WordSection1;}</style> <div class="WordSection1"> Oops. Sorry for late response.<o:p></o:p> <o:p> </o:p> The code is NOT in EDKII, but EDKII-platform as example. <a href="https://github.com/tianocore/edk2-platforms/tree/master/Platform/Intel/MinPlatformPkg/Tcg" moz-do-not-send="true"> https://github.com/tianocore/edk2-platforms/tree/master/Platform/Intel/MinPlatformPkg/Tcg</a><o:p></o:p> <o:p> </o:p> We allow a platform having its own implementation. That is why it is NOT in EDKII. </div> </blockquote> How do edk2 and edk2-platform relate? Do we need to copy code form one to the other ? Stefan <blockquote type="cite" cite="mid:PH0PR11MB4885567FA2317371B6637C138CE99@PH0PR11MB4885.namprd11.prod.outlook.com"> <div class="WordSection1"> <o:p></o:p> <o:p> </o:p> Thank you<o:p></o:p> Yao Jiewen<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: <a class="moz-txt-link-abbreviated" href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <a class="moz-txt-link-rfc2396E" href="mailto:devel@edk2.groups.io"><devel@edk2.groups.io></a> On Behalf Of Bret Barkelew via groups.io Sent: Wednesday, July 28, 2021 12:11 AM To: <a class="moz-txt-link-abbreviated" href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; <a class="moz-txt-link-abbreviated" href="mailto:stefanb@linux.ibm.com">stefanb@linux.ibm.com</a>; Yao, Jiewen <a class="moz-txt-link-rfc2396E" href="mailto:jiewen.yao@intel.com"><jiewen.yao@intel.com></a>; Jeremiah Cox <a class="moz-txt-link-rfc2396E" href="mailto:jerecox@microsoft.com"><jerecox@microsoft.com></a>; Michael Kubacki <a class="moz-txt-link-rfc2396E" href="mailto:Michael.Kubacki@microsoft.com"><Michael.Kubacki@microsoft.com></a> Cc: Marc-André Lureau <a class="moz-txt-link-rfc2396E" href="mailto:marcandre.lureau@redhat.com"><marcandre.lureau@redhat.com></a> Subject: Re: [EXTERNAL] [edk2-devel] Missing TPM 2 related call to Tpm2HierarchyChangeAuth<o:p></o:p> </div> </div> <o:p> </o:p> Adding <a id="OWAAM57DF552AAA444C9D81C6D190197AAE31" href="mailto:jerecox@microsoft.com" moz-do-not-send="true"> @Jeremiah</a>…<o:p></o:p> <o:p> </o:p> Jeremiah, weren’t you or <a id="OWAAMF48ECF70C0FF4290BC7C5F323E5081B0" href="mailto:Michael.Kubacki@microsoft.com" moz-do-not-send="true"> @Michael</a> shopping this change to MinPlatform?<o:p></o:p> <o:p> </o:p> - Bret <o:p></o:p> <o:p> </o:p> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: <a href="mailto:stefanb=linux.ibm.com@groups.io" moz-do-not-send="true">Stefan Berger via groups.io</a> Sent: Monday, July 26, 2021 7:48 AM To: <a href="mailto:jiewen.yao@intel.com" moz-do-not-send="true">Yao, Jiewen</a>; <a href="mailto:devel@edk2.groups.io" moz-do-not-send="true"> devel@edk2.groups.io</a> Cc: <a href="mailto:marcandre.lureau@redhat.com" moz-do-not-send="true">Marc-André Lureau</a> Subject: [EXTERNAL] [edk2-devel] Missing TPM 2 related call to Tpm2HierarchyChangeAuth<o:p></o:p> </div> <o:p> </o:p> Hello! The TPM 2 code in EDK2 is missing an important call to Tpm2HierarchyChangeAuth for the platform hierarchy. We have to set the password of that hierarchy and discard the password. See also specs section 11: <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftrustedcomputinggroup.org%2Fwp-content%2Fuploads%2FTCG_PCClient_PFP_r1p05_v22_02dec2020.pdf&data=04%7C01%7Cbret.barkelew%40microsoft.com%7Cf2a2262eee2c44b3760c08d95044601a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637629077356686202%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=N7VQIw87rHqUAFQ54TvhNwcsPFEwJzdZQ9JZrmX1S4E%3D&reserved=0" moz-do-not-send="true">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftrustedcomputinggroup.org%2Fwp-content%2Fuploads%2FTCG_PCClient_PFP_r1p05_v22_02dec2020.pdf&data=04%7C01%7Cbret.barkelew%40microsoft.com%7Cf2a2262eee2c44b3760c08d95044601a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637629077356686202%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=N7VQIw87rHqUAFQ54TvhNwcsPFEwJzdZQ9JZrmX1S4E%3D&reserved=0</a> "Platform Firmware MUST protect access to the Platform Hierarchy and prevent access to the platform hierarchy by non-manufacturer-controlled components. " I was wondering where we could put that call so it's invoked after the user has possibly interacted with the menu and before passing control to the next stage such as boot loader. Regards, Stefan <o:p></o:p> <o:p> </o:p> <div> </o:p> </div> </div> </blockquote> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/78257">View/Reply Online (#78257)</a> | | <a target="_blank" href="https://groups.io/mt/84485285/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>