<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Hi Cheng-chieh,<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">The Github comments is just for your reference to quick locate the comment place. You could update the PR with new changes and I could comment there.<o:p></o:p></p> <p class="MsoNormal">But we still need follow EDII requirement to review the patches by email.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Thanks,<o:p></o:p></p> <p class="MsoNormal">Guo<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Cheng-Chieh Huang <chengchieh@google.com> <br> <b>Sent:</b> Saturday, August 7, 2021 8:06 AM<br> <b>To:</b> devel@edk2.groups.io<br> <b>Cc:</b> Schaefer, Daniel <daniel.schaefer@hpe.com>; Trammell Hudson <hudson@trmm.net>; Ma, Maurice <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com><br> <b>Subject:</b> Re: [PATCH v2 0/4] UefiPayloadPkg: LinuxBoot Support in UefiPayload<o:p></o:p></p> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal">Hi Guo,<o:p></o:p></p> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">I saw you left messages in <a href="https://github.com/tianocore/edk2/pull/1820">https://github.com/tianocore/edk2/pull/1820</a>. If it's also possible to upstreaming using github PR. I can just update my old branch.<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">--<o:p></o:p></p> </div> <div> <p class="MsoNormal">Cheng-chieh<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">On Sat, Aug 7, 2021 at 10:51 PM Cheng-Chieh Huang <<a href="mailto:chengchieh@google.com">chengchieh@google.com</a>> wrote:<o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> <p class="MsoNormal" style="margin-bottom:12.0pt">These are necessary patches to Support LinuxBoot in UefiPayload.<br> With these paches, we can boot to ESXi and Windows from a linux in QEMU.<br> <br> This is second parse. In addition to fixing reviwer's suggestions,<br> I removed the following CLs.<br> * Add DISABLE_MMX_SSE to avoid generating floating points operation<br> -> will send a seperate patch to add these flags to BaseTools<br> <br> * LinuxBoot: use a text format for the configuration block.<br> -> will work with Trammell Hudson to cover this patch to EDK2 style.<br> <br> LinuxBoot README:<br> <a href="https://github.com/linuxboot/edk2/blob/uefipayload/UefiPayloadPkg/README.md" target="_blank">https://github.com/linuxboot/edk2/blob/uefipayload/UefiPayloadPkg/README.md</a><br> <br> v2 PR to tianocore:<br> <a href="https://github.com/tianocore/edk2/pull/1873" target="_blank">https://github.com/tianocore/edk2/pull/1873</a><br> <br> Cheng-Chieh Huang (4):<br> UefiPayloadPkg: Add LINUXBOOT payload target<br> UefiPayloadPkg: Use legacy timer in Linuxboot payload<br> UefiPayloadPkg: Update maximum logic processor to 256<br> UefiPayloadPkg: Reserve Payload config in runtime services data<br> <br> UefiPayloadPkg/UefiPayloadPkg.dsc | 24 ++-<br> UefiPayloadPkg/UefiPayloadPkg.fdf | 5 +<br> UefiPayloadPkg/Library/LbParseLib/LbParseLib.inf | 39 +++++<br> UefiPayloadPkg/Library/LbParseLib/Linuxboot.h | 47 +++++<br> UefiPayloadPkg/Library/LbParseLib/LbParseLib.c | 182 ++++++++++++++++++++<br> UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 6 +-<br> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 4 +<br> 7 files changed, 299 insertions(+), 8 deletions(-)<br> create mode 100644 UefiPayloadPkg/Library/LbParseLib/LbParseLib.inf<br> create mode 100644 UefiPayloadPkg/Library/LbParseLib/Linuxboot.h<br> create mode 100644 UefiPayloadPkg/Library/LbParseLib/LbParseLib.c<br> <br> Cc: Cheng-Chieh Huang <<a href="mailto:chengchieh@google.com" target="_blank">chengchieh@google.com</a>><br> Cc: Daniel Schaefer <<a href="mailto:daniel.schaefer@hpe.com" target="_blank">daniel.schaefer@hpe.com</a>><br> Cc: Trammell Hudson <<a href="mailto:hudson@trmm.net" target="_blank">hudson@trmm.net</a>><br> Cc: Maurice Ma <<a href="mailto:maurice.ma@intel.com" target="_blank">maurice.ma@intel.com</a>><br> Cc: Guo Dong <<a href="mailto:guo.dong@intel.com" target="_blank">guo.dong@intel.com</a>><br> Cc: Benjamin You <<a href="mailto:benjamin.you@intel.com" target="_blank">benjamin.you@intel.com</a>><br> <br> <br> -- <br> 2.32.0.605.g8dce9f2422-goog<o:p></o:p></p> </blockquote> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/78853">View/Reply Online (#78853)</a> | | <a target="_blank" href="https://groups.io/mt/84731094/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>