<div dir="ltr">Hi All,<div><br></div><div>This patch broke the coreboot payload loading. Tested with:</div><div>build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT<br></div><div><br>Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image:</div><div>"Not a usable UEFI firmware volume"<br></div><div><br></div><div>Trying to boot coreboot results in an exception and the following error message:</div><div>"Payload not loaded"<br></div><div><br>Probably it broke the interface.</div><div><br></div><div>commit 4bac086e8e007c7143e33f87bb96238326d1d6ba<br>Author: Zhiguang Liu <<a href="mailto:zhiguang.liu@intel.com">zhiguang.liu@intel.com</a>><br>Date:   Wed Jul 14 14:24:45 2021 +0800<br><br>    UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV<br><br>    Signed-off-by: Zhiguang Liu <<a href="mailto:zhiguang.liu@intel.com">zhiguang.liu@intel.com</a>><br>    Reviewed-by: Ray Ni <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>><br>    Reviewed-by: Guo Dong <<a href="mailto:guo.dong@intel.com">guo.dong@intel.com</a>><br></div><div><br></div><div><br></div><div>Kind regards,</div><div>Sumo</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <<a href="mailto:guo.dong@intel.com">guo.dong@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Signed-off-by: Guo Dong <<a href="mailto:guo.dong@intel.com" target="_blank">guo.dong@intel.com</a>><br>
<br>
> -----Original Message-----<br>
> From: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>> On Behalf Of<br>
> Zhiguang Liu<br>
> Sent: Tuesday, July 13, 2021 11:25 PM<br>
> To: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a><br>
> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and<br>
> PLDFV<br>
> <br>
> Signed-off-by: Zhiguang Liu <<a href="mailto:zhiguang.liu@intel.com" target="_blank">zhiguang.liu@intel.com</a>><br>
> ---<br>
>  UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++<br>
>  1 file changed, 2 insertions(+)<br>
> <br>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf<br>
> b/UefiPayloadPkg/UefiPayloadPkg.fdf<br>
> index 2d51fdbacb..041fed842c 100644<br>
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf<br>
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf<br>
> @@ -34,6 +34,7 @@ FV = PLDFV<br>
> <br>
> <br>
> <br>
> ##########################################################<br>
> ######################<br>
> <br>
>  [FV.PLDFV]<br>
> <br>
> +FvNameGuid         = 96E75986-6FDD-491E-9FD5-35E21AC45B45<br>
> <br>
>  BlockSize          = $(FD_BLOCK_SIZE)<br>
> <br>
>  FvAlignment        = 16<br>
> <br>
>  ERASE_POLARITY     = 1<br>
> <br>
> @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-<br>
> E77F1DB2D793 {<br>
> <br>
> ##########################################################<br>
> ######################<br>
> <br>
> <br>
> <br>
>  [FV.DXEFV]<br>
> <br>
> +FvNameGuid         = 8063C21A-8E58-4576-95CE-089E87975D23<br>
> <br>
>  BlockSize          = $(FD_BLOCK_SIZE)<br>
> <br>
>  FvForceRebase      = FALSE<br>
> <br>
>  FvAlignment        = 16<br>
> <br>
> --<br>
> 2.30.0.windows.2<br>
> <br>
> <br>
> <br>
> -=-=-=-=-=-=<br>
> Groups.io Links: You receive all messages sent to this group.<br>
> View/Reply Online (#77762): <a href="https://edk2.groups.io/g/devel/message/77762" rel="noreferrer" target="_blank">https://edk2.groups.io/g/devel/message/77762</a><br>
> Mute This Topic: <a href="https://groups.io/mt/84196221/1781375" rel="noreferrer" target="_blank">https://groups.io/mt/84196221/1781375</a><br>
> Group Owner: <a href="mailto:devel%2Bowner@edk2.groups.io" target="_blank">devel+owner@edk2.groups.io</a><br>
> Unsubscribe: <a href="https://edk2.groups.io/g/devel/unsub" rel="noreferrer" target="_blank">https://edk2.groups.io/g/devel/unsub</a> [<a href="mailto:guo.dong@intel.com" target="_blank">guo.dong@intel.com</a>]<br>
> -=-=-=-=-=-=<br>
> <br>
<br>
<br>
<br>
<br>
<br>
<br>
</blockquote></div>


 <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr>   Groups.io Links:<p>   You receive all messages sent to this group.    <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/79729">View/Reply Online (#79729)</a> |    |  <a target="_blank" href="https://groups.io/mt/84196221/1813853">Mute This Topic</a>  | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>    <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |  <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>  [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>