<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">It seems like the coreboot cannot support FV that contains GUID in its header.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> devel@edk2.groups.io <devel@edk2.groups.io> <b>
On Behalf Of </b>King Sumo<br>
<b>Sent:</b> Tuesday, August 24, 2021 1:02 AM<br>
<b>To:</b> devel@edk2.groups.io; Dong, Guo <guo.dong@intel.com><br>
<b>Cc:</b> Liu, Zhiguang <zhiguang.liu@intel.com><br>
<b>Subject:</b> Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Hi All,<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">This patch broke the coreboot payload loading. Tested with:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><br>
Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">"Not a usable UEFI firmware volume"<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Trying to boot coreboot results in an exception and the following error message:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">"Payload not loaded"<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><br>
Probably it broke the interface.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">commit 4bac086e8e007c7143e33f87bb96238326d1d6ba<br>
Author: Zhiguang Liu <<a href="mailto:zhiguang.liu@intel.com">zhiguang.liu@intel.com</a>><br>
Date: Wed Jul 14 14:24:45 2021 +0800<br>
<br>
UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV<br>
<br>
Signed-off-by: Zhiguang Liu <<a href="mailto:zhiguang.liu@intel.com">zhiguang.liu@intel.com</a>><br>
Reviewed-by: Ray Ni <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>><br>
Reviewed-by: Guo Dong <<a href="mailto:guo.dong@intel.com">guo.dong@intel.com</a>><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Kind regards,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Sumo<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <<a href="mailto:guo.dong@intel.com">guo.dong@intel.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
Signed-off-by: Guo Dong <<a href="mailto:guo.dong@intel.com" target="_blank">guo.dong@intel.com</a>><br>
<br>
> -----Original Message-----<br>
> From: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>> On Behalf Of<br>
> Zhiguang Liu<br>
> Sent: Tuesday, July 13, 2021 11:25 PM<br>
> To: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a><br>
> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and<br>
> PLDFV<br>
> <br>
> Signed-off-by: Zhiguang Liu <<a href="mailto:zhiguang.liu@intel.com" target="_blank">zhiguang.liu@intel.com</a>><br>
> ---<br>
> UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++<br>
> 1 file changed, 2 insertions(+)<br>
> <br>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf<br>
> b/UefiPayloadPkg/UefiPayloadPkg.fdf<br>
> index 2d51fdbacb..041fed842c 100644<br>
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf<br>
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf<br>
> @@ -34,6 +34,7 @@ FV = PLDFV<br>
> <br>
> <br>
> <br>
> ##########################################################<br>
> ######################<br>
> <br>
> [FV.PLDFV]<br>
> <br>
> +FvNameGuid = 96E75986-6FDD-491E-9FD5-35E21AC45B45<br>
> <br>
> BlockSize = $(FD_BLOCK_SIZE)<br>
> <br>
> FvAlignment = 16<br>
> <br>
> ERASE_POLARITY = 1<br>
> <br>
> @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-<br>
> E77F1DB2D793 {<br>
> <br>
> ##########################################################<br>
> ######################<br>
> <br>
> <br>
> <br>
> [FV.DXEFV]<br>
> <br>
> +FvNameGuid = 8063C21A-8E58-4576-95CE-089E87975D23<br>
> <br>
> BlockSize = $(FD_BLOCK_SIZE)<br>
> <br>
> FvForceRebase = FALSE<br>
> <br>
> FvAlignment = 16<br>
> <br>
> --<br>
> 2.30.0.windows.2<br>
> <br>
> <br>
> <br>
> -=-=-=-=-=-=<br>
> Groups.io Links: You receive all messages sent to this group.<br>
> View/Reply Online (#77762): <a href="https://edk2.groups.io/g/devel/message/77762" target="_blank">
https://edk2.groups.io/g/devel/message/77762</a><br>
> Mute This Topic: <a href="https://groups.io/mt/84196221/1781375" target="_blank">
https://groups.io/mt/84196221/1781375</a><br>
> Group Owner: <a href="mailto:devel%2Bowner@edk2.groups.io" target="_blank">devel+owner@edk2.groups.io</a><br>
> Unsubscribe: <a href="https://edk2.groups.io/g/devel/unsub" target="_blank">https://edk2.groups.io/g/devel/unsub</a> [<a href="mailto:guo.dong@intel.com" target="_blank">guo.dong@intel.com</a>]<br>
> -=-=-=-=-=-=<br>
> <br>
<br>
<br>
<br>
<br>
<br>
<o:p></o:p></p>
</blockquote>
</div>
<div>
<p class="MsoNormal"></o:p></span></p>
</div>
</div>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/79762">View/Reply Online (#79762)</a> | | <a target="_blank" href="https://groups.io/mt/84196221/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>