<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-2"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> It refers to access to the root port device that doesn’t exist in case we are dealing with RCiEP device. <o:p></o:p> There can be specific case where RCiEP device has ARI extended capability ID (even though it’s unsupported in this case). <o:p></o:p> In such a case PciSearchDevice goes to CreatePciIoDevice through GatherDeviceInfo. And in this case parent is PCI_IO_DEVICE instance created from CreateRootBridge function, which isn’t valid PCIe device and doesn’t have specific bus, only a range of buses. In that case enumerator tries to use this instance to read operation using default 0 bus number, which isn’t correct.<o:p></o:p> <o:p> </o:p> Damian<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Wu, Hao A <hao.a.wu@intel.com> Sent: Tuesday, August 31, 2021 6:28 AM To: devel@edk2.groups.io; Wu, Hao A <hao.a.wu@intel.com>; Bassa, Damian <damian.bassa@intel.com>; Ni, Ray <ray.ni@intel.com> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/PciBusDxe: Enumerator to check for RCiEP before looking for RP<o:p></o:p> </div> </div> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> On Behalf Of Wu, Hao A Sent: Tuesday, August 31, 2021 12:25 PM To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; Bassa, Damian <<a href="mailto:damian.bassa@intel.com">damian.bassa@intel.com</a>> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciBusDxe: Enumerator to check for RCiEP before looking for RP<o:p></o:p> </div> </div> <o:p> </o:p> Really sorry,<o:p></o:p> <o:p> </o:p> Could you help to provide more information on the below statement?<o:p></o:p> “undefined parent register accesses”<o:p></o:p> <o:p> </o:p> Thanks in advance.<o:p></o:p> <o:p> </o:p> <div> Best Regards,<o:p></o:p> Hao Wu<o:p></o:p> </div> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> On Behalf Of Bassa, Damian Sent: Tuesday, August 24, 2021 11:15 PM To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> Subject: [edk2-devel] [PATCH] MdeModulePkg/PciBusDxe: Enumerator to check for RCiEP before looking for RP<o:p></o:p> </div> </div> <o:p> </o:p> Before trying to access parent root port to check ARI capabilities,<o:p></o:p> enumerator should see if Endpoint device is not Root Complex integrated<o:p></o:p> to avoid undefined parent register accesses in these cases.<o:p></o:p> <o:p> </o:p> Signed-off-by: Damian Bassa <a href="mailto:damian.bassa@intel.com"> damian.bassa@intel.com</a><o:p></o:p> <o:p> </o:p> ---<o:p></o:p> .../Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 12 +++++++++++-<o:p></o:p> 1 file changed, 11 insertions(+), 1 deletion(-)<o:p></o:p> <o:p> </o:p> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c<o:p></o:p> index db1b35f8ef..6451fb8af9 100644<o:p></o:p> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c<o:p></o:p> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c<o:p></o:p> @@ -2153,6 +2153,7 @@ CreatePciIoDevice (<o:p></o:p> PCI_IO_DEVICE *PciIoDevice;<o:p></o:p> EFI_PCI_IO_PROTOCOL *PciIo;<o:p></o:p> EFI_STATUS Status;<o:p></o:p> + PCI_REG_PCIE_CAPABILITY Capability;<o:p></o:p> <o:p> </o:p> PciIoDevice = AllocateZeroPool (sizeof (PCI_IO_DEVICE));<o:p></o:p> if (PciIoDevice == NULL) {<o:p></o:p> @@ -2229,7 +2230,16 @@ CreatePciIoDevice (<o:p></o:p> return NULL;<o:p></o:p> }<o:p></o:p> <o:p> </o:p> - if (PcdGetBool (PcdAriSupport)) {<o:p></o:p> + PciIo->Pci.Read (<o:p></o:p> + PciIo,<o:p></o:p> + EfiPciIoWidthUint16,<o:p></o:p> + PciIoDevice->PciExpressCapabilityOffset + OFFSET_OF (PCI_CAPABILITY_PCIEXP, Capability),<o:p></o:p> + 1,<o:p></o:p> + &Capability.Uint16<o:p></o:p> + );<o:p></o:p> +<o:p></o:p> + if (PcdGetBool (PcdAriSupport) &&<o:p></o:p> + Capability.Bits.DevicePortType != PCIE_DEVICE_PORT_TYPE_ROOT_COMPLEX_INTEGRATED_ENDPOINT) {<o:p></o:p> //<o:p></o:p> // Check if the device is an ARI device.<o:p></o:p> //<o:p></o:p> -- <o:p></o:p> 2.27.0.windows.1<o:p></o:p> <o:p> </o:p> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="100%" align="center"> </div> Intel Technology Poland sp. z o.o. ul. S�owackiego 173 | 80-298 Gda�sk | S�d Rejonowy Gda�sk P�noc | VII Wydzia� Gospodarczy Krajowego Rejestru S�dowego - KRS 101882 | NIP 957-07-52-316 | Kapita� zak�adowy 200.000 PLN. <o:p></o:p> Ta wiadomo�� wraz z za��cznikami jest przeznaczona dla okre�lonego adresata i mo�e zawiera� informacje poufne. W razie przypadkowego otrzymania tej wiadomo�ci, prosimy o powiadomienie nadawcy oraz trwa�e jej usuni�cie; jakiekolwiek przegl�danie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited. <o:p></o:p> <o:p> </o:p> <div> </o:p> </div> </div> <hr/> Intel Technology Poland sp. z o.o. ul. Słowackiego 173 | 80-298 Gdańsk | Sąd Rejonowy Gdańsk Północ | VII Wydział Gospodarczy Krajowego Rejestru Sądowego - KRS 101882 | NIP 957-07-52-316 | Kapitał zakładowy 200.000 PLN. <span style="font-size:8.0pt; font-family:'Arial Narrow',sans-serif; mso-fareast-font-family: 'Times New Roman';mso-bidi-font-family:Arial; color:#595959; mso-ansi-language:EN-US; mso-fareast-language:EN-US; mso-bidi-language: PL-PL"> Ta wiadomość wraz z załącznikami jest przeznaczona dla określonego adresata i może zawierać informacje poufne. W razie przypadkowego otrzymania tej wiadomości, prosimy o powiadomienie nadawcy oraz trwałe jej usunięcie; jakiekolwiek przeglądanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited. <o:p></o:p> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/80021">View/Reply Online (#80021)</a> | | <a target="_blank" href="https://groups.io/mt/85113393/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>