<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=gb2312">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:PMingLiU;
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:3 0 5 9 0 0 0 0 0 0;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"\@DengXian";
panose-1:3 0 5 9 0 0 0 0 0 0;}
@font-face
{font-family:"\@PMingLiU";
panose-1:2 2 5 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:ZH-CN;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:SimSun;
mso-fareast-language:ZH-CN;}
span.EmailStyle17
{mso-style-type:personal;
font-family:DengXian;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW">Hi package maintainers,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW">The review process of this patch set is almost done and please allow me to merge it because the corresponding changes on edk2-platform is also required to merge.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW">Ard and Leif, do I need the Reviewed-by or Acked-by from either of you? Or I can just proceed the merge process as Ard has no problem with this patch set?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW">Abner<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> gaoliming [mailto:gaoliming@byosoft.com.cn] <br>
<b>Sent:</b> Monday, October 11, 2021 9:22 AM<br>
<b>To:</b> devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; ardb@kernel.org<br>
<b>Cc:</b> 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Leif Lindholm' <leif@nuviainc.com>; 'Sami Mujawar' <sami.mujawar@arm.com>; 'Jiewen Yao' <jiewen.yao@intel.com>; 'Jordan Justen' <jordan.l.justen@intel.com>; 'Gerd Hoffmann' <kraxel@redhat.com>; Schaefer,
Daniel <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>; 'Michael D Kinney' <michael.d.kinney@intel.com><br>
<b>Subject:</b> <span lang="ZH-CN" style="font-family:SimSun">回复</span>: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:DengXian">The change in MdePkg is good to me. Reviewed-by: Liming Gao <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:DengXian"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span lang="ZH-CN" style="font-family:SimSun">发件人</span></b><b><span style="font-family:DengXian">:</span></b><span style="font-family:DengXian">
<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>
</span><b><span lang="ZH-CN" style="font-family:SimSun">代表</span></b><b><span lang="ZH-CN" style="font-family:DengXian">
</span></b><span style="font-family:DengXian">Abner Chang<br>
</span><b><span lang="ZH-CN" style="font-family:SimSun">发送时间</span></b><b><span style="font-family:DengXian">:</span></b><span style="font-family:DengXian"> 2021</span><span lang="ZH-CN" style="font-family:SimSun">年</span><span style="font-family:DengXian">10</span><span lang="ZH-CN" style="font-family:SimSun">月</span><span style="font-family:DengXian">8</span><span lang="ZH-CN" style="font-family:SimSun">日</span><span style="font-family:DengXian">
11:39<br>
</span><b><span lang="ZH-CN" style="font-family:SimSun">收件人</span></b><b><span style="font-family:DengXian">:</span></b><span style="font-family:DengXian">
<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; <a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>; <a href="mailto:ardb@kernel.org">ardb@kernel.org</a><br>
</span><b><span lang="ZH-CN" style="font-family:SimSun">抄送</span></b><b><span style="font-family:DengXian">:</span></b><span style="font-family:DengXian"> 'Ard Biesheuvel' <<a href="mailto:ardb+tianocore@kernel.org">ardb+tianocore@kernel.org</a>>; 'Leif Lindholm'
<<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>>; 'Sami Mujawar' <<a href="mailto:sami.mujawar@arm.com">sami.mujawar@arm.com</a>>; 'Jiewen Yao' <<a href="mailto:jiewen.yao@intel.com">jiewen.yao@intel.com</a>>; 'Jordan Justen' <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>>;
'Gerd Hoffmann' <<a href="mailto:kraxel@redhat.com">kraxel@redhat.com</a>>; Schaefer, Daniel <<a href="mailto:daniel.schaefer@hpe.com">daniel.schaefer@hpe.com</a>>; 'Sunil V L' <<a href="mailto:sunilvl@ventanamicro.com">sunilvl@ventanamicro.com</a>>; 'Zhiguang
Liu' <<a href="mailto:zhiguang.liu@intel.com">zhiguang.liu@intel.com</a>>; 'Michael D Kinney' <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>><br>
</span><b><span lang="ZH-CN" style="font-family:SimSun">主题</span></b><b><span style="font-family:DengXian">:</span></b><span style="font-family:DengXian"> Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW">Thanks Liming, could you please also give the reviewed-by.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW">Hi Ard, also need your reviewed-by for ArmPkg. Then this changes could be upstream and finished.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW">Thanks
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW">Abner<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:ZH-TW"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> [<a href="mailto:devel@edk2.groups.io">mailto:devel@edk2.groups.io</a>]
<b>On Behalf Of </b>gaoliming<br>
<b>Sent:</b> Friday, October 8, 2021 11:14 AM<br>
<b>To:</b> Chang, Abner (HPS SW/FW Technologist) <<a href="mailto:abner.chang@hpe.com">abner.chang@hpe.com</a>>; 'edk2-devel-groups-io' <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>;
<a href="mailto:ardb@kernel.org">ardb@kernel.org</a><br>
<b>Cc:</b> 'Ard Biesheuvel' <<a href="mailto:ardb+tianocore@kernel.org">ardb+tianocore@kernel.org</a>>; 'Leif Lindholm' <<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>>; 'Sami Mujawar' <<a href="mailto:sami.mujawar@arm.com">sami.mujawar@arm.com</a>>;
'Jiewen Yao' <<a href="mailto:jiewen.yao@intel.com">jiewen.yao@intel.com</a>>; 'Jordan Justen' <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>>; 'Gerd Hoffmann' <<a href="mailto:kraxel@redhat.com">kraxel@redhat.com</a>>; Schaefer,
Daniel <<a href="mailto:daniel.schaefer@hpe.com">daniel.schaefer@hpe.com</a>>; 'Sunil V L' <<a href="mailto:sunilvl@ventanamicro.com">sunilvl@ventanamicro.com</a>>; 'Zhiguang Liu' <<a href="mailto:zhiguang.liu@intel.com">zhiguang.liu@intel.com</a>>; 'Michael
D Kinney' <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>><br>
<b>Subject:</b> <span lang="ZH-CN" style="font-family:SimSun">回复</span>: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:DengXian">Ard and Abner:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:DengXian"> I am OK to add these three PCDs PcdPciMmio32Translation, PcdPciMmio64Translation, PcdPciIoTranslation to MdePkg.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:DengXian"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:DengXian">Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:DengXian">Liming<o:p></o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span lang="ZH-CN" style="font-family:SimSun">发件人</span></b><b><span style="font-family:DengXian">:</span></b><span style="font-family:DengXian"> Chang, Abner (HPS SW/FW Technologist) <<a href="mailto:abner.chang@hpe.com">abner.chang@hpe.com</a>>
<br>
</span><b><span lang="ZH-CN" style="font-family:SimSun">发送时间</span></b><b><span style="font-family:DengXian">:</span></b><span style="font-family:DengXian"> 2021</span><span lang="ZH-CN" style="font-family:SimSun">年</span><span style="font-family:DengXian">10</span><span lang="ZH-CN" style="font-family:SimSun">月</span><span style="font-family:DengXian">6</span><span lang="ZH-CN" style="font-family:SimSun">日</span><span style="font-family:DengXian">
17:27<br>
</span><b><span lang="ZH-CN" style="font-family:SimSun">收件人</span></b><b><span style="font-family:DengXian">:</span></b><span style="font-family:DengXian"> edk2-devel-groups-io <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>;
<a href="mailto:ardb@kernel.org">ardb@kernel.org</a>; Chang, Abner (HPS SW/FW Technologist) <<a href="mailto:abner.chang@hpe.com">abner.chang@hpe.com</a>><br>
</span><b><span lang="ZH-CN" style="font-family:SimSun">抄送</span></b><b><span style="font-family:DengXian">:</span></b><span style="font-family:DengXian"> Ard Biesheuvel <<a href="mailto:ardb+tianocore@kernel.org">ardb+tianocore@kernel.org</a>>; Leif Lindholm
<<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>>; Sami Mujawar <<a href="mailto:sami.mujawar@arm.com">sami.mujawar@arm.com</a>>; Jiewen Yao <<a href="mailto:jiewen.yao@intel.com">jiewen.yao@intel.com</a>>; Jordan Justen <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>>;
Gerd Hoffmann <<a href="mailto:kraxel@redhat.com">kraxel@redhat.com</a>>; Schaefer, Daniel <<a href="mailto:daniel.schaefer@hpe.com">daniel.schaefer@hpe.com</a>>; Sunil V L <<a href="mailto:sunilvl@ventanamicro.com">sunilvl@ventanamicro.com</a>>; Liming Gao
<<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>>; Zhiguang Liu <<a href="mailto:zhiguang.liu@intel.com">zhiguang.liu@intel.com</a>>; Michael D Kinney <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>><br>
</span><b><span lang="ZH-CN" style="font-family:SimSun">主题</span></b><b><span style="font-family:DengXian">:</span></b><span style="font-family:DengXian"> Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black">Hi Ard,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black">I realized there is a problem if we duplicate ArmPkg defined PCD to under OvmfPkg (e.g. <span style="background:white">PcdPciIoTranslate PCD) when I was duplicating this
PCD to OvmfPkg.</span><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black;background:white">FdtPciProducerLib is relocated to OvmfPkg/Fdt and uses PcdPciIoTranslate PCD declared with OvmfPkg namespace. FdtPciProducerLib is also used by both ArmVirtPkg
and RiscVVirtPkg.</span><span style="font-size:12.0pt;color:black"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black">ArmVirtPkg uses ArmPciCpuIoDxe provided by ArmPkg however
<span style="background:white">PcdPciIoTranslate used by ArmPciCpuIoDxe is declared with ArmPkg namespace.</span><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black;background:white">I think this results in the problem because PcdPciIoTranslate(s) that are referred by ArmPkg and ArmVirtPkg come from two different namespaces, right?
Unless ArmPciCpuIoDxe uses the one declared in OvmfPkg, but I don't think we want to do this.</span><span style="font-size:12.0pt;color:black"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black">Thought? Otherwise, we should still keep the original patch that relocates these PCDs under MdePkg.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black">Thanks<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black">Abner<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="2" width="98%" align="center">
</div>
<div id="divRplyFwdMsg">
<p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black">
<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> on behalf of Abner Chang <<a href="mailto:abner.chang@hpe.com">abner.chang@hpe.com</a>><br>
<b>Sent:</b> Tuesday, October 5, 2021 11:00 PM<br>
<b>To:</b> edk2-devel-groups-io <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>;
<a href="mailto:ardb@kernel.org">ardb@kernel.org</a> <<a href="mailto:ardb@kernel.org">ardb@kernel.org</a>><br>
<b>Cc:</b> Ard Biesheuvel <<a href="mailto:ardb+tianocore@kernel.org">ardb+tianocore@kernel.org</a>>; Leif Lindholm <<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>>; Sami Mujawar <<a href="mailto:sami.mujawar@arm.com">sami.mujawar@arm.com</a>>; Jiewen
Yao <<a href="mailto:jiewen.yao@intel.com">jiewen.yao@intel.com</a>>; Jordan Justen <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>>; Gerd Hoffmann <<a href="mailto:kraxel@redhat.com">kraxel@redhat.com</a>>; Schaefer, Daniel <<a href="mailto:daniel.schaefer@hpe.com">daniel.schaefer@hpe.com</a>>;
Sunil V L <<a href="mailto:sunilvl@ventanamicro.com">sunilvl@ventanamicro.com</a>>; Liming Gao <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>>; Zhiguang Liu <<a href="mailto:zhiguang.liu@intel.com">zhiguang.liu@intel.com</a>>; Michael
D Kinney <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>><br>
<b>Subject:</b> Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg</span>
<o:p></o:p></p>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black">Hi Ard,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black">This way reduces the impact of MdePkg. We can try it.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black">Thanks<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="background:white"><span style="font-size:12.0pt;color:black">Abner<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="2" width="98%" align="center">
</div>
<div id="x_divRplyFwdMsg">
<p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black">
<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> on behalf of Ard Biesheuvel <<a href="mailto:ardb@kernel.org">ardb@kernel.org</a>><br>
<b>Sent:</b> Tuesday, October 5, 2021 5:30 PM<br>
<b>To:</b> edk2-devel-groups-io <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>; Chang, Abner (HPS SW/FW Technologist) <<a href="mailto:abner.chang@hpe.com">abner.chang@hpe.com</a>><br>
<b>Cc:</b> Ard Biesheuvel <<a href="mailto:ardb+tianocore@kernel.org">ardb+tianocore@kernel.org</a>>; Leif Lindholm <<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>>; Sami Mujawar <<a href="mailto:sami.mujawar@arm.com">sami.mujawar@arm.com</a>>; Jiewen
Yao <<a href="mailto:jiewen.yao@intel.com">jiewen.yao@intel.com</a>>; Jordan Justen <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>>; Gerd Hoffmann <<a href="mailto:kraxel@redhat.com">kraxel@redhat.com</a>>; Schaefer, Daniel <<a href="mailto:daniel.schaefer@hpe.com">daniel.schaefer@hpe.com</a>>;
Sunil V L <<a href="mailto:sunilvl@ventanamicro.com">sunilvl@ventanamicro.com</a>>; Liming Gao <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>>; Zhiguang Liu <<a href="mailto:zhiguang.liu@intel.com">zhiguang.liu@intel.com</a>>; Michael
D Kinney <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>><br>
<b>Subject:</b> Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg</span>
<o:p></o:p></p>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">On Thu, 30 Sept 2021 at 03:43, Abner Chang <<a href="mailto:abner.chang@hpe.com">abner.chang@hpe.com</a>> wrote:<br>
><br>
> In V3: Address comments on V2.<br>
> In V2: Remove HPE license on the files that just moved around or<br>
> the changes in the file are just code removal.<br>
><br>
> edk2 BZ #: 3665<br>
> edk2 platform corresponding changes will be submitted after<br>
> this pactch set is reviewed.<br>
><br>
> This pacthes set is to migrate some modules from ArmVirtPkg<br>
> to under OvmfPkg for the upcoming RiscVVirtPkg that can leverage<br>
> those modules without the dependency with Arm*Pkg.<br>
><br>
> The modules moved from ArmVirtPkg to OvmfPkg are,<br>
> - FdtClientDxe<br>
> - PciPcdProducerLib<br>
> - HighMemDxe<br>
> - QemuFwCfgLib<br>
> - FdtPciHostBridgeLib<br>
> - VirtioFdtDxe<br>
><br>
> Below PCDs are moved to under MdePkg and leverage by RiscVVirtPkg.<br>
> This change also remove the dependency on ArmPkg of OvmfPkg.<br>
> - PcdPciIoTranslation<br>
> - PcdPciIoTranslation<br>
> - PcdPciMmio32(64)Translation<br>
><br>
> Signed-off-by: Abner Chang <<a href="mailto:abner.chang@hpe.com">abner.chang@hpe.com</a>><br>
> Cc: Ard Biesheuvel <<a href="mailto:ardb+tianocore@kernel.org">ardb+tianocore@kernel.org</a>><br>
> Cc: Leif Lindholm <<a href="mailto:leif@nuviainc.com">leif@nuviainc.com</a>><br>
> Cc: Sami Mujawar <<a href="mailto:sami.mujawar@arm.com">sami.mujawar@arm.com</a>><br>
> Cc: Jiewen Yao <<a href="mailto:jiewen.yao@intel.com">jiewen.yao@intel.com</a>><br>
> Cc: Jordan Justen <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>><br>
> Cc: Gerd Hoffmann <<a href="mailto:kraxel@redhat.com">kraxel@redhat.com</a>><br>
> Cc: Daniel Schaefer <<a href="mailto:daniel.schaefer@hpe.com">daniel.schaefer@hpe.com</a>><br>
> Cc: Sunil V L <<a href="mailto:sunilvl@ventanamicro.com">sunilvl@ventanamicro.com</a>><br>
> Cc: Liming Gao <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>><br>
> Cc: Zhiguang Liu <<a href="mailto:zhiguang.liu@intel.com">zhiguang.liu@intel.com</a>><br>
> Cc: Michael D Kinney <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>><br>
><br>
> Abner Chang (12):<br>
> ArmVirtPkg/FdtClintDxe: Move FdtClientDxe to EmbeddedPkg<br>
> MdePkg: Add PcdPciIoTranslation PCD<br>
> ArmPkg: Use PcdPciIoTranslation PCD from MdePkg<br>
> ArmVirtPkg/FdtPciPcdProducerLib: Relocate PciPcdProducerLib to OvmfPkg<br>
> ArmVirtPkg/HighMemDxe: Relocate HighMemDxe to OvmfPkg<br>
> OvmfPkg/HighMemDxe: Add RISC-V in the supported arch.<br>
> ArmVirtPkg/QemuFwCfgLib: Relocate QemuFwCfgLib to OvmfPkg<br>
> OvmfPkg/QemuFwCfgLibMMIO: Add RISC-V arch support<br>
> MdePkg: Add PcdPciMmio32(64)Translation PCDs<br>
> ArmVirtPkg/FdtPciHostBridgeLib: Relocate FdtPciHostBridgeLib to<br>
> OvmfPkg/Fdt<br>
> OvmfPkg/FdtPciHostBridgeLib: Add RISC-V in the supported arch.<br>
> ArmVirtPkg/VirtioFdtDxe: Relocate VirtioFdtDxe to OvmfPkg/Fdt<br>
><br>
<br>
Hello all,<br>
<br>
These patches look ok to me, but I wonder if the MdePkg maintainers<br>
are happy taking these PCD declaration changes. Translations for PCIe<br>
are typically defined per host bridge, and I would rather move away<br>
from using PCDs for this entirely than 'promote' them by carrying them<br>
in MdePkg.<br>
<br>
As this issue is somewhat orthogonal to what Abner is trying to fix,<br>
perhaps it is better to avoid MdePkg changes for now, and just<br>
duplicate these PCDs into OvmfPkg. This is reasonable, given that we<br>
know that QEMU only exposes a single host bridge.<br>
<br>
The one in ArmPkg can hopefully be removed and replaced with something<br>
that is more appropriate.<br>
<br>
<br>
> ArmPkg/ArmPkg.dec | 15 ++++++--------<br>
> ArmVirtPkg/ArmVirtPkg.dec | 3 ---<br>
> EmbeddedPkg/EmbeddedPkg.dec | 1 +<br>
> MdePkg/MdePkg.dec | 12 +++++++++++<br>
> ArmVirtPkg/ArmVirtCloudHv.dsc | 18 ++++++++---------<br>
> ArmVirtPkg/ArmVirtKvmTool.dsc | 18 ++++++++---------<br>
> ArmVirtPkg/ArmVirtQemu.dsc | 20 +++++++++----------<br>
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 20 +++++++++----------<br>
> ArmVirtPkg/ArmVirtXen.dsc | 2 +-<br>
> EmbeddedPkg/EmbeddedPkg.dsc | 1 +<br>
> ArmVirtPkg/ArmVirtCloudHv.fdf | 6 +++---<br>
> ArmVirtPkg/ArmVirtKvmTool.fdf | 6 +++---<br>
> ArmVirtPkg/ArmVirtXen.fdf | 2 +-<br>
> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 6 +++---<br>
> .../ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf | 2 +-<br>
> .../ArmVirtGicArchLib/ArmVirtGicArchLib.inf | 1 +<br>
> .../ArmVirtPL031FdtClientLib.inf | 1 +<br>
> .../ArmVirtPsciResetSystemLib.inf | 1 +<br>
> .../ArmVirtTimerFdtClientLib.inf | 1 +<br>
> .../KvmtoolRtcFdtClientLib.inf | 1 +<br>
> .../NorFlashKvmtoolLib/NorFlashKvmtoolLib.inf | 1 +<br>
> .../NorFlashQemuLib/NorFlashQemuLib.inf | 1 +<br>
> .../XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 1 +<br>
> ArmVirtPkg/XenioFdtDxe/XenioFdtDxe.inf | 1 +<br>
> .../Drivers}/FdtClientDxe/FdtClientDxe.inf | 1 -<br>
> .../FdtPciHostBridgeLib.inf | 11 +++++-----<br>
> .../FdtPciPcdProducerLib.inf | 5 ++---<br>
> .../Fdt}/HighMemDxe/HighMemDxe.inf | 7 ++++---<br>
> .../Fdt}/VirtioFdtDxe/VirtioFdtDxe.inf | 2 +-<br>
> .../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 6 +++---<br>
> .../Include/Protocol/FdtClient.h | 0<br>
> .../Drivers}/FdtClientDxe/FdtClientDxe.c | 0<br>
> .../FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 0<br>
> .../FdtPciPcdProducerLib.c | 0<br>
> .../Fdt}/HighMemDxe/HighMemDxe.c | 3 ++-<br>
> .../Fdt}/VirtioFdtDxe/VirtioFdtDxe.c | 0<br>
> .../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c | 7 ++++---<br>
> Maintainers.txt | 6 ++++++<br>
> 38 files changed, 106 insertions(+), 83 deletions(-)<br>
> rename {ArmVirtPkg => EmbeddedPkg/Drivers}/FdtClientDxe/FdtClientDxe.inf (92%)<br>
> rename {ArmVirtPkg/Library => OvmfPkg/Fdt}/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf (77%)<br>
> rename {ArmVirtPkg/Library => OvmfPkg/Fdt}/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf (87%)<br>
> rename {ArmVirtPkg => OvmfPkg/Fdt}/HighMemDxe/HighMemDxe.inf (83%)<br>
> rename {ArmVirtPkg => OvmfPkg/Fdt}/VirtioFdtDxe/VirtioFdtDxe.inf (92%)<br>
> rename ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf => OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf (86%)<br>
> rename {ArmVirtPkg => EmbeddedPkg}/Include/Protocol/FdtClient.h (100%)<br>
> rename {ArmVirtPkg => EmbeddedPkg/Drivers}/FdtClientDxe/FdtClientDxe.c (100%)<br>
> rename {ArmVirtPkg/Library => OvmfPkg/Fdt}/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c (100%)<br>
> rename {ArmVirtPkg/Library => OvmfPkg/Fdt}/FdtPciPcdProducerLib/FdtPciPcdProducerLib.c (100%)<br>
> rename {ArmVirtPkg => OvmfPkg/Fdt}/HighMemDxe/HighMemDxe.c (95%)<br>
> rename {ArmVirtPkg => OvmfPkg/Fdt}/VirtioFdtDxe/VirtioFdtDxe.c (100%)<br>
> rename ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c => OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmio.c (93%)<br>
><br>
> --<br>
> 2.17.1<br>
><br>
><br>
><br>
> <br>
><br>
><br>
<br>
<o:p></o:p></p>
</div>
</div>
</div>
</div>
<div>
<p class="MsoNormal"></o:p></span></p>
</div>
</div>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/81801">View/Reply Online (#81801)</a> | | <a target="_blank" href="https://groups.io/mt/86255081/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>