<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> Hi Marvin,<o:p></o:p> How about we limit the -fno-pie option only apply on IA32 and X64 like below?<o:p></o:p> <o:p> </o:p> diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.inf b/StandaloneMmPkg/Core/StandaloneMmCore.inf<o:p></o:p> [BuildOptions]<o:p></o:p> GCC:*_*_*_CC_FLAGS = -fpie<o:p></o:p> GCC:*_*_*_DLINK_FLAGS = -Wl,-z,text,-Bsymbolic,-pie<o:p></o:p> + CLANGPDB:*_*_ IA32_CC_FLAGS= -fno-pie<o:p></o:p> + CLANGPDB:*_*_ X64_CC_FLAGS= -fno-pie<o:p></o:p> <o:p> </o:p> diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf<o:p></o:p> [BuildOptions]<o:p></o:p> GCC:*_*_*_CC_FLAGS = -fpie<o:p></o:p> + CLANGPDB:*_*_ IA32_CC_FLAGS= -fno-pie<o:p></o:p> + CLANGPDB:*_*_ X64_CC_FLAGS= -fno-pie<o:p></o:p> <o:p> </o:p> <o:p> </o:p> Thanks<o:p></o:p> Steven Shi<o:p></o:p> <o:p> </o:p> <o:p> </o:p> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marvin > Häuser > Sent: Thursday, October 14, 2021 4:05 PM > To: Yang, JiyangX <jiyangx.yang@intel.com>; devel@edk2.groups.io > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar > <sami.mujawar@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>; Supreeth > Venkatesh <supreeth.venkatesh@arm.com>; Vitaly Cheptsov > <vit9696@protonmail.com>; Shi, Steven <steven.shi@intel.com> > Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support > CLANGPDB build > > Hey Jiyang, > > NO! Please do not. :) > Yes, this fixes build, but the AARCH64 core (I did not check ARM) > depends on self-relocation as it is loaded in-place at a location > unknown at compile-time. PIE helps ensure there are no relocations in > .text among other things. I know CLANGPDB does not support > ARM/AARCH64 > yet, but if it is added, this may generate binaries with more dangerous > relocations, which means the chance of executing an instruction that > requires relocation without relocating first (relocation is done in C > code now!) is significantly higher. We do not need PIE for IA32 or X64 > at all (or more specifically, we only need it for ARM-based > architectures as of now), so I prefer my patch which makes that > explicit. Though we can theoretically use your solution when limited to > non-ARM architectures if you really dislike my patch that much. > > I'd prefer to hear from the ARM core maintainers before making any move. > > Best regards, > Marvin > > On 14.10.21 05:12, Jiyang Yang wrote: > > the flag "-fpie" is passed for all builds with a GCC family toolchain, > > including CLANGPDB, but CLANGPDB does not support this flag, it will > > report "clang: error: unsupported option '-fpie' for target > > 'x86_64-unknown-windows-gnu'". So we add the CLANGPDB option "-fno- > pie" > > later to overwrite it. > > > > Cc: Ard Biesheuvel <<a href="mailto:ardb+tianocore@kernel.org">ardb+tianocore@kernel.org</a>> > > Cc: Sami Mujawar <<a href="mailto:sami.mujawar@arm.com">sami.mujawar@arm.com</a>> > > Cc: Jiewen Yao <<a href="mailto:jiewen.yao@intel.com">jiewen.yao@intel.com</a>> > > Cc: Supreeth Venkatesh <<a href="mailto:supreeth.venkatesh@arm.com">supreeth.venkatesh@arm.com</a>> > > Cc: Vitaly Cheptsov <<a href="mailto:vit9696@protonmail.com">vit9696@protonmail.com</a>> > > Cc: Marvin Häuser <<a href="mailto:mhaeuser@posteo.de">mhaeuser@posteo.de</a>> > > Cc: Steven Shi <<a href="mailto:steven.shi@intel.com">steven.shi@intel.com</a>> > > Signed-off-by: Jiyang Yang <<a href="mailto:jiyangx.yang@intel.com">jiyangx.yang@intel.com</a>> > > --- > > StandaloneMmPkg/Core/StandaloneMmCore.inf | 2 > ++ > > > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmC > oreEntryPoint.inf | 1 + > > 2 files changed, 3 insertions(+) > > > > diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.inf > b/StandaloneMmPkg/Core/StandaloneMmCore.inf > > index 56042b7b39f4..3213142523f4 100644 > > --- a/StandaloneMmPkg/Core/StandaloneMmCore.inf > > +++ b/StandaloneMmPkg/Core/StandaloneMmCore.inf > > @@ -79,3 +79,5 @@ > > [BuildOptions] > > GCC:*_*_*_CC_FLAGS = -fpie > > GCC:*_*_*_DLINK_FLAGS = -Wl,-z,text,-Bsymbolic,-pie > > + CLANGPDB:*_*_*_CC_FLAGS = -fno-pie > > + CLANGPDB:*_*_*_DLINK_FLAGS = > > diff --git > a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMm > CoreEntryPoint.inf > b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMm > CoreEntryPoint.inf > > index 1762586cfa02..ef69e07d2c07 100644 > > --- > a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMm > CoreEntryPoint.inf > > +++ > b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMm > CoreEntryPoint.inf > > @@ -56,3 +56,4 @@ > > > > [BuildOptions] > > GCC:*_*_*_CC_FLAGS = -fpie > > + CLANGPDB:*_*_*_CC_FLAGS = -fno-pie > > > > > <o:p> </o:p> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/82006">View/Reply Online (#82006)</a> | | <a target="_blank" href="https://groups.io/mt/86305054/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>