<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=gb2312"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:等线;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@等线";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:等线;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=ZH-CN link="#0563C1" vlink="#954F72" style='word-wrap:break-word'><div class=WordSection1><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:等线'>I suggest to merge this fix for the stable tag 202111. This fix is low risk. <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:等线'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:等线'>Thanks<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:等线'>Liming<o:p></o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span style='font-family:等线'>发件人<span lang=EN-US>:</span></span></b><span lang=EN-US style='font-family:等线'> devel@edk2.groups.io <devel@edk2.groups.io> </span><b><span style='font-family:等线'>代表 </span></b><span lang=EN-US style='font-family:等线'>Wu, Jiaxin<br></span><b><span style='font-family:等线'>发送时间<span lang=EN-US>:</span></span></b><span lang=EN-US style='font-family:等线'> 2021</span><span style='font-family:等线'>年<span lang=EN-US>11</span>月<span lang=EN-US>25</span>日<span lang=EN-US> 9:37<br></span><b>收件人<span lang=EN-US>:</span></b><span lang=EN-US> Anbazhagan, Baraneedharan <anbazhagan@hp.com>; devel@edk2.groups.io<br></span><b>抄送<span lang=EN-US>:</span></b><span lang=EN-US> maciej.rabeda@linux.intel.com; Fu, Siyuan <siyuan.fu@intel.com><br></span><b>主题<span lang=EN-US>:</span></b><span lang=EN-US> Re: [edk2-devel] NetworkPkg: Fix invalid pointer for DNS response token on error<o:p></o:p></span></span></p></div></div><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US>Reviewed-by: Wu Jiaxin <<a href="mailto:jiaxin.wu@intel.com">jiaxin.wu@intel.com</a>><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US>From:</span></b><span lang=EN-US> Anbazhagan, Baraneedharan <<a href="mailto:anbazhagan@hp.com">anbazhagan@hp.com</a>> <br><b>Sent:</b> Thursday, November 25, 2021 9:28 AM<br><b>To:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a><br><b>Cc:</b> <a href="mailto:maciej.rabeda@linux.intel.com">maciej.rabeda@linux.intel.com</a>; Wu, Jiaxin <<a href="mailto:jiaxin.wu@intel.com">jiaxin.wu@intel.com</a>>; Fu, Siyuan <<a href="mailto:siyuan.fu@intel.com">siyuan.fu@intel.com</a>><br><b>Subject:</b> RE: NetworkPkg: Fix invalid pointer for DNS response token on error<o:p></o:p></span></p></div></div><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US>Ref: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=3719">https://bugzilla.tianocore.org/show_bug.cgi?id=3719</a><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US>Token->RspData.H2AData is de-allocated on error but it is not<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>set to NULL. HTTP module attempts to free again and cause assert.<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US>Signed-off-by: Baraneedharan Anbazhagan <a href="mailto:anbazhagan@hp.com">anbazhagan@hp.com</a><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>---<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>NetworkPkg/DnsDxe/DnsImpl.c | 2 ++<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>1 file changed, 2 insertions(+)<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US>diff --git a/NetworkPkg/DnsDxe/DnsImpl.c b/NetworkPkg/DnsDxe/DnsImpl.c<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>index 2edcb280ac..78a56f2b56 100644<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>--- a/NetworkPkg/DnsDxe/DnsImpl.c<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>+++ b/NetworkPkg/DnsDxe/DnsImpl.c<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>@@ -1700,6 +1700,7 @@ ON_EXIT:<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> }<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US> FreePool (Dns4TokenEntry->Token->RspData.H2AData);<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>+ Dns4TokenEntry->Token->RspData.H2AData = NULL;<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> }<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> }<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> }<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>@@ -1731,6 +1732,7 @@ ON_EXIT:<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> }<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US> FreePool (Dns6TokenEntry->Token->RspData.H2AData);<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>+ Dns6TokenEntry->Token->RspData.H2AData = NULL;<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> }<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> }<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> }<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>-- <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>2.33.0.windows.2<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p></div><div><p class=MsoNormal></o:p></span></p></div></div></body></html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/84072">View/Reply Online (#84072)</a> | | <a target="_blank" href="https://groups.io/mt/87294818/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>