<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-GB" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> Hi Abdul,<o:p></o:p> <o:p> </o:p> With the introduction of Uncrustify tool in the edk2 CI, I think you may have to<o:p></o:p> - rebase with latest edk2 master and resolve any conflicts<o:p></o:p> - run uncrustify on your patches<o:p></o:p> - re-submit your patches. <o:p></o:p> <o:p> </o:p> More information on using uncrustify can be found at <a href="https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting"> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting</a><o:p></o:p> <o:p> </o:p> Regards,<o:p></o:p> <o:p> </o:p> Sami Mujawar<o:p></o:p> <o:p> </o:p> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com> Date: Tuesday, 14 December 2021 at 11:18 To: Sami Mujawar <Sami.Mujawar@arm.com>, devel@edk2.groups.io <devel@edk2.groups.io>, Ray Ni <ray.ni@intel.com>, Zhichao Gao <zhichao.gao@intel.com> Cc: nd <nd@arm.com> Subject: RE: [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser<o:p></o:p> </div> <div> Hi Zhichao Gao, Ray Ni, Sami Mujawar, Please review and create PR if looks good. Thanks AbduL -----Original Message----- From: Sami Mujawar <sami.mujawar@arm.com> Sent: Monday, November 22, 2021 11:24 PM To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; devel@edk2.groups.io Cc: Ray Ni <ray.ni@intel.com>; Zhichao Gao <zhichao.gao@intel.com>; nd <nd@arm.com> Subject: Re: [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser [CAUTION: External Email] Hi Abdul, Thank you for this patch series. This series looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> Regards, Sami Mujawar On 22/11/2021 10:21 AM, Abdul Lateef Attar wrote: > Hi Sami, Zhichao, > Addressed all review comments. > Created two different patches, one for bitfield parser and another for > FADT Flags parser. > > Thanks > AbduL > > REF : > <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith</a> > ub.com%2Fabdattar%2Fedk2%2Ftree%2FFadtFlagsParser&data=04%7C01%7CA > bdulLateef.Attar%40amd.com%7C95999e9fce1346f1eb8608d9ade11d90%7C3dd896 > 1fe4884e608e11a82d994e183d%7C0%7C0%7C637732004653569840%7CUnknown%7CTW > FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6 > Mn0%3D%7C3000&sdata=%2Btp2oW%2Bo3WoF7b4RnPFot3z5vggrUiwOaL%2FiPl4U > WHY%3D&reserved=0 > > Cc: Ray Ni <ray.ni@intel.com> > Cc: Zhichao Gao <zhichao.gao@intel.com> > Cc: Sami Mujawar <sami.mujawar@arm.com> > Signed-off-by: Abdul Lateef Attar <abdattar@amd.com> Abdul Lateef > Attar (2): > ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser > ShellPkg/AcpiView: PrintFormatter for FADT Flags field > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 45 +++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 177 ++++++++++++++++++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 59 ++++++- > 3 files changed, 280 insertions(+), 1 deletion(-) ><o:p></o:p> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/84800">View/Reply Online (#84800)</a> | | <a target="_blank" href="https://groups.io/mt/87232139/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>