<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"><style>body { line-height: 1.5; }blockquote { margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em; }body { font-size: 14px; font-family: "Microsoft YaHei UI"; color: rgb(0, 0, 0); line-height: 1.5; }</style></head><body> <div><span></span>On 32bit protectd mode, is there any impact if <span style="background-color: transparent;">PcdCpuStackGuard is set to TRUE? Even thers is no page table enabling at that time.</span></div><div><br></div><div>Best Regards,</div><div>Jeff</div> <div><br></div><hr style="width: 210px; height: 1px;" color="#b5c4df" size="1" align="left"> <div><span><div style="MARGIN: 10px; FONT-FAMILY: verdana; FONT-SIZE: 10pt"><div>fanjianfeng@byosoft.com.cn</div></div></span></div> <blockquote style="margin-Top: 0px; margin-Bottom: 0px; margin-Left: 0.5em; margin-Right: inherit"><div> </div><div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"><div style="PADDING-RIGHT: 8px; PADDING-LEFT: 8px; FONT-SIZE: 12px;FONT-FAMILY:tahoma;COLOR:#000000; BACKGROUND: #efefef; PADDING-BOTTOM: 8px; PADDING-TOP: 8px"><div><b>From:</b> <a href="mailto:gang.c.chen@intel.com">Chen, Gang C</a></div><div><b>Date:</b> 2022-04-11 22:51</div><div><b>To:</b> <a href="mailto:ray.ni@intel.com">Ni, Ray</a>; <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; <a href="mailto:shuo.liu@intel.com">Liu, Shuo</a></div><div><b>CC:</b> <a href="mailto:guomin.jiang@intel.com">Jiang, Guomin</a>; <a href="mailto:dandan.bi@intel.com">Bi, Dandan</a>; <a href="mailto:di.zhang@intel.com">Zhang, Di</a>; <a href="mailto:jian.j.wang@intel.com">Wang, Jian J</a>; <a href="mailto:gaoliming@byosoft.com.cn">Gao, Liming</a></div><div><b>Subject:</b> Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property</div></div></div><div><div>This impact of this change is not as simple as what the patch does.</div> <div>-->You're correct, that's why the PATCH 2/2 removed the check in AP.</div> <div> </div> <div>Why cannot FSP API and Dispatch mode use the same setting? (either enabled or disabled)</div> <div>-->For example, in coreboot, it's 32-bit, so there is no Paging needed. In this case, it needs to disable it for FSP API mode. But this feature is needed for Dispatch mode. </div> <div> </div> <div>@Liu, Shuo, if any information is wrong or missed, please correct me. Thanks.</div> <div> </div> <div>Best Regards</div> <div>Gang</div> <div> </div> <div>-----Original Message-----</div> <div>From: Ni, Ray <ray.ni@intel.com> </div> <div>Sent: Monday, April 11, 2022 9:55 PM</div> <div>To: devel@edk2.groups.io; Chen, Gang C <gang.c.chen@intel.com></div> <div>Cc: Jiang, Guomin <guomin.jiang@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zhang, Di <di.zhang@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn></div> <div>Subject: RE: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property</div> <div> </div> <div>FixedAtBuild PCD can be accessed at any time from any CPU.</div> <div>But dynamic PCD can only be accessed from BSP and after PCD database is initialized.</div> <div> </div> <div>This impact of this change is not as simple as what the patch does.</div> <div> </div> <div>Why cannot FSP API and Dispatch mode use the same setting? (either enabled or disabled)</div> <div> </div> <div>Thanks,</div> <div>Ray</div> <div> </div> <div>> -----Original Message-----</div> <div>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chen, </div> <div>> Gang C</div> <div>> Sent: Monday, April 11, 2022 6:14 PM</div> <div>> To: devel@edk2.groups.io</div> <div>> Cc: Jiang, Guomin <guomin.jiang@intel.com>; Bi, Dandan </div> <div>> <dandan.bi@intel.com>; Zhang, Di <di.zhang@intel.com>; Wang, Jian J </div> <div>> <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn></div> <div>> Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the </div> <div>> PcdCpuStackGuard property</div> <div>> </div> <div>> Update the PcdCpuStackGuard from PcdsFixedAtBuild to PcdsDynamicEx for </div> <div>> the requirement to set different value in FSP API mode and FSP </div> <div>> Dispatch mode.</div> <div>> </div> <div>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3897</div> <div>> </div> <div>> Cc: Jian J Wang <jian.j.wang@intel.com></div> <div>> Cc: Liming Gao <gaoliming@byosoft.com.cn></div> <div>> Cc: devel@edk2.groups.io</div> <div>> </div> <div>> Signed-off-by: Gang Chen <gang.c.chen@intel.com></div> <div>> ---</div> <div>> MdeModulePkg/MdeModulePkg.dec | 14 +++++++-------</div> <div>> 1 file changed, 7 insertions(+), 7 deletions(-)</div> <div>> </div> <div>> diff --git a/MdeModulePkg/MdeModulePkg.dec </div> <div>> b/MdeModulePkg/MdeModulePkg.dec index 463e889e9a..72e7e2eced 100644</div> <div>> --- a/MdeModulePkg/MdeModulePkg.dec</div> <div>> +++ b/MdeModulePkg/MdeModulePkg.dec</div> <div>> @@ -1070,13 +1070,6 @@</div> <div>> # @Prompt The Heap Guard feature mask</div> <div>> </div> <div>> gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPropertyMask|0x0|UINT8|0x30</div> <div>> 001054</div> <div>> </div> <div>> - ## Indicates if UEFI Stack Guard will be enabled.</div> <div>> - # If enabled, stack overflow in UEFI can be caught, preventing chaotic consequences.<BR><BR></div> <div>> - # TRUE - UEFI Stack Guard will be enabled.<BR></div> <div>> - # FALSE - UEFI Stack Guard will be disabled.<BR></div> <div>> - # @Prompt Enable UEFI Stack Guard.</div> <div>> - </div> <div>> gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|FALSE|BOOLEAN|0x300010</div> <div>> 55</div> <div>> -</div> <div>> [PcdsFixedAtBuild, PcdsPatchableInModule]</div> <div>> ## Dynamic type PCD can be registered callback function for Pcd setting action.</div> <div>> # PcdMaxPeiPcdCallBackNumberPerPcdEntry indicates the maximum </div> <div>> number of callback function @@ -2079,6 +2072,13 @@</div> <div>> # @Prompt Enable PCIe Resizable BAR Capability support.</div> <div>> </div> <div>> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE|BOOLEA</div> <div>> N|0x10000024</div> <div>> </div> <div>> + ## Indicates if UEFI Stack Guard will be enabled.</div> <div>> + # If enabled, stack overflow in UEFI can be caught, preventing chaotic consequences.<BR><BR></div> <div>> + # TRUE - UEFI Stack Guard will be enabled.<BR></div> <div>> + # FALSE - UEFI Stack Guard will be disabled.<BR></div> <div>> + # @Prompt Enable UEFI Stack Guard.</div> <div>> + </div> <div>> + gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|FALSE|BOOLEAN|0x0001</div> <div>> + 0025</div> <div>> +</div> <div>> [PcdsPatchableInModule]</div> <div>> ## Specify memory size with page number for PEI code when</div> <div>> # Loading Module at Fixed Address feature is enabled.</div> <div>> --</div> <div>> 2.35.1</div> <div>> </div> <div>> </div> <div>> </div> <div>> </div> <div>> </div> <div> </div> <div> </div> <div> </div> <div></div> <div> </div> <div> </div> <div> </div> </div></blockquote> </body></html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/88761">View/Reply Online (#88761)</a> | | <a target="_blank" href="https://groups.io/mt/90391665/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>