<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 1 6 1 0 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@PMingLiU";
panose-1:2 1 6 1 0 1 1 1 1 1;}
/* Style Definitions */
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoPlainText"><a id="OWAAM256F4279BBD04AFEB60F95B5004E8BB2" href="mailto:gaoliming@byosoft.com.cn"><span style="font-family:"Calibri",sans-serif;text-decoration:none">@gaoliming</span></a><o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">May I get your help to add push Label on the PR ?<br>
<a href="https://github.com/tianocore/edk2/pull/2844">https://github.com/tianocore/edk2/pull/2844</a><br>
<br>
<o:p></o:p></p>
<p class="MsoPlainText">It seems I don't have access right to add push Label by myself.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">If have any concern please also share me.<o:p></o:p></p>
<p class="MsoPlainText"><br>
Thanks,<br>
Gua<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><span style="mso-fareast-language:ZH-CN">-----Original Message-----<br>
From: gaoliming <gaoliming@byosoft.com.cn> <br>
Sent: Sunday, May 8, 2022 10:44 PM<br>
To: devel@edk2.groups.io; guo.guo@intel.com<br>
Cc: Guo, Gua <gua.guo@intel.com><br>
Subject: </span><span lang="ZH-CN" style="font-family:"PMingLiU",serif;mso-fareast-language:ZH-CN">回复</span><span style="mso-fareast-language:ZH-CN">: [edk2-devel] [PATCH] MdeModulePkg/PCD: Pcd initialize DXE have assert</span></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Guo:<o:p></o:p></p>
<p class="MsoPlainText"> This change is good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.<o:p></o:p></p>
<p class="MsoPlainText">cn><o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Thanks<o:p></o:p></p>
<p class="MsoPlainText">Liming<o:p></o:p></p>
<p class="MsoPlainText">> -----<span lang="ZH-TW" style="font-family:"PMingLiU",serif">邮件原件</span>-----<o:p></o:p></p>
<p class="MsoPlainText">> <span lang="ZH-TW" style="font-family:"PMingLiU",serif">
发件人</span>: <a href="mailto:devel@edk2.groups.io"><span style="color:windowtext;text-decoration:none">devel@edk2.groups.io</span></a> <<a href="mailto:devel@edk2.groups.io"><span style="color:windowtext;text-decoration:none">devel@edk2.groups.io</span></a>>
<span lang="ZH-TW" style="font-family:"PMingLiU",serif">代表</span><o:p></o:p></p>
<p class="MsoPlainText">> <a href="mailto:guo.guo@intel.com"><span style="color:windowtext;text-decoration:none">guo.guo@intel.com</span></a><o:p></o:p></p>
<p class="MsoPlainText">> <span lang="ZH-TW" style="font-family:"PMingLiU",serif">
发送时间</span>: 2022<span lang="ZH-TW" style="font-family:"PMingLiU",serif">年</span>5<span lang="ZH-TW" style="font-family:"PMingLiU",serif">月</span>6<span lang="ZH-TW" style="font-family:"PMingLiU",serif">日</span> 5:30<o:p></o:p></p>
<p class="MsoPlainText">> <span lang="ZH-TW" style="font-family:"PMingLiU",serif">
收件人</span>: <a href="mailto:devel@edk2.groups.io"><span style="color:windowtext;text-decoration:none">devel@edk2.groups.io</span></a><o:p></o:p></p>
<p class="MsoPlainText">> <span lang="ZH-TW" style="font-family:"PMingLiU",serif">
抄送</span>: Gua Guo <<a href="mailto:gua.guo@intel.com"><span style="color:windowtext;text-decoration:none">gua.guo@intel.com</span></a>><o:p></o:p></p>
<p class="MsoPlainText">> <span lang="ZH-TW" style="font-family:"PMingLiU",serif">
主题</span>: [edk2-devel] [PATCH] MdeModulePkg/PCD: Pcd initialize DXE have <o:p></o:p></p>
<p class="MsoPlainText">> assert<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> From: Gua Guo <<a href="mailto:gua.guo@intel.com"><span style="color:windowtext;text-decoration:none">gua.guo@intel.com</span></a>><o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> REF: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=3917">
<span style="color:windowtext;text-decoration:none">https://bugzilla.tianocore.org/show_bug.cgi?id=3917</span></a><o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> When PlatformPkg.dsc has multiple SKU IDs but didn't exist delta PCD,
<o:p></o:p></p>
<p class="MsoPlainText">> System will hang on BuildPcdDxeDataBase.<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> Ideally, if didn't exist delta PCD by different SKU ID,
<o:p></o:p></p>
<p class="MsoPlainText">> UpdatePcdDatabase () shouldn't return EFI_NOT_FOUND.<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> Signed-off-by: Gua Guo <<a href="mailto:gua.guo@intel.com"><span style="color:windowtext;text-decoration:none">gua.guo@intel.com</span></a>><o:p></o:p></p>
<p class="MsoPlainText">> ---<o:p></o:p></p>
<p class="MsoPlainText">> MdeModulePkg/Universal/PCD/Dxe/Service.c | 5 +++++<o:p></o:p></p>
<p class="MsoPlainText">> 1 file changed, 5 insertions(+)<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> diff --git a/MdeModulePkg/Universal/PCD/Dxe/Service.c<o:p></o:p></p>
<p class="MsoPlainText">> b/MdeModulePkg/Universal/PCD/Dxe/Service.c<o:p></o:p></p>
<p class="MsoPlainText">> index 3965846b93..5ade8d988b 100644<o:p></o:p></p>
<p class="MsoPlainText">> --- a/MdeModulePkg/Universal/PCD/Dxe/Service.c<o:p></o:p></p>
<p class="MsoPlainText">> +++ b/MdeModulePkg/Universal/PCD/Dxe/Service.c<o:p></o:p></p>
<p class="MsoPlainText">> @@ -817,6 +817,11 @@ UpdatePcdDatabase (<o:p></o:p></p>
<p class="MsoPlainText">> //<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> Index = (mPcdDatabase.DxeDb->Length + 7) & (~7);<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> SkuDelta = NULL;<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> +<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> + if (Index == mDxePcdDbSize) {<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> + return EFI_SUCCESS;<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> + }<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> +<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> while (Index < mDxePcdDbSize) {<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> SkuDelta = (PCD_DATABASE_SKU_DELTA *)((UINT8 *)mDxePcdDbBinary<o:p></o:p></p>
<p class="MsoPlainText">> + Index);<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> if ((SkuDelta->SkuId == SkuId) && (SkuDelta->SkuIdCompared == 0))
<o:p></o:p></p>
<p class="MsoPlainText">> {<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> --<o:p></o:p></p>
<p class="MsoPlainText">> 2.31.1.windows.1<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> -=-=-=-=-=-=<o:p></o:p></p>
<p class="MsoPlainText">> Groups.io Links: You receive all messages sent to this group.<o:p></o:p></p>
<p class="MsoPlainText">> View/Reply Online (#89557): <o:p></o:p></p>
<p class="MsoPlainText">> <a href="https://edk2.groups.io/g/devel/message/89557">
<span style="color:windowtext;text-decoration:none">https://edk2.groups.io/g/devel/message/89557</span></a><o:p></o:p></p>
<p class="MsoPlainText">> Mute This Topic: <a href="https://groups.io/mt/90934230/4905953">
<span style="color:windowtext;text-decoration:none">https://groups.io/mt/90934230/4905953</span></a><o:p></o:p></p>
<p class="MsoPlainText">> Group Owner: <a href="mailto:devel+owner@edk2.groups.io">
<span style="color:windowtext;text-decoration:none">devel+owner@edk2.groups.io</span></a><o:p></o:p></p>
<p class="MsoPlainText">> Unsubscribe: <a href="https://edk2.groups.io/g/devel/unsub">
<span style="color:windowtext;text-decoration:none">https://edk2.groups.io/g/devel/unsub</span></a><o:p></o:p></p>
<p class="MsoPlainText">> [gaoliming@byosoft.com.cn]<o:p></o:p></p>
<p class="MsoPlainText">> -=-=-=-=-=-=<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/89619">View/Reply Online (#89619)</a> | | <a target="_blank" href="https://groups.io/mt/90994444/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>