<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style></style></head><body lang=ZH-CN link=blue vlink=purple style='word-wrap:break-word'><div class=WordSection1><p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:等线'>Pedro</span><span style='font-size:11.0pt;font-family:等线'>：<span lang=EN-US><o:p></o:p></span></span></p><p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:等线'> Thanks for your enhancement to support ext2/3 file system. Acked-by: Liming Gao <gaoliming@byosoft.com.cn> for this patch set. <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:等线'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:等线'>Thanks<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:等线'>Liming</span><span lang=EN-US style='font-size:10.5pt;font-family:等线'><o:p></o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span style='font-size:11.0pt;font-family:等线'>发件人<span lang=EN-US>:</span></span></b><span lang=EN-US style='font-size:11.0pt;font-family:等线'> Pedro Falcato <pedro.falcato@gmail.com> <br></span><b><span style='font-size:11.0pt;font-family:等线'>发送时间<span lang=EN-US>:</span></span></b><span lang=EN-US style='font-size:11.0pt;font-family:等线'> 2022</span><span style='font-size:11.0pt;font-family:等线'>年<span lang=EN-US>6</span>月<span lang=EN-US>1</span>日<span lang=EN-US> 5:33<br></span><b>收件人<span lang=EN-US>:</span></b><span lang=EN-US> edk2-devel-groups-io <devel@edk2.groups.io>; Pedro Falcato <pedro.falcato@gmail.com><br></span><b>抄送<span lang=EN-US>:</span></b><span lang=EN-US> Leif Lindholm <leif@nuviainc.com>; Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com><br></span><b>主题<span lang=EN-US>:</span></b><span lang=EN-US> Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib<o:p></o:p></span></span></p></div></div><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><div><p class=MsoNormal><span lang=EN-US>Ping. Please review now that the stable freeze is over.<o:p></o:p></span></p></div><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><div><div><p class=MsoNormal><span lang=EN-US>On Wed, May 11, 2022 at 6:42 PM Pedro Falcato via <a href="http://groups.io">groups.io</a> <pedro.falcato=<a href="mailto:gmail.com@groups.io">gmail.com@groups.io</a>> wrote:<o:p></o:p></span></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><div><p class=MsoNormal><span lang=EN-US>Ping. Could someone review these patches?<o:p></o:p></span></p></div><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><div><div><p class=MsoNormal><span lang=EN-US>On Mon, Apr 25, 2022 at 6:14 PM Pedro Falcato via <a href="http://groups.io" target="_blank">groups.io</a> <pedro.falcato=<a href="mailto:gmail.com@groups.io" target="_blank">gmail.com@groups.io</a>> wrote:<o:p></o:p></span></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><div><p class=MsoNormal><span lang=EN-US>Ping. If someone could take a look, it would be much appreciated.<o:p></o:p></span></p></div><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><div><div><p class=MsoNormal><span lang=EN-US>On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato <<a href="mailto:pedro.falcato@gmail.com" target="_blank">pedro.falcato@gmail.com</a>> wrote:<o:p></o:p></span></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><p class=MsoNormal style='margin-bottom:12.0pt'><span lang=EN-US>BZ: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=3745" target="_blank">https://bugzilla.tianocore.org/show_bug.cgi?id=3745</a><br>BZ: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=3871" target="_blank">https://bugzilla.tianocore.org/show_bug.cgi?id=3871</a><br><br>Hi all,<br><br>This patch-set attempts to address two open feature requests for Ext4Pkg<br>by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to BaseLib (id 3871).<br><br>The previous patch-set regarding 3871 attempted to merge the different crc16 implementations<br>but failed because, contrary to what I thought, there are many, many different CRC16s which<br>are all slightly different. This one (plus the separate edk2 patch) attempts to just merge<br>CRC16-ANSI (confusingly, also known as CRC16) into BaseLib.<br><br>Since this patch set grew to be considerably different from the original, I didn't mark it<br>as v2 but rather a separate, new patch-set.<br><br>CC'ing the edk2-platforms stewards (as I cannot review my own code) and the CC's of the MdePkg<br>patch.<br><br>Cc: Leif Lindholm <<a href="mailto:leif@nuviainc.com" target="_blank">leif@nuviainc.com</a>><br>Cc: Michael D Kinney <<a href="mailto:michael.d.kinney@intel.com" target="_blank">michael.d.kinney@intel.com</a>><br>Cc: Liming Gao <<a href="mailto:gaoliming@byosoft.com.cn" target="_blank">gaoliming@byosoft.com.cn</a>><br>Cc: Zhiguang Liu <<a href="mailto:zhiguang.liu@intel.com" target="_blank">zhiguang.liu@intel.com</a>><br><br>Pedro Falcato (3):<br> Ext4Pkg: Replace the CRC implementations with BaseLib<br> Ext4Pkg: Format using uncrustify<br> Ext4Pkg: Add ext2/3 support<br><br> Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 10 +-<br> Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 279 +++++++++++++++++<br> Features/Ext4Pkg/Ext4Dxe/Collation.c | 4 +-<br> Features/Ext4Pkg/Ext4Dxe/Crc16.c | 75 -----<br> Features/Ext4Pkg/Ext4Dxe/Crc32c.c | 84 ------<br> Features/Ext4Pkg/Ext4Dxe/Directory.c | 13 +-<br> Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 6 +-<br> Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 30 +-<br> Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 95 +++---<br> Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 417 ++++++++++++++------------<br> Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 3 +-<br> Features/Ext4Pkg/Ext4Dxe/Extents.c | 27 +-<br> Features/Ext4Pkg/Ext4Dxe/File.c | 19 +-<br> Features/Ext4Pkg/Ext4Dxe/Inode.c | 33 +-<br> Features/Ext4Pkg/Ext4Dxe/Partition.c | 12 +-<br> Features/Ext4Pkg/Ext4Dxe/Superblock.c | 20 +-<br> 16 files changed, 640 insertions(+), 487 deletions(-)<br> create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c<br> delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c<br> delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c<br><br>-- <br>2.35.1<o:p></o:p></span></p></blockquote></div><p class=MsoNormal><span lang=EN-US><br clear=all><br>-- <o:p></o:p></span></p><div><div><p class=MsoNormal><span lang=EN-US>Pedro Falcato<o:p></o:p></span></p></div></div></blockquote></div><p class=MsoNormal><span lang=EN-US><br clear=all><br>-- <o:p></o:p></span></p><div><div><p class=MsoNormal><span lang=EN-US>Pedro Falcato<o:p></o:p></span></p></div></div><div><p class=MsoNormal></o:p></span></p></div></blockquote></div><p class=MsoNormal><span lang=EN-US><br clear=all><br>-- <o:p></o:p></span></p><div><div><p class=MsoNormal><span lang=EN-US>Pedro Falcato<o:p></o:p></span></p></div></div></div></div></body></html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/90134">View/Reply Online (#90134)</a> | | <a target="_blank" href="https://groups.io/mt/91492554/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>