<div dir="auto">Hi Sean,<div dir="auto"><br></div><div dir="auto">I think it's clear from the wording that the 38.2% thing is a recommendation and not mandatory. I was curious and checked out the ACPI spec and they appear to not mention that at all. Maybe reword things to "Microsoft recommendation"?</div><div dir="auto"><br></div><div dir="auto">Thanks,</div><div dir="auto">Pedro</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 5 Aug 2022, 07:55 Sean Rhodes, <sean@starlabs.systems> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">Hi Liming</div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif"><br></div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">Microsoft details about positioning can be found here: <a href="https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-screen-components" target="_blank" rel="noreferrer">https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-screen-components</a></div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif"><br></div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">Thanks</div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif"><br></div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">Sean</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 5 Aug 2022 at 07:00, gaoliming via <a href="http://groups.io" target="_blank" rel="noreferrer">groups.io</a> <gaoliming=<a href="mailto:byosoft.com.cn@groups.io" target="_blank" rel="noreferrer">byosoft.com.cn@groups.io</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Sean:<br> Can you give BGRT spec link? I want to check the spec description. <br> <br> Thanks<br> Liming<br> > -----邮件原件-----<br> > 发件人: <a href="mailto:devel@edk2.groups.io" target="_blank" rel="noreferrer">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank" rel="noreferrer">devel@edk2.groups.io</a>> 代表 Sean Rhodes<br> > 发送时间: 2022年7月26日 16:15<br> > 收件人: <a href="mailto:devel@edk2.groups.io" target="_blank" rel="noreferrer">devel@edk2.groups.io</a><br> > 抄送: Sean Rhodes <sean@starlabs.systems>; Zhichao Gao<br> > <<a href="mailto:zhichao.gao@intel.com" target="_blank" rel="noreferrer">zhichao.gao@intel.com</a>>; Ray Ni <<a href="mailto:ray.ni@intel.com" target="_blank" rel="noreferrer">ray.ni@intel.com</a>>; Jian J Wang<br> > <<a href="mailto:jian.j.wang@intel.com" target="_blank" rel="noreferrer">jian.j.wang@intel.com</a>>; Liming Gao <<a href="mailto:gaoliming@byosoft.com.cn" target="_blank" rel="noreferrer">gaoliming@byosoft.com.cn</a>><br> > 主题: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to<br> > follow BGRT specification<br> > <br> > Add an option to position the logo 38.2% from the top of the screen,<br> > which follows the BGRT specification.<br> > <br> > Cc: Zhichao Gao <<a href="mailto:zhichao.gao@intel.com" target="_blank" rel="noreferrer">zhichao.gao@intel.com</a>><br> > Cc: Ray Ni <<a href="mailto:ray.ni@intel.com" target="_blank" rel="noreferrer">ray.ni@intel.com</a>><br> > Cc: Jian J Wang <<a href="mailto:jian.j.wang@intel.com" target="_blank" rel="noreferrer">jian.j.wang@intel.com</a>><br> > Cc: Liming Gao <<a href="mailto:gaoliming@byosoft.com.cn" target="_blank" rel="noreferrer">gaoliming@byosoft.com.cn</a>><br> > Signed-off-by: Sean Rhodes <sean@starlabs.systems><br> > ---<br> > MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++-<br> > MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ++++---<br> > 2 files changed, 6 insertions(+), 4 deletions(-)<br> > <br> > diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h<br> > b/MdeModulePkg/Include/Protocol/PlatformLogo.h<br> > index 08e1dc35a4..7c9ef63c66 100644<br> > --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h<br> > +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h<br> > @@ -29,7 +29,8 @@ typedef enum {<br> > EdkiiPlatformLogoDisplayAttributeCenterBottom,<br> > <br> > EdkiiPlatformLogoDisplayAttributeLeftBottom,<br> > <br> > EdkiiPlatformLogoDisplayAttributeCenterLeft,<br> > <br> > - EdkiiPlatformLogoDisplayAttributeCenter<br> > <br> > + EdkiiPlatformLogoDisplayAttributeCenter,<br> > <br> > + EdkiiPlatformLogoDisplayAttributeBGRTSpecification<br> > <br> > } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;<br> > <br> > <br> > <br> > /**<br> > <br> > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c<br> > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c<br> > index 478ec2d40e..ac086f9c79 100644<br> > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c<br> > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c<br> > @@ -169,7 +169,6 @@ BootLogoEnableLogo (<br> > DestX = SizeOfX - Image.Width;<br> > <br> > DestY = 0;<br> > <br> > break;<br> > <br> > -<br> > <br> > case EdkiiPlatformLogoDisplayAttributeCenterLeft:<br> > <br> > DestX = 0;<br> > <br> > DestY = (SizeOfY - Image.Height) / 2;<br> > <br> > @@ -182,7 +181,6 @@ BootLogoEnableLogo (<br> > DestX = SizeOfX - Image.Width;<br> > <br> > DestY = (SizeOfY - Image.Height) / 2;<br> > <br> > break;<br> > <br> > -<br> > <br> > case EdkiiPlatformLogoDisplayAttributeLeftBottom:<br> > <br> > DestX = 0;<br> > <br> > DestY = SizeOfY - Image.Height;<br> > <br> > @@ -195,7 +193,10 @@ BootLogoEnableLogo (<br> > DestX = SizeOfX - Image.Width;<br> > <br> > DestY = SizeOfY - Image.Height;<br> > <br> > break;<br> > <br> > -<br> > <br> > + case EdkiiPlatformLogoDisplayAttributeBGRTSpecification:<br> > <br> > + DestX = (SizeOfX - Image.Width) / 2;<br> > <br> > + DestY = (SizeOfY * 382) / 1000 - Image.Height / 2;<br> > <br> > + break;<br> > <br> > default:<br> > <br> > ASSERT (FALSE);<br> > <br> > continue;<br> > <br> > --<br> > 2.34.1<br> > <br> > <br> > <br> > -=-=-=-=-=-=<br> > Groups.io Links: You receive all messages sent to this group.<br> > View/Reply Online (#91842): <a href="https://edk2.groups.io/g/devel/message/91842" rel="noreferrer noreferrer" target="_blank">https://edk2.groups.io/g/devel/message/91842</a><br> > Mute This Topic: <a href="https://groups.io/mt/92623125/4905953" rel="noreferrer noreferrer" target="_blank">https://groups.io/mt/92623125/4905953</a><br> > Group Owner: <a href="mailto:devel%2Bowner@edk2.groups.io" target="_blank" rel="noreferrer">devel+owner@edk2.groups.io</a><br> > Unsubscribe: <a href="https://edk2.groups.io/g/devel/unsub" rel="noreferrer noreferrer" target="_blank">https://edk2.groups.io/g/devel/unsub</a><br> > [<a href="mailto:gaoliming@byosoft.com.cn" target="_blank" rel="noreferrer">gaoliming@byosoft.com.cn</a>]<br> > -=-=-=-=-=-=<br> > <br> <br> <br> <br> <br> <br> <br> <br> <br> </blockquote></div> </p></p></blockquote></div> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/92155">View/Reply Online (#92155)</a> | | <a target="_blank" href="https://groups.io/mt/92830609/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>