<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> <p class="MsoNormal">This seems a big incompatible change.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">I feel this is weird to hardcode the configuration here.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">How the OVMF binary knows it runs on a new CloudHv or old CloudHv?<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Can we have a mechanism to detect the data at runtime? E.g. read some PCI register ?<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Boeuf, Sebastien <sebastien.boeuf@intel.com> <br> <b>Sent:</b> Tuesday, September 6, 2022 10:08 PM<br> <b>To:</b> Yao, Jiewen <jiewen.yao@intel.com><br> <b>Cc:</b> Justen, Jordan L <jordan.l.justen@intel.com>; kraxel@redhat.com; devel@edk2.groups.io<br> <b>Subject:</b> Re: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">Hi Jiewen,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">Do you think this could be merged?<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">Thanks,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">Sebastien<o:p></o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> <p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Boeuf, Sebastien <<a href="mailto:sebastien.boeuf@intel.com">sebastien.boeuf@intel.com</a>><br> <b>Sent:</b> Friday, August 19, 2022 11:59 AM<br> <b>To:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>><br> <b>Cc:</b> Yao, Jiewen <<a href="mailto:jiewen.yao@intel.com">jiewen.yao@intel.com</a>>; Justen, Jordan L <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>>; <a href="mailto:kraxel@redhat.com">kraxel@redhat.com</a> <<a href="mailto:kraxel@redhat.com">kraxel@redhat.com</a>>; Boeuf, Sebastien <<a href="mailto:sebastien.boeuf@intel.com">sebastien.boeuf@intel.com</a>><br> <b>Subject:</b> [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv</span> <o:p></o:p></p> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt">From: Sebastien Boeuf <<a href="mailto:sebastien.boeuf@intel.com">sebastien.boeuf@intel.com</a>><br> <br> Both ACPI shutdown and ACPI PM timer devices has been moved to different<br> port addresses in the latest version of Cloud Hypervisor. These changes<br> need to be reflected on the OVMF firmware.<br> <br> Acked-by: Gerd Hoffmann <<a href="mailto:kraxel@redhat.com">kraxel@redhat.com</a>><br> Signed-off-by: Sebastien Boeuf <<a href="mailto:sebastien.boeuf@intel.com">sebastien.boeuf@intel.com</a>><br> ---<br> OvmfPkg/Include/IndustryStandard/CloudHv.h | 4 ++--<br> 1 file changed, 2 insertions(+), 2 deletions(-)<br> <br> diff --git a/OvmfPkg/Include/IndustryStandard/CloudHv.h b/OvmfPkg/Include/IndustryStandard/CloudHv.h<br> index d31ecc9eec..527c236f48 100644<br> --- a/OvmfPkg/Include/IndustryStandard/CloudHv.h<br> +++ b/OvmfPkg/Include/IndustryStandard/CloudHv.h<br> @@ -16,12 +16,12 @@<br> //<br> <br> // ACPI timer address<br> <br> //<br> <br> -#define CLOUDHV_ACPI_TIMER_IO_ADDRESS 0xb008<br> <br> +#define CLOUDHV_ACPI_TIMER_IO_ADDRESS 0x0608<br> <br> <br> <br> //<br> <br> // ACPI shutdown device address<br> <br> //<br> <br> -#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS 0x03c0<br> <br> +#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS 0x0600<br> <br> <br> <br> //<br> <br> // 32-bit MMIO memory hole base address<br> <br> -- <br> 2.34.1<o:p></o:p></p> </div> </div> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/93228">View/Reply Online (#93228)</a> | | <a target="_blank" href="https://groups.io/mt/93121228/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>