<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> I have concern for this patch.<o:p></o:p> <o:p> </o:p> It will make the implementation of XhcControlTransfer() no longer following the UEFI specification requirements on the EFI_USB2_HC_PROTOCOL.ControlTransfer() service:<o:p></o:p> <o:p> </o:p> Section 17.1.7 of UEFI spec Release 2.10:<o:p></o:p> EFI_INVALID_PARAMETER is returned if one of the following conditions is satisfied:<o:p></o:p> ...<o:p></o:p> • MaximumPacketLength is not valid. If DeviceSpeed is EFI_USB_SPEED_LOW, then MaximumPacketLength<o:p></o:p> must be 8. If DeviceSpeed is EFI_USB_SPEED_FULL or EFI_USB_SPEED_HIGH, then MaximumPac-<o:p></o:p> ketLength must be 8, 16, 32, or 64. If DeviceSpeed is EFI_USB_SPEED_SUPER, then MaximumPacketLength<o:p></o:p> must be 512.<o:p></o:p> <o:p> </o:p> My take is that it will need a UEFI spec update to integrate this proposed change.<o:p></o:p> Sorry Liming, could you help on the process of raising opens with regard to the UEFI specification? Thanks in advance.<o:p></o:p> <o:p> </o:p> Best Regards,<o:p></o:p> Hao Wu<o:p></o:p> <o:p> </o:p> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean > Rhodes > Sent: Monday, December 5, 2022 5:18 PM > To: devel@edk2.groups.io > Cc: Rhodes, Sean <sean@starlabs.systems>; Wu, Hao A > <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com> > Subject: [edk2-devel] [PATCH 4/4] MdeModulePkg/UsbBusDxe: Adjust the > MaxPacketLength to real world values > > Adjusts the requirements for the MaxPacketLength to match what is seen on > real world devices that do not follow the USB specification. > > This fixes enumeration on the multiple USB 3 devices made by SanDisk, > Integral, Kingston and other generic brands. > > Cc: Hao A Wu <<a href="mailto:hao.a.wu@intel.com">hao.a.wu@intel.com</a>> > Cc: Ray Ni <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>> > Signed-off-by: Sean Rhodes <<a href="mailto:sean@starlabs.systems">sean@starlabs.systems</a>> > --- > MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > index 62535cad54..043b7d4cea 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > @@ -906,19 +906,16 @@ XhcControlTransfer ( > return EFI_INVALID_PARAMETER; > > } > > > > - if ((MaximumPacketLength != 8) && (MaximumPacketLength != 16) && > > - (MaximumPacketLength != 32) && (MaximumPacketLength != 64) && > > - (MaximumPacketLength != 512) > > - ) > > - { > > + // Check for valid maximum packet size > > + if ((DeviceSpeed == EFI_USB_SPEED_SUPER) && (MaximumPacketLength > > 1024)) { > > return EFI_INVALID_PARAMETER; > > } > > > > - if ((DeviceSpeed == EFI_USB_SPEED_LOW) && (MaximumPacketLength != > 8)) { > > + if ((DeviceSpeed == EFI_USB_SPEED_HIGH) && (MaximumPacketLength > > 512)) { > > return EFI_INVALID_PARAMETER; > > } > > > > - if ((DeviceSpeed == EFI_USB_SPEED_SUPER) && (MaximumPacketLength != > 512)) { > > + if ((DeviceSpeed == EFI_USB_SPEED_FULL) && (MaximumPacketLength > > 64)) { > > return EFI_INVALID_PARAMETER; > > } > > > > -- > 2.37.2 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#96951): <a href="https://edk2.groups.io/g/devel/message/96951"> https://edk2.groups.io/g/devel/message/96951</a> > Mute This Topic: <a href="https://groups.io/mt/95465401/1768737"> https://groups.io/mt/95465401/1768737</a> > Group Owner: <a href="mailto:devel+owner@edk2.groups.io"> devel+owner@edk2.groups.io</a> > Unsubscribe: <a href="https://edk2.groups.io/g/devel/unsub"> https://edk2.groups.io/g/devel/unsub</a> [hao.a.wu@intel.com] > -=-=-=-=-=-= > <o:p> </o:p> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/97060">View/Reply Online (#97060)</a> | | <a target="_blank" href="https://groups.io/mt/95465401/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>