<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:等线;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Trebuchet MS";
panose-1:2 11 6 3 2 2 2 2 2 4;}
@font-face
{font-family:"\@等线";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Pushed via:<o:p></o:p></p>
<p class="MsoNormal">PR - <a href="https://github.com/tianocore/edk2/pull/3848">https://github.com/tianocore/edk2/pull/3848</a><o:p></o:p></p>
<p class="MsoNormal">Commit - <a href="https://github.com/tianocore/edk2/commit/992d5451d19b93635d52db293bab680e32142776">
https://github.com/tianocore/edk2/commit/992d5451d19b93635d52db293bab680e32142776</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Best Regards,<o:p></o:p></p>
<p class="MsoNormal">Hao Wu<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b>From:</b> devel@edk2.groups.io <devel@edk2.groups.io> <b>
On Behalf Of </b>Wu, Hao A<br>
<b>Sent:</b> Tuesday, January 3, 2023 9:25 AM<br>
<b>To:</b> Rhodes, Sean <sean@starlabs.systems>; devel@edk2.groups.io<br>
<b>Subject:</b> Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Reset the port if status change returns an error<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Reviewed-by: Hao A Wu <<a href="mailto:hao.a.wu@intel.com">hao.a.wu@intel.com</a>><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Best Regards,<o:p></o:p></p>
<p class="MsoNormal">Hao Wu<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b>From:</b> Sean Rhodes <<a href="mailto:sean@starlabs.systems">sean@starlabs.systems</a>>
<br>
<b>Sent:</b> Friday, December 23, 2022 6:22 PM<br>
<b>To:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; Wu, Hao A <<a href="mailto:hao.a.wu@intel.com">hao.a.wu@intel.com</a>><br>
<b>Subject:</b> Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Reset the port if status change returns an error<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal"><span style="font-family:"Trebuchet MS",sans-serif">Hi Hao<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Trebuchet MS",sans-serif"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Trebuchet MS",sans-serif">This PR has passed CI - </span><a href="https://github.com/tianocore/edk2/pull/3353"><span style="font-family:"Trebuchet MS",sans-serif">https://github.com/tianocore/edk2/pull/3353</span></a><span style="font-family:"Trebuchet MS",sans-serif"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Trebuchet MS",sans-serif"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Trebuchet MS",sans-serif">Thanks<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Trebuchet MS",sans-serif"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Trebuchet MS",sans-serif">Sean<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Fri, 23 Dec 2022 at 08:56, Wu, Hao A <<a href="mailto:hao.a.wu@intel.com">hao.a.wu@intel.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-bottom:12.0pt">Sorry,<br>
<br>
The CI tests failed for the proposed patch:<br>
<a href="https://github.com/tianocore/edk2/pull/3824" target="_blank">https://github.com/tianocore/edk2/pull/3824</a><br>
<br>
Could you help to check and resolve? Thanks.<br>
<br>
Best Regards,<br>
Hao Wu<br>
<br>
> -----Original Message-----<br>
> From: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>> On Behalf Of Sean<br>
> Rhodes<br>
> Sent: Wednesday, December 21, 2022 4:15 PM<br>
> To: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a><br>
> Cc: Rhodes, Sean <<a href="mailto:sean@starlabs.systems">sean@starlabs.systems</a>><br>
> Subject: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Reset the<br>
> port if status change returns an error<br>
> <br>
> Force resetting the port by clearing the USB_PORT_STAT_C_RESET bit in<br>
> PortChangeStatus<br>
> when XhcPollPortStatusChange fails<br>
> <br>
> Signed-off-by: Sean Rhodes <<a href="mailto:sean@starlabs.systems">sean@starlabs.systems</a>><br>
> ---<br>
> MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 11 ++++++++++-<br>
> 1 file changed, 10 insertions(+), 1 deletion(-)<br>
> <br>
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c<br>
> b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c<br>
> index 461b2cd9b5..d8fa41f68f 100644<br>
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c<br>
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c<br>
> @@ -471,7 +471,16 @@ XhcGetRootHubPortStatus (<br>
> // For those devices behind hub, we get its attach/detach event by hooking<br>
> Get_Port_Status request at control transfer for those hub.<br>
> <br>
> //<br>
> <br>
> ParentRouteChart.Dword = 0;<br>
> <br>
> - XhcPollPortStatusChange (Xhc, ParentRouteChart, PortNumber, PortStatus);<br>
> <br>
> + Status = XhcPollPortStatusChange (Xhc, ParentRouteChart,<br>
> PortNumber, PortStatus);<br>
> <br>
> +<br>
> <br>
> + //<br>
> <br>
> + // Force resetting the port by clearing the USB_PORT_STAT_C_RESET bit in<br>
> PortChangeStatus<br>
> <br>
> + // when XhcPollPortStatusChange fails<br>
> <br>
> + //<br>
> <br>
> + if (EFI_ERROR (Status)) {<br>
> <br>
> + PortStatus->PortChangeStatus &= ~(USB_PORT_STAT_C_RESET);<br>
> <br>
> + Status = EFI_SUCCESS;<br>
> <br>
> + }<br>
> <br>
> <br>
> <br>
> ON_EXIT:<br>
> <br>
> gBS->RestoreTPL (OldTpl);<br>
> <br>
> --<br>
> 2.37.2<br>
> <br>
> <br>
> <br>
> -=-=-=-=-=-=<br>
> Groups.io Links: You receive all messages sent to this group.<br>
> View/Reply Online (#97683): <a href="https://edk2.groups.io/g/devel/message/97683" target="_blank">
https://edk2.groups.io/g/devel/message/97683</a><br>
> Mute This Topic: <a href="https://groups.io/mt/95802798/1768737" target="_blank">
https://groups.io/mt/95802798/1768737</a><br>
> Group Owner: <a href="mailto:devel%2Bowner@edk2.groups.io" target="_blank">devel+owner@edk2.groups.io</a><br>
> Unsubscribe: <a href="https://edk2.groups.io/g/devel/unsub" target="_blank">https://edk2.groups.io/g/devel/unsub</a> [<a href="mailto:hao.a.wu@intel.com" target="_blank">hao.a.wu@intel.com</a>]<br>
> -=-=-=-=-=-=<br>
> <br>
<br>
<br>
<br>
<br>
<o:p></o:p></p>
</blockquote>
</div>
</div>
<div>
<p class="MsoNormal"></o:p></span></p>
</div>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/97904">View/Reply Online (#97904)</a> |
|
<a target="_blank" href="https://groups.io/mt/95802798/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>