<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:PMingLiU;
panose-1:2 1 6 1 0 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:-apple-system;
panose-1:0 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"\@PMingLiU";
panose-1:2 1 6 1 0 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:Consolas;
mso-fareast-language:ZH-CN;}
span.EmailStyle24
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-CN" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt">Hi, <a id="OWAAM8B4189AE47E14BE1A029F7C740BDECBF" href="mailto:james.lu@intel.com">
<span style="font-family:"Calibri",sans-serif;text-decoration:none">@Lu, James</span></a>
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt">will you please check if the code change make sense then merge the pr?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt">I have already fix the commit message, and create the PR.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://github.com/tianocore/edk2/pull/3868">UefiPayloadPkg: Fix debug print error level hob not save correct by NingFengGit · Pull Request #3868 · tianocore/edk2 (github.com)</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt">Thank you!<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Guo, Gua <gua.guo@intel.com>
<br>
<b>Sent:</b> Monday, January 9, 2023 1:07 PM<br>
<b>To:</b> Feng, Ning <ning.feng@intel.com>; devel@edk2.groups.io; Lu, James <james.lu@intel.com><br>
<b>Cc:</b> Guo, Dong <dong.guo@intel.com>; Ni, Ray <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems><br>
<b>Subject:</b> RE: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW"><a id="OWAAM63275DAF13CD45C39808C6A31216650C" href="mailto:james.lu@intel.com"><span style="font-family:"Calibri",sans-serif;text-decoration:none">@Lu, James</span></a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW">I may need to get your help to add push label for the PR.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW">Gua<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Feng, Ning <<a href="mailto:ning.feng@intel.com">ning.feng@intel.com</a>>
<br>
<b>Sent:</b> Monday, January 9, 2023 1:04 PM<br>
<b>To:</b> Guo, Gua <<a href="mailto:gua.guo@intel.com">gua.guo@intel.com</a>>; <a href="mailto:devel@edk2.groups.io">
devel@edk2.groups.io</a><br>
<b>Cc:</b> Lu, James <<a href="mailto:james.lu@intel.com">james.lu@intel.com</a>>; Guo, Dong <<a href="mailto:dong.guo@intel.com">dong.guo@intel.com</a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>>; Rhodes, Sean <<a href="mailto:sean@starlabs.systems">sean@starlabs.systems</a>><br>
<b>Subject:</b> RE: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt">Hi, <a id="OWAAMCEF96A68362248539772FCCE24505A5A" href="mailto:gua.guo@intel.com">
<span style="font-family:"Calibri",sans-serif;text-decoration:none">@Guo, Gua</span></a>,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt">Thanks for the review.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt">I have already fix the commit message, and create the PR.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://github.com/tianocore/edk2/pull/3868">UefiPayloadPkg: Fix debug print error level hob not save correct by NingFengGit · Pull Request #3868 · tianocore/edk2 (github.com)</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Ning</span><span lang="EN-US" style="font-size:10.5pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Guo, Gua <<a href="mailto:gua.guo@intel.com">gua.guo@intel.com</a>>
<br>
<b>Sent:</b> Monday, January 9, 2023 9:58 AM<br>
<b>To:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; Feng, Ning <<a href="mailto:ning.feng@intel.com">ning.feng@intel.com</a>><br>
<b>Cc:</b> Lu, James <<a href="mailto:james.lu@intel.com">james.lu@intel.com</a>>; Guo, Dong <<a href="mailto:dong.guo@intel.com">dong.guo@intel.com</a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>>; Rhodes, Sean <<a href="mailto:sean@starlabs.systems">sean@starlabs.systems</a>><br>
<b>Subject:</b> RE: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW"><a id="OWAAM6ABD267766CF40E79F7C1A074D11B308" href="mailto:ning.feng@intel.com"><span style="font-family:"Calibri",sans-serif;text-decoration:none">@Feng, Ning</span></a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW">Could you send Edk2 PR ? we can check in it.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW"><a href="https://github.com/tianocore/edk2/pulls">https://github.com/tianocore/edk2/pulls</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW">And please also change commit message like below<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW">“””<o:p></o:p></span></p>
<p class="MsoPlainText" style="margin-bottom:12.0pt"><span lang="EN-US" style="font-size:12.0pt;font-family:"-apple-system",serif;color:black">UefiPayloadPkg: Fix debug print error level hob not save correct</span><span lang="EN-US"><br>
<br>
REF: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=4264">https://bugzilla.tianocore.org/show_bug.cgi?id=4264</a><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Fix debug print error level hob not save correct
</span><span lang="EN-US" style="mso-fareast-language:ZH-TW">D</span><span lang="EN-US">e</span><span lang="EN-US" style="mso-fareast-language:ZH-TW">b</span><span lang="EN-US">ugPrintErrorlevel<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US" style="mso-fareast-language:ZH-TW">S</span><span lang="EN-US">hould cover the case:<br>
Header.Length == UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:6.0pt"><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black">Cc: Ray Ni
</span><span lang="EN-US" style="font-size:10.0pt;font-family:"PMingLiU",serif;color:black;mso-fareast-language:ZH-TW"><</span><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black"><a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a></span><span lang="EN-US" style="font-size:10.0pt;font-family:"PMingLiU",serif;mso-fareast-language:ZH-TW">></span><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:6.0pt"><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black">Cc: Sean Rhodes
</span><span lang="EN-US" style="font-size:10.0pt;font-family:"PMingLiU",serif;color:black;mso-fareast-language:ZH-TW"><</span><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black"><a href="mailto:sean@starlabs.systems">sean@starlabs.systems</a></span><span lang="EN-US" style="font-size:10.0pt;font-family:"PMingLiU",serif;mso-fareast-language:ZH-TW">></span><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:6.0pt"><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black">Cc: James Lu
</span><span lang="EN-US" style="font-size:10.0pt;font-family:"PMingLiU",serif;color:black;mso-fareast-language:ZH-TW"><</span><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black"><a href="mailto:james.lu@intel.com">james.lu@intel.com</a></span><span lang="EN-US" style="font-size:10.0pt;font-family:"PMingLiU",serif;mso-fareast-language:ZH-TW">></span><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:6.0pt"><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black">Cc: Gua Guo
</span><span lang="EN-US" style="font-size:10.0pt;font-family:"PMingLiU",serif;color:black;mso-fareast-language:ZH-TW"><</span><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black"><a href="mailto:gua.guo@intel.com">gua.guo@intel.com</a></span><span lang="EN-US" style="font-size:10.0pt;font-family:"PMingLiU",serif;mso-fareast-language:ZH-TW">></span><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas"><br>
</span><span lang="EN-US">Signed-off-by: Ning Feng <<a href="mailto:ning.feng@intel.com">ning.feng@intel.com</a>></span><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.0pt;font-family:"PMingLiU",serif;color:black;mso-fareast-language:ZH-TW">Reviewed-by</span><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black">: Gua Guo
</span><span lang="EN-US" style="font-size:10.0pt;font-family:"PMingLiU",serif;color:black;mso-fareast-language:ZH-TW"><</span><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas;color:black"><a href="mailto:gua.guo@intel.com">gua.guo@intel.com</a></span><span lang="EN-US" style="font-size:10.0pt;font-family:"PMingLiU",serif;mso-fareast-language:ZH-TW">></span><span lang="EN-US" style="font-size:10.0pt;font-family:Consolas"><br>
</span><span lang="EN-US" style="mso-fareast-language:ZH-TW">“””<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:ZH-TW"><br>
Reviewed-by: Gua Guo <<a href="mailto:gua.guo@intel.com">gua.guo@intel.com</a>> <o:p>
</o:p></span></p>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> <a href="mailto:devel@edk2.groups.io">
devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>
<b>On Behalf Of </b>Ning Feng<br>
<b>Sent:</b> Monday, January 9, 2023 9:44 AM<br>
<b>To:</b> Feng, Ning <<a href="mailto:ning.feng@intel.com">ning.feng@intel.com</a>>;
<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a><br>
<b>Subject:</b> Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">fix debug print error level hob not save correct debugprinterrorlevel<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">should cover the case:<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Header.Lenth ==UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Change-Id: Ibebe29fe8057e24448b31a8caa7ab6eb8054c39b<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">BugZilla: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=4264">
https://bugzilla.tianocore.org/show_bug.cgi?id=4264</a><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Signed-off-by: Ning Feng <<a href="mailto:ning.feng@intel.com">ning.feng@intel.com</a>><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">---<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"> .../DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c | 2 +-<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"> 1 file changed, 1 insertion(+), 1 deletion(-)<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">diff --git a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">index 4f6b4ef1fb..10bdbe2bbc 100644<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">--- a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">+++ b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorL<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">+++ evelLibHob.c<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">@@ -46,7 +46,7 @@ GetDebugPrintErrorLevel (<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"> { if (GenericHeader->Revision == UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL_REVISION) { DebugPrintErrorLevel = (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL *)GET_GUID_HOB_DATA (GuidHob);- if (DebugPrintErrorLevel->Header.Length
> UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {+ if (DebugPrintErrorLevel->Header.Length >= UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) { gDebugPrintErrorLevel
= DebugPrintErrorLevel->ErrorLevel; } }-- <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">2.25.1<o:p></o:p></span></p>
<div>
<p class="MsoNormal"></o:p></span></p>
</div>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/98225">View/Reply Online (#98225)</a> |
|
<a target="_blank" href="https://groups.io/mt/96090853/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>