<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=gb2312"> <html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style></style></head><body lang=ZH-CN link=blue vlink=purple style='word-wrap:break-word'><div class=WordSection1><p class=MsoNormal><span lang=EN-US style='font-size:12.0pt;color:black;background:white'>Timothy:<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:DengXian'> Thanks for your report. This is a real issue in Brotli decompress library. Which tool chain has been verified? GCC5 or VS2019 or Both?<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:DengXian'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:DengXian'>Thanks<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:DengXian'>Liming<o:p></o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span style='font-family:DengXian'>发件人<span lang=EN-US>:</span></span></b><span lang=EN-US style='font-family:DengXian'> devel@edk2.groups.io <devel@edk2.groups.io> </span><b><span style='font-family:DengXian'>代表 </span></b><span lang=EN-US style='font-family:DengXian'>Lin, Kuei-Hung (Timothy) via groups.io<br></span><b><span style='font-family:DengXian'>发送时间<span lang=EN-US>:</span></span></b><span lang=EN-US style='font-family:DengXian'> 2023</span><span style='font-family:DengXian'>年<span lang=EN-US>1</span>月<span lang=EN-US>13</span>日<span lang=EN-US> 6:18<br></span><b>收件人<span lang=EN-US>:</span></b><span lang=EN-US> He, Jiangang <Jiangang.He@amd.com>; Chang, Abner <Abner.Chang@amd.com>; Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io<br></span><b>抄送<span lang=EN-US>:</span></b><span lang=EN-US> Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com><br></span><b>主题<span lang=EN-US>:</span></b><span lang=EN-US> Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library<o:p></o:p></span></span></p></div></div><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p style='margin:5.0pt'><span lang=EN-US style='font-size:10.0pt;font-family:"Arial",sans-serif;color:blue'>[AMD Official Use Only - General]<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><div><div><p class=MsoNormal style='background:white'><span class=elementtoproof><span lang=EN-US style='font-size:12.0pt;color:black;background:white'>This patch tried to fix following build failure when linking the Brotli decompress lib.</span></span><span lang=EN-US style='font-size:12.0pt;color:black'><o:p></o:p></span></p></div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;color:black'><o:p> </o:p></span></p></div><div><p class=MsoNormal style='background:white'><span class=elementtoproof><span lang=EN-US style='font-size:12.0pt;color:black;background:white'>Steps to replicate the issue:</span></span><span lang=EN-US style='font-size:12.0pt;color:black'><o:p></o:p></span></p></div><div><p class=MsoNormal style='background:white'><span class=elementtoproof><span lang=EN-US style='font-size:12.0pt;color:black;background:white'>1 - Attach a NULL lib to DxeIpl.inf in any project's .DSC, say OvmfPkgX64.dsc</span></span><span lang=EN-US style='font-size:12.0pt;color:black'><o:p></o:p></span></p></div><div><p class=MsoNormal style='background:white'><span class=elementtoproof><span lang=EN-US style='font-size:12.0pt;font-family:"Courier New";color:black;background:white'> MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {</span></span><span class=elementtoproof><span lang=EN-US style='font-size:12.0pt;color:black;background:white'> </span><span lang=EN-US style='background:white'><o:p></o:p></span></span></p><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;font-family:"Courier New";color:black;background:white'> <LibraryClasses></span><span lang=EN-US><o:p></o:p></span></p></div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;font-family:"Courier New";color:black;background:white'> NULL|MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf</span><span lang=EN-US style='font-size:12.0pt;color:black;background:white'><o:p></o:p></span></p></div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;font-family:"Courier New";color:black;background:white'> }</span><span lang=EN-US style='font-size:12.0pt;color:black;background:white'><o:p></o:p></span></p></div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;color:black;background:white'>2 - Follow the EDKII'2 package build steps to build that project. Build.py would compliains with following errors.<o:p></o:p></span></p></div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;color:black;background:white'>...<o:p></o:p></span></p></div><div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;font-family:"Courier New";color:black;background:white'>/home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/decode.c:879: undefined reference to `_kBrotliPrefixCodeRanges'</span><span lang=EN-US style='font-size:12.0pt;color:black;background:white'><o:p></o:p></span></p></div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;font-family:"Courier New";color:black;background:white'>/usr/bin/ld: /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/decode.c:1193: undefined reference to `_kBrotliContextLookupTable'</span><span lang=EN-US style='font-size:12.0pt;color:black;background:white'><o:p></o:p></span></p></div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;font-family:"Courier New";color:black;background:white'>/usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltrans.o: in function `DecodeCommandBlockSwitch':</span><span lang=EN-US style='font-size:12.0pt;color:black;background:white'><o:p></o:p></span></p></div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;font-family:"Courier New";color:black;background:white'>...</span><span lang=EN-US style='font-size:12.0pt;color:black;background:white'> <o:p></o:p></span></p><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;font-family:"Courier New";color:black;background:white'>/usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltrans.o: in function `BrotliUefiDecompress':</span><span lang=EN-US style='font-size:12.0pt;color:black;background:white'><o:p></o:p></span></p></div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;font-family:"Courier New";color:black;background:white'>/home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/decode.c:898: undefined reference to `_kBrotliPrefixCodeRanges'</span><span lang=EN-US style='font-size:12.0pt;color:black;background:white'><o:p></o:p></span></p></div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;font-family:"Courier New";color:black;background:white'>/usr/bin/ld: /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/decode.c:1193: undefined reference to `_kBrotliContextLookupTable'</span><span lang=EN-US style='font-size:12.0pt;color:black;background:white'><o:p></o:p></span></p></div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;color:black;background:white'><o:p> </o:p></span></p></div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;color:black;background:white'>--<o:p></o:p></span></p></div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;color:black;background:white'>Timothy<o:p></o:p></span></p></div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;color:black'><o:p> </o:p></span></p></div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;color:black'><o:p> </o:p></span></p></div><div><p class=MsoNormal style='background:white'><span lang=EN-US style='font-size:12.0pt;color:black'><o:p> </o:p></span></p></div><div><p class=MsoNormal><span lang=EN-US style='font-size:12.0pt;color:black'><o:p> </o:p></span></p></div><div class=MsoNormal align=center style='text-align:center'><span lang=EN-US><hr size=2 width="98%" align=center></span></div><div id=divRplyFwdMsg><p class=MsoNormal><b><span lang=EN-US style='color:black'>From:</span></b><span lang=EN-US style='color:black'> He, Jiangang <<a href="mailto:Jiangang.He@amd.com">Jiangang.He@amd.com</a>><br><b>Sent:</b> Thursday, January 12, 2023 8:08 AM<br><b>To:</b> Chang, Abner <<a href="mailto:Abner.Chang@amd.com">Abner.Chang@amd.com</a>>; Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>>; <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>; Lin, Kuei-Hung (Timothy) <<a href="mailto:Kuei-Hung.Lin@amd.com">Kuei-Hung.Lin@amd.com</a>><br><b>Cc:</b> Bi, Dandan <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>>; Gao, Liming <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>>; Kirkendall, Garrett <<a href="mailto:Garrett.Kirkendall@amd.com">Garrett.Kirkendall@amd.com</a>>; Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>><br><b>Subject:</b> RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library</span><span lang=EN-US> <o:p></o:p></span></p><div><p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p></div></div><div><p style='margin:5.0pt'><span lang=EN-US style='font-size:10.0pt;font-family:"Arial",sans-serif;color:blue'>[AMD Official Use Only - General]<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><div><div><p class=xmsonormal><span lang=EN-US style='color:#1F497D'>Timothy will answer the question.</span><span lang=EN-US><o:p></o:p></span></p><p class=xmsonormal><span lang=EN-US style='color:#1F497D'> </span><span lang=EN-US><o:p></o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=xmsonormal><b><span lang=EN-US>From:</span></b><span lang=EN-US> Chang, Abner <<a href="mailto:Abner.Chang@amd.com">Abner.Chang@amd.com</a>> <br><b>Sent:</b> Thursday, January 12, 2023 10:05 AM<br><b>To:</b> Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>>; <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a><br><b>Cc:</b> Bi, Dandan <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>>; Gao, Liming <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>>; Kirkendall, Garrett <<a href="mailto:Garrett.Kirkendall@amd.com">Garrett.Kirkendall@amd.com</a>>; Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>>; He, Jiangang <<a href="mailto:Jiangang.He@amd.com">Jiangang.He@amd.com</a>><br><b>Subject:</b> Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library<o:p></o:p></span></p></div></div><p class=xmsonormal><span lang=EN-US> <o:p></o:p></span></p><p style='margin:5.0pt'><span lang=EN-US style='font-size:10.0pt;font-family:"Arial",sans-serif;color:blue'>[AMD Official Use Only - General]</span><span lang=EN-US><o:p></o:p></span></p><p class=xmsonormal><span lang=EN-US> <o:p></o:p></span></p><div><div><p class=xmsonormal style='background:white'><span lang=EN-US style='color:#212121'>Hi Mike, </span><span lang=EN-US><o:p></o:p></span></p></div><div><p class=xmsonormal style='background:white'><span lang=EN-US style='color:#212121'>CC Jiangang, he can give the clear answer.</span><span lang=EN-US><o:p></o:p></span></p></div><div><p class=xmsonormal style='background:white'><span lang=EN-US style='color:#212121'> </span><span lang=EN-US><o:p></o:p></span></p></div><div><p class=xmsonormal style='background:white'><span lang=EN-US style='color:#212121'>Thanks</span><span lang=EN-US><o:p></o:p></span></p></div><div><p class=xmsonormal style='background:white'><span lang=EN-US style='color:#212121'>Abner </span><span lang=EN-US><o:p></o:p></span></p></div><div><p class=xmsonormal style='background:white'><span lang=EN-US style='color:#212121'> </span><span lang=EN-US><o:p></o:p></span></p></div><div id="x_ms-outlook-mobile-signature"><div><p class=xmsonormal><span lang=EN-US> <o:p></o:p></span></p></div><p class=xmsonormal><span lang=EN-US>Get <a href="https://aka.ms/AAb9ysg">Outlook for Android</a><o:p></o:p></span></p></div><div class=MsoNormal align=center style='text-align:center'><span lang=EN-US><hr size=2 width="98%" align=center></span></div><div id="x_divRplyFwdMsg"><p class=xmsonormal><b><span lang=EN-US style='color:black'>From:</span></b><span lang=EN-US style='color:black'> Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>><br><b>Sent:</b> Thursday, January 12, 2023 11:23:48 PM<br><b>To:</b> <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>; Chang, Abner <<a href="mailto:Abner.Chang@amd.com">Abner.Chang@amd.com</a>><br><b>Cc:</b> Bi, Dandan <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>>; Gao, Liming <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>>; Kirkendall, Garrett <<a href="mailto:Garrett.Kirkendall@amd.com">Garrett.Kirkendall@amd.com</a>>; Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>><br><b>Subject:</b> RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library</span><span lang=EN-US> <o:p></o:p></span></p><div><p class=xmsonormal><span lang=EN-US> <o:p></o:p></span></p></div></div><div><div><p class=xmsonormal style='margin-bottom:12.0pt'><span lang=EN-US>Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.<br><br><br>Hi Abner,<br><br>What was the failure before this change?<br><br>This looks like something that would always break the build of source files were missing.<br><br>Mike<br><br>> -----Original Message-----<br>> From: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> On Behalf Of Chang, Abner via groups.io<br>> Sent: Wednesday, January 11, 2023 9:08 PM<br>> To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a><br>> Cc: Bi, Dandan <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>>; Gao, Liming <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>>; Garrett Kirkendall <<a href="mailto:garrett.kirkendall@amd.com">garrett.kirkendall@amd.com</a>>;<br>> Abner Chang <<a href="mailto:abner.chang@amd.com">abner.chang@amd.com</a>><br>> Subject: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library<br>><br>> From: Abner Chang <<a href="mailto:abner.chang@amd.com">abner.chang@amd.com</a>><br>><br>> Add missing source files to Brotli library INF.<br>><br>> Signed-off-by: Jiangang He <<a href="mailto:jiangang.he@amd.com">jiangang.he@amd.com</a>><br>> Cc: Dandan Bi <<a href="mailto:dandan.bi@intel.com">dandan.bi@intel.com</a>><br>> Cc: Liming Gao <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>><br>> Cc: Garrett Kirkendall <<a href="mailto:garrett.kirkendall@amd.com">garrett.kirkendall@amd.com</a>><br>> Cc: Abner Chang <<a href="mailto:abner.chang@amd.com">abner.chang@amd.com</a>><br>> ---<br>> .../BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf | 5 +++++<br>> 1 file changed, 5 insertions(+)<br>><br>> diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf<br>> b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf<br>> index 525e92408d6..244c2e35023 100644<br>> --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf<br>> +++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf<br>> @@ -5,6 +5,7 @@<br>> # Brotli was released on the website <a href="https://github.com/google/brotli">https://github.com/google/brotli</a>.<br>> #<br>> # Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR><br>> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR><br>> #<br>> # SPDX-License-Identifier: BSD-2-Clause-Patent<br>> #<br>> @@ -41,6 +42,10 @@<br>> # Wrapper header files end #<br>> brotli/c/common/dictionary.c<br>> brotli/c/common/transform.c<br>> + brotli/c/common/context.c<br>> + brotli/c/common/platform.c<br>> + brotli/c/common/constants.c<br>> + brotli/c/common/shared_dictionary.c<br>> brotli/c/dec/bit_reader.c<br>> brotli/c/dec/decode.c<br>> brotli/c/dec/huffman.c<br>> --<br>> 2.37.1.windows.1<br>><br>><br>><br>> <br>><o:p></o:p></span></p></div></div></div></div></div></div></div><div><p class=MsoNormal></o:p></span></p></div></div></body></html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/99261">View/Reply Online (#99261)</a> | | <a target="_blank" href="https://groups.io/mt/96602372/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>