<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div dir="ltr">Hi Rebecca and Gerd,<div><br></div><div>Replying to 2 mails at once...<br><div class="AppleOriginalContents" style="direction: ltr;"><br><blockquote type="cite"><div>On 17. Mar 2023, at 11:36, Rebecca Cran <rebecca@bsdio.com> wrote:</div><br class="Apple-interchange-newline"><div><div>I like that proposed workflow.<br><br>I've also been wondering if we could consider choosing a different product for patch reviews that supports our desired workflow better, such as Gitlab or Phorge (the new Phabricator project).<br></div></div></blockquote><div class="AppleOriginalContents" style="direction: ltr;"><br></div><div class="AppleOriginalContents" style="direction: ltr;">I'd be very cautious with suggesting / approving more tooling. It gets more confusing (what is hosted where), it gets more complicated to maintain (who hosts what and is "guaranteed" to be available to fix things), and so on.</div><br><blockquote type="cite"><div><div><br>If anyone would be willing to donate money for colocation, I'd be happy to move one or more of my servers into a datacenter and use them for hosting TianoCore services.<br><br><br>-- <br><br>Rebecca Cran<br><br><br>On 3/17/23 3:33 AM, Gerd Hoffmann wrote:<br><blockquote type="cite">On Thu, Mar 16, 2023 at 01:59:49PM -0600, Rebecca Cran wrote:<br><blockquote type="cite">Is this still a requirement since Laszlo's departure from the project?<br><br>I seem to recall it was him who made it a sticking point of moving to a<br>GitHub PR workflow originally with the requirement to have emails of<br>everything.<br></blockquote>I think it is very useful to have everything on the mailing list for<br>a number of reasons:<br><br> (1) In my experience reviewing patches, especially more complex ones,<br> works better in email than in github PR workflows.<br></blockquote></div></div></blockquote><div class="AppleOriginalContents" style="direction: ltr;"><br></div><div class="AppleOriginalContents" style="direction: ltr;">I have no experience with things like large-scale patch set review in, say, projects like the Linux kernel. However, in about 7 years of watching edk2-devel and opportunistically participating in patch review myself, I never once encountered something about mail patch review that made me think "oh, that's neat". Quite the opposite - I cannot easily cross-reference when commenting, I cannot easily see more context to the changed lines, and I cannot easily see the end result after all patches in a series have been applied. These are all things that GitHub allows me to do. I keep hearing mail patches "work better", but I never found convincing reasons for these claims. Mind sharing? :)</div><br><blockquote type="cite"><div><div><blockquote type="cite"> (2) github doesn't preserve stuff like a mail archive does. When a<br> patch series goes through multiple revision github only preserves<br> the latest revision which was actually merged.<br></blockquote></div></div></blockquote><div class="AppleOriginalContents" style="direction: ltr;"><br></div><div class="AppleOriginalContents" style="direction: ltr;">Is that so? Taking this AUDK PR as an example: <a href="https://github.com/acidanthera/audk/pull/23">https://github.com/acidanthera/audk/pull/23</a></div><div class="AppleOriginalContents" style="direction: ltr;">Note the review comments that say "Outdated" and thus refer to previous revisions of the PR. I can expand the comments to read their content, see their immediate context (of the previous change that did not end up getting merged) and I can click the file name to get an "all files changed" view of the snapshot that was reviewed. What is missing?</div><div class="AppleOriginalContents" style="direction: ltr;">(I’m not sure whether the old stuff isn’t eventually wiped, though, maybe worth carefully inspecting the documentation for options).</div><br><blockquote type="cite"><div><div><blockquote type="cite"> (3) Search engines seem to be better in indexing mail list archives<br> than github pull requests.<br></blockquote></div></div></blockquote><div class="AppleOriginalContents" style="direction: ltr;"><br></div><div class="AppleOriginalContents" style="direction: ltr;">That, unfortunately, undoubtably is true.</div><br><blockquote type="cite"><div><div><blockquote type="cite"><br>Nevertheless I see some room for improvement in our current workflow.<br>Developers often open a PR anyway for to run the CI. So maybe we could<br>automate sending the emails and also avoid running CI twice by avoiding<br>both developer and maintainer opening a PR, with a workflow like this:<br><br> * developer opens a draft PR to run CI for the patch series.<br> * when the series passes CI and is ready un-draft the PR.<br> * github action sends the patch series to the edk2-devel list<br> for review (maybe only after CI passed ...).<br> * patch review happens on the list.<br> * in case the developer pushes updates to the branch in response to<br> review comments the github action posts v2/v3 of the series too.<br> * once review is done merge the PR.<br></blockquote></div></div></blockquote><div class="AppleOriginalContents" style="direction: ltr;"><br></div><div class="AppleOriginalContents" style="direction: ltr;">That would at least be a lot better than what we have now.</div><div class="AppleOriginalContents" style="direction: ltr;"><br></div><div class="AppleOriginalContents" style="direction: ltr;">Best regards,</div><div class="AppleOriginalContents" style="direction: ltr;">Marvin</div><br><blockquote type="cite"><div><div><blockquote type="cite"><br>take care,<br> Gerd<br><br></blockquote></div></div></blockquote></div><br></div></div></body></html>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/101335">View/Reply Online (#101335)</a> |
|
<a target="_blank" href="https://groups.io/mt/97636248/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>