<div dir="ltr"><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Hi Rebecca/ Marvin,</div><div>Patrick has filed it as a separate patch email here <a href="https://edk2.groups.io/g/devel/message/102168">https://edk2.groups.io/g/devel/message/102168</a></div><div>However the email still group them together.</div><div>It is because he could not reproduce any issue anymore that was seen on 2nd patch (could be that Rebecca already fixed it).</div><div>Could you help to review and get this merged?</div><div><br></div><div>Thanks,</div><div>Sheng</div><div style="font-size:medium;color:rgb(34,34,34);font-family:Helvetica;line-height:11px"></div></div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 30 Mar 2023 at 10:05, Marvin Häuser <<a href="mailto:mhaeuser@posteo.de">mhaeuser@posteo.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="ltr"><div dir="ltr"></div><div dir="ltr">Hi Lean,</div><div dir="ltr"><br></div><div dir="ltr">I don’t think individual patches from a series are merged generally. Your 2/3 has open concerns from both Liming and myself.</div><div dir="ltr"><br></div><div dir="ltr">Best regards,</div><div dir="ltr">Marvin</div><div dir="ltr"><br><blockquote type="cite">On 30. Mar 2023, at 09:31, Lean Sheng Tan <<a href="mailto:sheng.tan@9elements.com" target="_blank">sheng.tan@9elements.com</a>> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><div dir="ltr">HI Liming,<div>If no further concern, would you mind to help get this patch merged?</div><div>Thanks!<br clear="all"><div><div dir="ltr"><div dir="ltr"><div><div><font color="#000000" face="Helvetica"><br>Best Regards,</font></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px"><b style="color:rgb(0,0,0);font-family:Helvetica;font-size:small">Lean Sheng Tan</b><br></div></div><div style="font-size:medium;color:rgb(34,34,34);font-family:Helvetica;line-height:11px"></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 28 Mar 2023 at 07:42, gaoliming via <a href="http://groups.io" target="_blank">groups.io</a> <gaoliming=<a href="mailto:byosoft.com.cn@groups.io" target="_blank">byosoft.com.cn@groups.io</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Reviewed-by: Liming Gao <<a href="mailto:gaoliming@byosoft.com.cn" target="_blank">gaoliming@byosoft.com.cn</a>><br>
<br>
> -----邮件原件-----<br>
> 发件人: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>> 代表 Patrick<br>
> Rudolph<br>
> 发送时间: 2023年3月17日 22:06<br>
> 抄送: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>; <a href="mailto:guo.dong@intel.com" target="_blank">guo.dong@intel.com</a>; <a href="mailto:gua.guo@intel.com" target="_blank">gua.guo@intel.com</a>;<br>
> <a href="mailto:james.lu@intel.com" target="_blank">james.lu@intel.com</a>; <a href="mailto:ray.ni@intel.com" target="_blank">ray.ni@intel.com</a>; <a href="mailto:mhaeuser@posteo.de" target="_blank">mhaeuser@posteo.de</a>;<br>
> <a href="mailto:ardb@kernel.org" target="_blank">ardb@kernel.org</a><br>
> 主题: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using<br>
> CLANGDWARF_IA32<br>
> <br>
> The clang toolchain might default to fPIE/fPIC, which prevents<br>
> lld from linking the objects into a binary.<br>
> <br>
> Specify -fno-pie -fno-pic as done on GCC to fix linking.<br>
> <br>
> Test:<br>
> Building the Universal Payload using the command<br>
> 'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' actually<br>
> works.<br>
> <br>
> Signed-off-by: Patrick Rudolph <<a href="mailto:patrick.rudolph@9elements.com" target="_blank">patrick.rudolph@9elements.com</a>><br>
> Ref: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=4356" rel="noreferrer" target="_blank">https://bugzilla.tianocore.org/show_bug.cgi?id=4356</a><br>
> ---<br>
> BaseTools/Conf/tools_def.template | 14 +++++++-------<br>
> 1 file changed, 7 insertions(+), 7 deletions(-)<br>
> <br>
> diff --git a/BaseTools/Conf/tools_def.template<br>
> b/BaseTools/Conf/tools_def.template<br>
> index 471eb67c0c..9b59bd75c3 100755<br>
> --- a/BaseTools/Conf/tools_def.template<br>
> +++ b/BaseTools/Conf/tools_def.template<br>
> @@ -2888,7 +2888,7 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS<br>
> = -Wl,--defsym=PECOFF_HEADER_SIZE=0x22<br>
> *_CLANGDWARF_IA32_RC_PATH =<br>
> DEF(CLANGDWARF_IA32_PREFIX)llvm-rc<br>
> <br>
> <br>
> <br>
> *_CLANGDWARF_IA32_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)<br>
> -m32 -fno-lto DEF(CLANG38_IA32_TARGET)<br>
> <br>
> -*_CLANGDWARF_IA32_ASLDLINK_FLAGS =<br>
> DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=lld<br>
> <br>
> +*_CLANGDWARF_IA32_ASLDLINK_FLAGS =<br>
> DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=lld<br>
> -no-pie<br>
> <br>
> *_CLANGDWARF_IA32_ASM_FLAGS = DEF(GCC5_ASM_FLAGS)<br>
> -m32 -march=i386 DEF(CLANG38_IA32_TARGET)<br>
> <br>
> *_CLANGDWARF_IA32_RC_FLAGS =<br>
> DEF(GCC_IA32_RC_FLAGS)<br>
> <br>
> *_CLANGDWARF_IA32_OBJCOPY_FLAGS =<br>
> <br>
> @@ -2897,17 +2897,17 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS<br>
> = -Wl,--defsym=PECOFF_HEADER_SIZE=0x22<br>
> *_CLANGDWARF_IA32_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS)<br>
> DEF(CLANG38_IA32_TARGET)<br>
> <br>
> *_CLANGDWARF_IA32_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS)<br>
> DEF(CLANG38_IA32_TARGET)<br>
> <br>
> <br>
> <br>
> -DEBUG_CLANGDWARF_IA32_CC_FLAGS =<br>
> DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=i586<br>
> DEF(CLANG38_IA32_TARGET) -g -malign-double<br>
> <br>
> +DEBUG_CLANGDWARF_IA32_CC_FLAGS =<br>
> DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=i586<br>
> DEF(CLANG38_IA32_TARGET) -g -malign-double<br>
> <br>
> DEBUG_CLANGDWARF_IA32_DLINK_FLAGS =<br>
> DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386<br>
> -Wl,--oformat,elf32-i386<br>
> <br>
> -DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =<br>
> DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld<br>
> <br>
> +DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =<br>
> DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld -no-pie<br>
> <br>
> <br>
> <br>
> -RELEASE_CLANGDWARF_IA32_CC_FLAGS =<br>
> DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=i586<br>
> DEF(CLANG38_IA32_TARGET) -malign-double<br>
> <br>
> +RELEASE_CLANGDWARF_IA32_CC_FLAGS =<br>
> DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=i586<br>
> DEF(CLANG38_IA32_TARGET) -malign-double<br>
> <br>
> RELEASE_CLANGDWARF_IA32_DLINK_FLAGS =<br>
> DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386<br>
> -Wl,--oformat,elf32-i386<br>
> <br>
> -RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS =<br>
> DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld<br>
> <br>
> +RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS =<br>
> DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld -no-pie<br>
> <br>
> <br>
> <br>
> -NOOPT_CLANGDWARF_IA32_CC_FLAGS =<br>
> DEF(CLANG38_ALL_CC_FLAGS) -m32 -O0 -march=i586<br>
> DEF(CLANG38_IA32_TARGET) -g -malign-double<br>
> <br>
> +NOOPT_CLANGDWARF_IA32_CC_FLAGS =<br>
> DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -O0 -march=i586<br>
> DEF(CLANG38_IA32_TARGET) -g -malign-double<br>
> <br>
> NOOPT_CLANGDWARF_IA32_DLINK_FLAGS =<br>
> DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -Wl,-O0 -Wl,-melf_i386<br>
> -Wl,--oformat,elf32-i386<br>
> <br>
> -NOOPT_CLANGDWARF_IA32_DLINK2_FLAGS =<br>
> DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O0 -fuse-ld=lld<br>
> <br>
> +NOOPT_CLANGDWARF_IA32_DLINK2_FLAGS =<br>
> DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O0 -fuse-ld=lld -no-pie<br>
> <br>
> <br>
> <br>
> ##########################<br>
> <br>
> # CLANGDWARF X64 definitions<br>
> <br>
> --<br>
> 2.39.1<br>
> <br>
> <br>
> <br>
> -=-=-=-=-=-=<br>
> Groups.io Links: You receive all messages sent to this group.<br>
> View/Reply Online (#101340):<br>
> <a href="https://edk2.groups.io/g/devel/message/101340" rel="noreferrer" target="_blank">https://edk2.groups.io/g/devel/message/101340</a><br>
> Mute This Topic: <a href="https://groups.io/mt/97673648/4905953" rel="noreferrer" target="_blank">https://groups.io/mt/97673648/4905953</a><br>
> Group Owner: <a href="mailto:devel%2Bowner@edk2.groups.io" target="_blank">devel+owner@edk2.groups.io</a><br>
> Unsubscribe: <a href="https://edk2.groups.io/g/devel/unsub" rel="noreferrer" target="_blank">https://edk2.groups.io/g/devel/unsub</a><br>
> [<a href="mailto:gaoliming@byosoft.com.cn" target="_blank">gaoliming@byosoft.com.cn</a>]<br>
> -=-=-=-=-=-=<br>
> <br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
</blockquote></div>
</div></blockquote></div></div></blockquote></div>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/102482">View/Reply Online (#102482)</a> |
|
<a target="_blank" href="https://groups.io/mt/97945955/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>