<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="ProgId" content="Word.Document"> <meta name="Generator" content="Microsoft Word 15"> <meta name="Originator" content="Microsoft Word 15"> <link rel="File-List" href="cid:filelist.xml@01D96F78.406E9D50"><link rel="Edit-Time-Data" href="cid:editdata.mso"><style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="tab-interval:.5in;word-wrap:break-word"> <div class="WordSection1"> Back in 2019, I had proposed some more generic rules for package dependencies. <o:p></o:p> <o:p> </o:p> <a href="https://edk2.groups.io/g/devel/message/52211">https://edk2.groups.io/g/devel/message/52211</a><o:p></o:p> <a href="https://github.com/mdkinney/edk2/wiki/EDKII-Packages#edk-ii-package-dependency-rules">https://github.com/mdkinney/edk2/wiki/EDKII-Packages#edk-ii-package-dependency-rules</a><o:p></o:p> <o:p> </o:p> The EDK II DEC files do not have enough meta-data to apply these rules. Would require some extra<o:p></o:p> Define values or well-known tags in comments. The current package dependency checker uses a <o:p></o:p> set of named packages.<o:p></o:p> <o:p> </o:p> Mike<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Kinney, Michael D <michael.d.kinney@intel.com> Sent: Saturday, April 15, 2023 8:50 AM To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Tan, Dun <dun.tan@intel.com> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck<o:p></o:p> </div> </div> <o:p> </o:p> MdePkg: Include files for industry standard and public specs and lib classes and lib implementations that support those specs<o:p></o:p> <o:p> </o:p> If all the IA32/X64 CPU header files to support the CpuPageTableLib class are in the MdePkg, then we could consider<o:p></o:p> moving he class to MdePkg and avoid this patch.<o:p></o:p> <o:p> </o:p> The current CpuPageTableLib looks IA32/X64 specific. Should it follow the naming conventions in the EDK II C Coding Style Spec<o:p></o:p> updated by Abner? It does not look like the current CpuPageTableLib APIs would apply to other CPU archs.<o:p></o:p> <o:p> </o:p> MdePkg does not have any modules. UefiCpuPkg contains CPU specific modules. UefiCpuPkg can also contain libs<o:p></o:p> that are required by modules in the UefiCpuPkg or modules in other Si/Platform packages.<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> <o:p> </o:p> Mike<o:p></o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Ni, Ray <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>> Sent: Friday, April 14, 2023 9:08 AM To: Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>>; <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; Wang, Jian J <<a href="mailto:jian.j.wang@intel.com">jian.j.wang@intel.com</a>>; Tan, Dun <<a href="mailto:dun.tan@intel.com">dun.tan@intel.com</a>> Cc: Gao, Liming <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>>; Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>> Subject: Re: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck<o:p></o:p> </div> </div> <o:p> </o:p> <div> <div> <div> <div> Mike,<o:p></o:p> </div> <div> What's the rule regarding content in mdepkg and cpupkg?<o:p></o:p> </div> </div> </div> <div id="ms-outlook-mobile-signature"> <div> <o:p> </o:p> </div> <div> thanks,<o:p></o:p> </div> <div> ray<o:p></o:p> </div> </div> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> From: Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>> Sent: Friday, April 14, 2023 11:16:45 PM To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>>; Wang, Jian J <<a href="mailto:jian.j.wang@intel.com">jian.j.wang@intel.com</a>>; Tan, Dun <<a href="mailto:dun.tan@intel.com">dun.tan@intel.com</a>> Cc: Gao, Liming <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>>; Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>> Subject: RE: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> If components outside the UefiCpuPkg need access to the CpuPageTableLib, should we consider moving CpuPageTableLib to MdePkg or MdeModulePkg? There are many different boot phases that need to crate/manage page tables, so we need to find the right common location. Perhaps the only part that needs to be moved is the lib class? Mike > -----Original Message----- > From: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>> On Behalf Of Wang, Jian J > Sent: Friday, April 14, 2023 2:03 AM > To: Tan, Dun <<a href="mailto:dun.tan@intel.com">dun.tan@intel.com</a>>; <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> > Cc: Gao, Liming <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>> > Subject: Re: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck > > MdeModulePkg has never depended on UefiCpuPkg before. Please double > check if there's any side effect introduced by this mutual dependency. > > Acked-by: Jian J Wang <<a href="mailto:jian.j.wang@intel.com">jian.j.wang@intel.com</a>> > > > > -----Original Message----- > > From: Tan, Dun <<a href="mailto:dun.tan@intel.com">dun.tan@intel.com</a>> > > Sent: Friday, March 31, 2023 5:34 PM > > To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> > > Cc: Gao, Liming <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>>; > > Wang, Jian J <<a href="mailto:jian.j.wang@intel.com">jian.j.wang@intel.com</a>> > > Subject: [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass > > DependencyCheck > > > > Add UefiCpuPkg/UefiCpuPkg.dec in MdeModulePkg.ci.yaml to pass > > DependencyCheck since DxeIpl in MdeModulePkg needs to consume > > CpuPageTableLib in UefiCpuPkg. > > > > Signed-off-by: Dun Tan <<a href="mailto:dun.tan@intel.com">dun.tan@intel.com</a>> > > Cc: Liming Gao <<a href="mailto:gaoliming@byosoft.com.cn">gaoliming@byosoft.com.cn</a>> > > Cc: Ray Ni <<a href="mailto:ray.ni@intel.com">ray.ni@intel.com</a>> > > Cc: Jian J Wang <<a href="mailto:jian.j.wang@intel.com">jian.j.wang@intel.com</a>> > > --- > > MdeModulePkg/MdeModulePkg.ci.yaml | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml > > b/MdeModulePkg/MdeModulePkg.ci.yaml > > index f69989087b..d2616f4cdc 100644 > > --- a/MdeModulePkg/MdeModulePkg.ci.yaml > > +++ b/MdeModulePkg/MdeModulePkg.ci.yaml > > @@ -2,7 +2,7 @@ > > # CI configuration for MdeModulePkg > > # > > # Copyright (c) Microsoft Corporation > > -# Copyright (c) 2020, Intel Corporation. All rights reserved. > > +# Copyright (c) 2020 - 2023, Intel Corporation. All rights reserved. > > # (C) Copyright 2021 Hewlett Packard Enterprise Development LP > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > ## > > @@ -51,7 +51,8 @@ > > "MdePkg/MdePkg.dec", > > "MdeModulePkg/MdeModulePkg.dec", > > "StandaloneMmPkg/StandaloneMmPkg.dec", > > - "ArmPkg/ArmPkg.dec" # this should be fixed by promoting an > > abstraction > > + "ArmPkg/ArmPkg.dec", # this should be fixed by promoting an > > abstraction > > + "UefiCpuPkg/UefiCpuPkg.dec" > > ], > > # For host based unit tests > > "AcceptableDependencies-HOST_APPLICATION":[ > > -- > > 2.31.1.windows.1 > > > > > <o:p></o:p> </div> </div> </div> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/103039">View/Reply Online (#103039)</a> | | <a target="_blank" href="https://groups.io/mt/97969862/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/leave/3943202/1813853/130120423/xyzzy">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>