<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Hi Abner,</p>
<p> Here you are: <a moz-do-not-send="true" href="https://github.com/tianocore/edk2/pull/4338">#4338</a></p>
<p>Thanks,</p>
<p>Minh Nguyen<br>
</p>
<div class="moz-cite-prefix">On 5/5/2023 12:45 PM, Chang, Abner
wrote:<br>
</div>
<blockquote type="cite" cite="mid:MN2PR12MB39669D6FEBEAFC58F557A896EA729@MN2PR12MB3966.namprd12.prod.outlook.com">
<pre class="moz-quote-pre" wrap="">[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.]
[AMD Official Use Only - General]
Ok, because the patch in email always has format problem when apply the patch, plus I can't get the patch from group.io; could you please create a PR on your Github thus I can review patches from there.
Just let me know the PR # after you creating it.
Thanks
Abner
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">-----Original Message-----
From: Minh Nguyen <a class="moz-txt-link-rfc2396E" href="mailto:minhnguyen1@amperemail.onmicrosoft.com"><minhnguyen1@amperemail.onmicrosoft.com></a>
Sent: Friday, May 5, 2023 1:35 PM
To: Chang, Abner <a class="moz-txt-link-rfc2396E" href="mailto:Abner.Chang@amd.com"><Abner.Chang@amd.com></a>; Minh Nguyen
<a class="moz-txt-link-rfc2396E" href="mailto:minhnguyen1@os.amperecomputing.com"><minhnguyen1@os.amperecomputing.com></a>; <a class="moz-txt-link-abbreviated" href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>
Cc: <a class="moz-txt-link-abbreviated" href="mailto:patches@amperecomputing.com">patches@amperecomputing.com</a>; <a class="moz-txt-link-abbreviated" href="mailto:nicklew@nvidia.com">nicklew@nvidia.com</a>; <a class="moz-txt-link-abbreviated" href="mailto:igork@ami.com">igork@ami.com</a>;
<a class="moz-txt-link-abbreviated" href="mailto:nhi@os.amperecomputing.com">nhi@os.amperecomputing.com</a>; <a class="moz-txt-link-abbreviated" href="mailto:tinhnguyen@os.amperecomputing.com">tinhnguyen@os.amperecomputing.com</a>
Subject: Re: [PATCH V3 0/5] Adding necessary changes for RedfishPkg
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
Hi Abner,
Yes, me too. I have sent the email to <a class="moz-txt-link-abbreviated" href="mailto:miki.demeter@intel.com">miki.demeter@intel.com</a> for checking
it.
Thanks,
Minh Nguyen
On 5/5/2023 12:03 PM, Chang, Abner wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">[AMD Official Use Only - General]
Hi Minh,
I don't know why however I can't see V3 patch set on group.io. Can you see
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">those patches on group.io?
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
Abner
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">-----Original Message-----
From: Minh Nguyen <a class="moz-txt-link-rfc2396E" href="mailto:minhnguyen1@os.amperecomputing.com"><minhnguyen1@os.amperecomputing.com></a>
Sent: Friday, May 5, 2023 11:58 AM
To: <a class="moz-txt-link-abbreviated" href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>
Cc: <a class="moz-txt-link-abbreviated" href="mailto:patches@amperecomputing.com">patches@amperecomputing.com</a>; Chang, Abner
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap=""><a class="moz-txt-link-rfc2396E" href="mailto:Abner.Chang@amd.com"><Abner.Chang@amd.com></a>;
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap=""><a class="moz-txt-link-abbreviated" href="mailto:nicklew@nvidia.com">nicklew@nvidia.com</a>; <a class="moz-txt-link-abbreviated" href="mailto:igork@ami.com">igork@ami.com</a>; <a class="moz-txt-link-abbreviated" href="mailto:nhi@os.amperecomputing.com">nhi@os.amperecomputing.com</a>;
<a class="moz-txt-link-abbreviated" href="mailto:tinhnguyen@os.amperecomputing.com">tinhnguyen@os.amperecomputing.com</a>;
Minh Nguyen <a class="moz-txt-link-rfc2396E" href="mailto:minhnguyen1@os.amperecomputing.com"><minhnguyen1@os.amperecomputing.com></a>
Subject: [PATCH V3 0/5] Adding necessary changes for RedfishPkg
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
This patchset adds necessary changes for RedfishPkg to avoid some
unexpected cases and fix compilation.
Changes since v3:
+ Replaced __FUNCTION__ with __func__ to be more C11 compliant.
Changes since v2:
+ Added "Cc:" to maintainers in commit message.
+ Corrected patch format subject prefix.
Changes since v1:
+ Removed redundant change and change the commit message for more
precise in PATCH 2/5.
Nhi Pham (1):
RedfishPkg: Add missing newline character
Vu Nguyen (4):
RedfishPkg: Correct variable type to prevent memory corruption
RedfishPkg: Fix condition checking of error status
RedfishPkg: Create RestEx child on selected interface
RedfishPkg: Fix compile issue on Linux
RedfishPkg/Include/Library/RestExLib.h | 3 +
RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 +-
RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 +-
RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">++++++++----
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">--------
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 4 +-
RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 +-
6 files changed, 73 insertions(+), 98 deletions(-)
--
2.39.0
</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/104147">View/Reply Online (#104147)</a> |
|
<a target="_blank" href="https://groups.io/mt/98699661/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a><br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>