<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> Hi Aaron,<o:p></o:p> <o:p> </o:p> Don’t know if this will completely resolve your issues, but if you add some preprocessor statements around the problematic includes in your unit test CPP file, you may be able to get it to build.<o:p></o:p> <o:p> </o:p> For example, I added the highlighted lines to MdePkg\Test\GoogleTest\Library\BaseSafeIntLib\TestBaseSafeIntLib.cpp and I can get that unit test to build. Without the #define/#undef lines it fails in the way you describe.<o:p></o:p> <o:p> </o:p> #include <gtest/gtest.h><o:p></o:p> extern "C" {<o:p></o:p> #include <Base.h><o:p></o:p> #include <Library/SafeIntLib.h><o:p></o:p> <o:p></o:p> #define operator operator_<o:p></o:p> #define xor xor_<o:p></o:p> <o:p> </o:p> #include <IndustryStandard/Tpm20.h><o:p></o:p> #include <IndustryStandard/Tpm12.h><o:p></o:p> <o:p> </o:p> #undef operator<o:p></o:p> #undef xor<o:p></o:p> }<o:p></o:p> <o:p> </o:p> Mike<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Aaron Pop <aaronpop@microsoft.com> Sent: Monday, May 22, 2023 5:41 PM To: devel@edk2.groups.io Cc: Kinney, Michael D <michael.d.kinney@intel.com> Subject: GoogleTest Compatibility with MdePkg's IndustyStandard header files<o:p></o:p> </div> </div> <o:p> </o:p> Google Test, and CPP, has more keywords C uses. <o:p></o:p> <o:p> </o:p> Tpm12.h and Tpm20.h<o:p></o:p> have references to struct names that are `operator` and `xor`, both of which trigger build errors because they conflict with CPP’s keywords. <o:p></o:p> <o:p> </o:p> Operator triggered a build error in MSVC. Xor only triggered a build error under GCC, MSVC did not have a problem with it. <o:p></o:p> <o:p> </o:p> The work arounds suggested in the call, (using defines to get around the conflict) worked for operator, but did not work for xor with gcc. <o:p></o:p> <o:p> </o:p> <o:p> </o:p> Tpm12.h:<o:p></o:p> TPM_PERMANENT_FLAGS<o:p></o:p> BOOLEAN operator;<o:p></o:p> <o:p> </o:p> <o:p> </o:p> Tpm20.h:<o:p></o:p> TPMU_SCHEME_KEYEDHASH<o:p></o:p> TPMS_SCHEME_XOR xor;<o:p></o:p> TPMU_SYM_KEY_BITS<o:p></o:p> TPMI_ALG_HASH xor;<o:p></o:p> <o:p> </o:p> <o:p> </o:p> What is the suggested method of trying to make existing header files compatible with google test?<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Aaron<o:p></o:p> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/105282">View/Reply Online (#105282)</a> | | <a target="_blank" href="https://groups.io/mt/99079638/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/leave/3943202/1813853/130120423/xyzzy">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>