<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left"> [AMD Official Use Only - General]<br> </p> <br> <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof"> Hi Abner,</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof"> Thank you for your feedback. I updated the commit and re-create the PR as below:</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof ContentPasted0"> <a href="https://github.com/tianocore/edk2/pull/4471" id="LPlnkOWALinkPreview">https://github.com/tianocore/edk2/pull/4471</a><br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof ContentPasted0"> Regards,</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof ContentPasted0"> Neo</div> <div id="appendonsend"></div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> Chang, Abner <Abner.Chang@amd.com><br> <b>Sent:</b> Friday, June 2, 2023 11:31 AM<br> <b>To:</b> Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; Wu, Hao A <hao.a.wu@intel.com>; He, Jiangang <Jiangang.He@amd.com>; devel@edk2.groups.io <devel@edk2.groups.io><br> <b>Subject:</b> RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM</font> <div> </div> </div> <div lang="EN-US" style="word-wrap:break-word"> <p align="Left" style="font-family: Arial; font-size: 10pt; margin: 5pt; color: rgb(0, 0, 255);"> [AMD Official Use Only - General]<br> </p> <br> <div> <div class="x_WordSection1"> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> Hi Leo,</p> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> Please add Hao’s RB in the commit message below your signed-off-by, thus we know this patch has been reviewed.</p> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> I also suggest to update your commit subject to “MdeModulePkg<b>/Bus</b>: Fix port multiplier port in AhciPei PEIM”.</p> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> </p> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> Please resend the PR with above updates, then Hao will add “Push” label to this PR once your change passed CI.</p> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> </p> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> Thanks</p> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> Abner</p> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> </p> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> </p> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> </p> <div style="border:none; border-left:solid blue 1.5pt; padding:0in 0in 0in 4.0pt"> <div> <div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in"> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> <b>From:</b> Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com> <br> <b>Sent:</b> Friday, June 2, 2023 10:37 PM<br> <b>To:</b> Wu, Hao A <hao.a.wu@intel.com>; He, Jiangang <Jiangang.He@amd.com>; devel@edk2.groups.io<br> <b>Cc:</b> Chang, Abner <Abner.Chang@amd.com><br> <b>Subject:</b> Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM</p> </div> </div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> </p> <p style="margin:5.0pt"><span style="font-size: 10pt; font-family: Arial, sans-serif; color: blue;">[AMD Official Use Only - General]</span></p> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> </p> <div> <div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> <span style="font-size: 12pt; color: black;">Hi Hao,</span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> <span style="font-size: 12pt; color: black;"> </span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> <span style="font-size: 12pt; color: black;">Thank you for your review.</span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> <span style="font-size: 12pt; color: black;"> </span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> <span style="font-size: 12pt; color: black;">I already created a pull request for this commit, may I know how to proceed to merge it into master?</span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> <span style="font-size: 12pt; color: black;"> </span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> <span style="font-size: 12pt; color: black;"><a href="https://github.com/tianocore/edk2/pull/4424" data-auth="NotApplicable">https://github.com/tianocore/edk2/pull/4424</a></span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> <span style="font-size: 12pt; color: black;"> </span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> <span style="font-size: 12pt; color: black;"> </span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> <span style="font-size: 12pt; color: black;">Regards,</span></p> </div> <div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> <span style="font-size: 12pt; color: black;">Neo</span></p> </div> <div class="x_MsoNormal" align="center" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="x_divRplyFwdMsg"> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> <b><span style="color: black;">From:</span></b><span style="color: black;"> Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" data-auth="NotApplicable" data-loopstyle="linkonly">hao.a.wu@intel.com</a>><br> <b>Sent:</b> Thursday, June 1, 2023 10:14 PM<br> <b>To:</b> He, Jiangang <<a href="mailto:Jiangang.He@amd.com" data-auth="NotApplicable" data-loopstyle="linkonly">Jiangang.He@amd.com</a>>; <a href="mailto:devel@edk2.groups.io" data-auth="NotApplicable" data-loopstyle="linkonly"> devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" data-auth="NotApplicable" data-loopstyle="linkonly">devel@edk2.groups.io</a>>; Hsueh, Hong-Chih (Neo) <<a href="mailto:Hong-Chih.Hsueh@amd.com" data-auth="NotApplicable" data-loopstyle="linkonly">Hong-Chih.Hsueh@amd.com</a>><br> <b>Cc:</b> Chang, Abner <<a href="mailto:Abner.Chang@amd.com" data-auth="NotApplicable" data-loopstyle="linkonly">Abner.Chang@amd.com</a>><br> <b>Subject:</b> RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM</span> </p> <div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;"> </p> </div> </div> <div> <div> <p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;margin-bottom:12.0pt"> [AMD Official Use Only - General]<br> <br> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.<br> <br> <br> Thanks.<br> Reviewed-by: Hao A Wu <<a href="mailto:hao.a.wu@intel.com" data-auth="NotApplicable" data-loopstyle="linkonly">hao.a.wu@intel.com</a>><br> <br> Best Regards,<br> Hao Wu<br> <br> > -----Original Message-----<br> > From: He, Jiangang <<a href="mailto:Jiangang.He@amd.com" data-auth="NotApplicable" data-loopstyle="linkonly">Jiangang.He@amd.com</a>><br> > Sent: Wednesday, May 31, 2023 10:49 PM<br> > To: Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" data-auth="NotApplicable" data-loopstyle="linkonly">hao.a.wu@intel.com</a>>; <a href="mailto:devel@edk2.groups.io" data-auth="NotApplicable" data-loopstyle="linkonly"> devel@edk2.groups.io</a>; Hsueh, Hong-<br> > Chih (Neo) <<a href="mailto:Hong-Chih.Hsueh@amd.com" data-auth="NotApplicable" data-loopstyle="linkonly">Hong-Chih.Hsueh@amd.com</a>><br> > Cc: Chang, Abner <<a href="mailto:Abner.Chang@amd.com" data-auth="NotApplicable" data-loopstyle="linkonly">Abner.Chang@amd.com</a>><br> > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in<br> > AhciPei PEIM<br> ><br> > [AMD Official Use Only - General]<br> ><br> > We did crisis recovery and Opal HD password unlock from S3 resume from<br> > SATA HD test on two different version of AHCI host controllers.<br> ><br> > Thanks,<br> > Jiangang<br> > -----Original Message-----<br> > From: Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" data-auth="NotApplicable" data-loopstyle="linkonly">hao.a.wu@intel.com</a>><br> > Sent: Tuesday, May 30, 2023 10:30 PM<br> > To: <a href="mailto:devel@edk2.groups.io" data-auth="NotApplicable" data-loopstyle="linkonly"> devel@edk2.groups.io</a>; Hsueh, Hong-Chih (Neo) <Hong-<br> > <a href="mailto:Chih.Hsueh@amd.com" data-auth="NotApplicable" data-loopstyle="linkonly"> Chih.Hsueh@amd.com</a>><br> > Cc: He, Jiangang <<a href="mailto:Jiangang.He@amd.com" data-auth="NotApplicable" data-loopstyle="linkonly">Jiangang.He@amd.com</a>>; Chang, Abner<br> > <<a href="mailto:Abner.Chang@amd.com" data-auth="NotApplicable" data-loopstyle="linkonly">Abner.Chang@amd.com</a>><br> > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in<br> > AhciPei PEIM<br> ><br> > Caution: This message originated from an External Source. Use proper<br> > caution when opening attachments, clicking links, or responding.<br> ><br> ><br> > Thanks, the code changes look good to me.<br> > May I know what tests have been performed for the patch?<br> ><br> > Best Regards,<br> > Hao Wu<br> ><br> > > -----Original Message-----<br> > > From: <a href="mailto:devel@edk2.groups.io" data-auth="NotApplicable" data-loopstyle="linkonly"> devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" data-auth="NotApplicable" data-loopstyle="linkonly">devel@edk2.groups.io</a>> On Behalf Of Neo<br> > > Hsueh via groups.io<br> > > Sent: Wednesday, May 24, 2023 1:07 AM<br> > > To: <a href="mailto:devel@edk2.groups.io" data-auth="NotApplicable" data-loopstyle="linkonly"> devel@edk2.groups.io</a><br> > > Cc: <a href="mailto:jiangang.he@amd.com" data-auth="NotApplicable" data-loopstyle="linkonly"> jiangang.he@amd.com</a>; <a href="mailto:abner.chang@amd.com" data-auth="NotApplicable" data-loopstyle="linkonly"> abner.chang@amd.com</a>; Neo Hsueh <Hong-<br> > > <a href="mailto:Chih.Hsueh@amd.com" data-auth="NotApplicable" data-loopstyle="linkonly"> Chih.Hsueh@amd.com</a>><br> > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port<br> > > in AhciPei PEIM<br> > ><br> > > If there is no port multiplier, PortMultiplierPort should be converted<br> > > to 0 to follow AHCI spec.<br> > > The same logic already applied in AtaAtapiPassThruDxe driver.<br> > ><br> > > Signed-off-by: Neo Hsueh <<a href="mailto:Hong-Chih.Hsueh@amd.com" data-auth="NotApplicable" data-loopstyle="linkonly">Hong-Chih.Hsueh@amd.com</a>><br> > > ---<br> > > MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 ++++++++++<br> > > 1 file changed, 10 insertions(+)<br> > ><br> > > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c<br> > > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c<br> > > index cd55272c96..7bd04661d0 100644<br> > > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c<br> > > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c<br> > > @@ -3,6 +3,7 @@<br> > > mode at PEI phase.<br> > ><br> > > Copyright (c) 2019, Intel Corporation. All rights reserved.<BR><br> > > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights<br> > > + reserved.<BR><br> > ><br> > > SPDX-License-Identifier: BSD-2-Clause-Patent<br> > ><br> > > @@ -92,6 +93,15 @@ AhciPassThruExecute ( {<br> > > EFI_STATUS Status;<br> > ><br> > > + if (PortMultiplierPort == 0xFFFF) {<br> > > + //<br> > > + // If there is no port multiplier, PortMultiplierPort will be 0xFFFF<br> > > + // according to UEFI spec. Here, we convert its value to 0 to follow<br> > > + // AHCI spec.<br> > > + //<br> > > + PortMultiplierPort = 0;<br> > > + }<br> > > +<br> > > switch (Packet->Protocol) {<br> > > case EFI_ATA_PASS_THRU_PROTOCOL_ATA_NON_DATA:<br> > > Status = AhciNonDataTransfer (<br> > > --<br> > > 2.40.0.windows.1<br> > ><br> > ><br> > ><br> > > <br> > ></p> </div> </div> </div> </div> </div> </div> </div> </div> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target="_blank" href="https://edk2.groups.io/g/devel/message/105673">View/Reply Online (#105673)</a> | | <a target="_blank" href="https://groups.io/mt/99093106/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <br> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com]<br> <div width="1" style="color:white;clear:both">_._,_._,_</div>