<div dir="ltr">Hi Hao,<div><br></div><div>Just bringing this one to your attention in case it has got buried down under ...</div><div><br></div><div>On the same lines as the following merged today -</div><div><a href="https://github.com/tianocore/edk2/commit/c7c1170a4568ecc0f63e14ca6a844d40f47519a9">https://github.com/tianocore/edk2/commit/c7c1170a4568ecc0f63e14ca6a844d40f47519a9</a> </div><div><br></div><div>Best Regards,</div><div>Ranbir Singh</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 17, 2023 at 5:29 PM Ranbir Singh <<a href="mailto:rsingh@ventanamicro.com">rsingh@ventanamicro.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From: Ranbir Singh <Ranbir.Singh3@Dell.com><br>
<br>
Line number 365 does contain a typecast with UINT32, but it is after<br>
all the operations (16-bit left shift followed by OR'ing) are over.<br>
To avoid any SIGN_EXTENSION, typecast the intermediate result after<br>
16-bit left shift operation immediately with UINT32.<br>
<br>
REF: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=4209" rel="noreferrer" target="_blank">https://bugzilla.tianocore.org/show_bug.cgi?id=4209</a><br>
<br>
Cc: Hao A Wu <<a href="mailto:hao.a.wu@intel.com" target="_blank">hao.a.wu@intel.com</a>><br>
Cc: Ray Ni <<a href="mailto:ray.ni@intel.com" target="_blank">ray.ni@intel.com</a>><br>
Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com><br>
Signed-off-by: Ranbir Singh <<a href="mailto:rsingh@ventanamicro.com" target="_blank">rsingh@ventanamicro.com</a>><br>
---<br>
 MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c<br>
index a77852bae054..57aefa04c215 100644<br>
--- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c<br>
+++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c<br>
@@ -362,7 +362,7 @@ IdentifyAtaDevice (<br>
     // Check logical block size<br>
     //<br>
     if ((PhyLogicSectorSupport & BIT12) != 0) {<br>
-      BlockMedia->BlockSize = (UINT32)(((IdentifyData->logic_sector_size_hi << 16) | IdentifyData->logic_sector_size_lo) * sizeof (UINT16));<br>
+      BlockMedia->BlockSize = (UINT32)(((UINT32)(IdentifyData->logic_sector_size_hi << 16) | IdentifyData->logic_sector_size_lo) * sizeof (UINT16));<br>
     }<br>
<br>
     AtaDevice->BlockIo.Revision = EFI_BLOCK_IO_PROTOCOL_REVISION2;<br>
-- <br>
2.34.1<br>
<br>
</blockquote></div>


<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>


Groups.io Links:<p>


  
    You receive all messages sent to this group.
  
  


<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/107443">View/Reply Online (#107443)</a> |


  

|

  <a target="_blank" href="https://groups.io/mt/100212118/1813853">Mute This Topic</a>


| <a href="https://edk2.groups.io/g/devel/post">New Topic</a>

<br>




<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |

<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>

 [edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>