<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> Hi Likun, I'm saw this PR was blocked by some CI entries, and it looks like the coding style ECC check is failing, details message are on the azure CI site: <a class="moz-txt-link-freetext" href="https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=99105&view=ms.vss-test-web.build-test-results-tab&runId=864236&resultId=100010&paneView=attachments">https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=99105&view=ms.vss-test-web.build-test-results-tab&runId=864236&resultId=100010&paneView=attachments</a>. CI has given the recommondations, refer to following image: <img src="cid:part1.L240XURn.s6sYUcd7@loongson.cn" alt=""> Please modify your patch as suggested by CI: 1. Reduce the spaces between "EPRing" and "=". 2. Add a new blank line at the end of the code you added. And then you can submit PR again. Liming, Please create the new push label after Likun finished. Thank you! <div class="moz-signature" signature-switch-id="18b8a24a-8ce6-4aca-a108-921eeebcd5e9"> <div style="width:15%;height:1px;background-color:grey;transform:scaleY(0.3)"></div> <div style="color:grey;font-size:11px">Thanks, Chao </div> </div> <div class="moz-cite-prefix">在 2023/8/2 13:29, gaoliming via groups.io 写道: </div> <blockquote type="cite" cite="mid:004501d9c502$5f2fb9b0$1d8f2d10$@byosoft.com.cn"> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)">  <style>@font-face {font-family:宋体; panose-1:2 1 6 0 3 1 1 1 1 1;}@font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face {font-family:等线; panose-1:2 1 6 0 3 1 1 1 1 1;}@font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;}@font-face {font-family:"\@等线"; panose-1:2 1 6 0 3 1 1 1 1 1;}@font-face {font-family:"\@宋体"; panose-1:2 1 6 0 3 1 1 1 1 1;}@font-face {font-family:"Microsoft YaHei \,sans-serif\;"; panose-1:0 0 0 0 0 0 0 0 0 0;}p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; font-size:12.0pt; font-family:宋体;}a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;}span.EmailStyle20 {mso-style-type:personal-reply; font-family:等线; color:windowtext;}.MsoChpDefault {mso-style-type:export-only; font-size:10.0pt; mso-ligatures:none;}div.WordSection1 {page:WordSection1;}</style> <div class="WordSection1"> <a href="https://github.com/tianocore/edk2/pull/4709" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/tianocore/edk2/pull/4709</a> is created to merge this patch. <o:p></o:p> <o:p> </o:p> Thanks<o:p></o:p> Liming<o:p></o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> 发件人: <a class="moz-txt-link-abbreviated" href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a> <a class="moz-txt-link-rfc2396E" href="mailto:devel@edk2.groups.io"><devel@edk2.groups.io></a> 代表 Chao Li 发送时间: 2023年7月27日 15:24 收件人: <a class="moz-txt-link-abbreviated" href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a>; <a class="moz-txt-link-abbreviated" href="mailto:sulikun@loongson.cn">sulikun@loongson.cn</a>; Wu, Hao A <a class="moz-txt-link-rfc2396E" href="mailto:hao.a.wu@intel.com"><hao.a.wu@intel.com></a> 抄送: Gao, Liming <a class="moz-txt-link-rfc2396E" href="mailto:gaoliming@byosoft.com.cn"><gaoliming@byosoft.com.cn></a>; Demeter, Miki <a class="moz-txt-link-rfc2396E" href="mailto:miki.demeter@intel.com"><miki.demeter@intel.com></a> 主题: Re: [edk2-devel] empty USB DVD disk hang Xhci<o:p></o:p> </div> </div> <o:p> </o:p> Hi Likun,<o:p></o:p> Liming and Hao have reviewd and acked your patch, I think you can submit your patch on edk2 repo and don't forget include Liming and Hao review message. Good job!<o:p></o:p> <div> <o:p> </o:p> <div> Thanks, Chao<o:p></o:p> </div> </div> <div> 在 2023/7/27 11:21, 苏丽坤写道:<o:p></o:p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> Hi, Hao,Liming, <o:p></o:p> <o:p> </o:p> this is my reply， function XhcInitializeDeviceSlot64 will init EndpointTransferRing,while fuctionUsbMassReadBlocks return (Invalid Parameter), which result in run function UsbMassReset, this will call XhcDisableSlotCmd64, will clear EndpointTransferRing, like this Xhc->UsbDevContext[SlotId].EndpointTransferRing[Index] = NULL; If fuctionUsbMassReadBlocks return success also run function UsbMassReset, will hang for the same reason. why fuctionUsbMassReadBlocks return (Invalid Parameter), this function will call UsbBootRequestSense,this retun (Invalid Parameter). At the same time, Ehci also retun (Invalid Parameter). <o:p></o:p> <o:p> </o:p> Thanks <o:p></o:p> <blockquote style="border:none;border-left:solid #B6B6B6 1.5pt;padding:0cm 0cm 0cm 4.0pt;margin-left:3.75pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt"> -----原始邮件----- 发件人: "Wu, Hao A" <a href="mailto:hao.a.wu@intel.com" moz-do-not-send="true"><hao.a.wu@intel.com></a> 发送时间: 2023-07-25 10:18:42 (星期二) 收件人: "Gao, Liming" <a href="mailto:gaoliming@byosoft.com.cn" moz-do-not-send="true"><gaoliming@byosoft.com.cn></a>, <a href="mailto:devel@edk2.groups.io" moz-do-not-send="true">"devel@edk2.groups.io"</a> <a href="mailto:devel@edk2.groups.io" moz-do-not-send="true"><devel@edk2.groups.io></a>, <a href="mailto:sulikun@loongson.cn" moz-do-not-send="true">"sulikun@loongson.cn"</a> <a href="mailto:sulikun@loongson.cn" moz-do-not-send="true"><sulikun@loongson.cn></a>, "Demeter, Miki" <a href="mailto:miki.demeter@intel.com" moz-do-not-send="true"><miki.demeter@intel.com></a> 主题: RE: [edk2-devel] empty USB DVD disk hang Xhci<o:p></o:p> <div> <div> <div> Sorry, I do not have much resource to review this in detail. But the patch generally looks good to me: <o:p></o:p> Acked-by: Hao A Wu <a href="mailto:hao.a.wu@intel.com" moz-do-not-send="true" class="moz-txt-link-freetext">hao.a.wu@intel.com</a> <o:p></o:p> <o:p></o:p> However, I hope the below question can be answered (or add related information to the commit log message) before mering: <o:p></o:p> Likun, could you help to elaborate a bit more on why the below statement will return NULL pointer for “USB DVD with empty disk”? <o:p></o:p> EPRing = (TRANSFER_RING *)(UINTN)Xhc->UsbDevContext[SlotId].EndpointTransferRing[Dci-1]; <o:p></o:p> <o:p></o:p> <o:p></o:p> <div> Best Regards, <o:p></o:p> Hao Wu <o:p></o:p> </div> <o:p></o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: gaoliming <a href="mailto:gaoliming@byosoft.com.cn" moz-do-not-send="true"><gaoliming@byosoft.com.cn></a> Sent: Tuesday, July 25, 2023 9:44 AM To: <a href="mailto:devel@edk2.groups.io" moz-do-not-send="true" class="moz-txt-link-freetext">devel@edk2.groups.io</a>; <a href="mailto:sulikun@loongson.cn" moz-do-not-send="true" class="moz-txt-link-freetext">sulikun@loongson.cn</a>; Demeter, Miki <a href="mailto:miki.demeter@intel.com" moz-do-not-send="true"><miki.demeter@intel.com></a> Cc: Wu, Hao A <a href="mailto:hao.a.wu@intel.com" moz-do-not-send="true"><hao.a.wu@intel.com></a> Subject: 回复: [edk2-devel] empty USB DVD disk hang Xhci <o:p></o:p> </div> </div> <o:p></o:p> Likun: <o:p></o:p> This change is good to me. Reviewed-by: Liming Gao <<a href="mailto:gaoliming@byosoft.com.cn" moz-do-not-send="true" class="moz-txt-link-freetext">gaoliming@byosoft.com.cn</a>> <o:p></o:p> <o:p></o:p> Hao: <o:p></o:p> Have you time to review this fix? <o:p></o:p> <o:p></o:p> Thanks <o:p></o:p> Liming <o:p></o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> 发件人: <a href="mailto:devel@edk2.groups.io" moz-do-not-send="true" class="moz-txt-link-freetext">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" moz-do-not-send="true" class="moz-txt-link-freetext">devel@edk2.groups.io</a>> 代表 苏丽坤 发送时间: 2023年7月18日 9:49 收件人: <a href="mailto:gaoliming@byosoft.com.cn" moz-do-not-send="true" class="moz-txt-link-freetext">gaoliming@byosoft.com.cn</a>; <a href="mailto:miki.demeter@intel.com" moz-do-not-send="true" class="moz-txt-link-freetext">miki.demeter@intel.com</a>; <a href="mailto:devel@edk2.groups.io" moz-do-not-send="true" class="moz-txt-link-freetext">devel@edk2.groups.io</a> 主题: [edk2-devel] empty USB DVD disk hang Xhci <o:p></o:p> </div> </div> <o:p></o:p> <div> <div> Hi <o:p></o:p> We find a bug in xhci, USB DVD boot with emtpy disk will hang Xhci while Ehci can pass. <o:p></o:p> The hang log is shown as : MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c(1847): TrsRing != ((void *) 0) <o:p></o:p> We suggest a way to solve this bug is shown as: <a href="https://github.com/suling-123/edk2" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/suling-123/edk2</a> the latest commit, MdeModulePkg: Solve boot hang xhci driver when use USB DVD with empty disk, 950bc8781d81b96b0c7944e7ac947382b1bc0c06 <o:p></o:p> <img style="width:8.525in;height:4.35in" id="图片_x0020_1" src="cid:part2.8hALTb0m.Py4jlgJV@loongson.cn" class="" width="818" height="418" border="0"><o:p></o:p> </div> 本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it. <o:p></o:p> </div> 本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it. <o:p></o:p> </div> </div> </div> </div> </div> </blockquote> </div> 本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it. <o:p></o:p> </blockquote> </div> </blockquote> </body> </html> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/107480">View/Reply Online (#107480)</a> | | <a target="_blank" href="https://groups.io/mt/100519473/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>