<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 1 6 1 0 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@PMingLiU";
panose-1:2 1 6 1 0 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 129.75pt 1.0in 129.7pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div class="WordSection1">
<p class="MsoNormal">Yes Nickle,<o:p></o:p></p>
<p class="MsoNormal">I agree to have a common API for initializing the structure members.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks<o:p></o:p></p>
<p class="MsoNormal">Abner<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Nickle Wang <nicklew@nvidia.com> <br>
<b>Sent:</b> Wednesday, August 30, 2023 9:48 AM<br>
<b>To:</b> Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com><br>
<b>Cc:</b> igork@ami.com<br>
<b>Subject:</b> RE: [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uninialized list variable.<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<table class="MsoNormalTable" border="0" cellspacing="0" cellpadding="0" align="left" width="100%" style="width:100.0%">
<tbody>
<tr>
<td style="background:#FFB900;padding:5.0pt 2.0pt 5.0pt 2.0pt"></td>
<td width="100%" style="width:100.0%;background:#FFF8E5;padding:5.0pt 4.0pt 5.0pt 12.0pt">
<div>
<p class="MsoNormal" style="mso-element:frame;mso-element-frame-hspace:2.25pt;mso-element-wrap:around;mso-element-anchor-vertical:paragraph;mso-element-anchor-horizontal:column;mso-height-rule:exactly">
<b><span style="color:#222222">Caution:</span></b><span style="color:#222222"> This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
<o:p></o:p></span></p>
</div>
</td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoPlainText">Reviewed-by: Nickle Wang <<a href="mailto:nicklew@nvidia.com">nicklew@nvidia.com</a>><o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><a id="OWAAMD573BF4C22E94D6B8EC0552D39025214" href="mailto:abner.chang@amd.com"><span style="font-family:"Calibri",sans-serif;text-decoration:none">@abner.chang@amd.com</span></a>, I am thinking that we may need to provide allocation
function for CS structure so caller does not need to handle linked-list initialization like this one, or other stuff requies understanding to CS structure implementation.
<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Regards,<o:p></o:p></p>
<p class="MsoPlainText">Nickle<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">> -----Original Message-----<o:p></o:p></p>
<p class="MsoPlainText">> From: Mike Maslenkin <<a href="mailto:mike.maslenkin@gmail.com">mike.maslenkin@gmail.com</a>><o:p></o:p></p>
<p class="MsoPlainText">> Sent: Tuesday, August 29, 2023 4:01 PM<o:p></o:p></p>
<p class="MsoPlainText">> To: <a href="mailto:devel@edk2.groups.io">devel@edk2.groups.io</a><o:p></o:p></p>
<p class="MsoPlainText">> Cc: <a href="mailto:abner.chang@amd.com">abner.chang@amd.com</a>; Nickle Wang <<a href="mailto:nicklew@nvidia.com">nicklew@nvidia.com</a>>;<o:p></o:p></p>
<p class="MsoPlainText">> <a href="mailto:igork@ami.com">igork@ami.com</a>; Mike Maslenkin <<a href="mailto:mike.maslenkin@gmail.com">mike.maslenkin@gmail.com</a>><o:p></o:p></p>
<p class="MsoPlainText">> Subject: [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uninialized list<o:p></o:p></p>
<p class="MsoPlainText">> variable.<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> External email: Use caution opening links or attachments<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> Signed-off-by: Mike Maslenkin <<a href="mailto:mike.maslenkin@gmail.com"><span style="color:windowtext;text-decoration:none">mike.maslenkin@gmail.com</span></a>><o:p></o:p></p>
<p class="MsoPlainText">> ---<o:p></o:p></p>
<p class="MsoPlainText">> RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 ++<o:p></o:p></p>
<p class="MsoPlainText">> 1 file changed, 2 insertions(+)<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c<o:p></o:p></p>
<p class="MsoPlainText">> b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c<o:p></o:p></p>
<p class="MsoPlainText">> index b9c799e07684..a1738de46fdf 100644<o:p></o:p></p>
<p class="MsoPlainText">> --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c<o:p></o:p></p>
<p class="MsoPlainText">> +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c<o:p></o:p></p>
<p class="MsoPlainText">> @@ -97,6 +97,8 @@ RedfishConsumeResourceCommon (<o:p></o:p></p>
<p class="MsoPlainText">> if (BiosCs->Attributes == NULL) {<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> BiosCs->Attributes = AllocateZeroPool (sizeof<o:p></o:p></p>
<p class="MsoPlainText">> (RedfishBios_V1_0_9_Attributes_CS));<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> ASSERT (BiosCs->Attributes != NULL);<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> + // initialize list<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> + BiosCs->Attributes->Prop.ForwardLink = &BiosCs->Attributes->Prop;<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> }<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> //<o:p></o:p></p>
<p class="MsoPlainText">> <o:p></o:p></p>
<p class="MsoPlainText">> --<o:p></o:p></p>
<p class="MsoPlainText">> 2.32.0 (Apple Git-132)<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/108183">View/Reply Online (#108183)</a> |
|
<a target="_blank" href="https://groups.io/mt/101027003/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a>
<br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>