<div dir="ltr">Hi Mike,<div> </div><div>I earlier assumed that both the fallthrough were intentional and just made it evident by writing the comment. It was hence written actually for the code reader and not the static analyzer. The comment was similar in nature and style to existing No/1-byte/... data comments. Incidentally, the comment satisfied the static analyzer as well. It was beyond my expectation and I was pleasantly surprised too. Without digging deep into the particular code and to avoid any functional code change, I just thought that's it.</div><div><div> </div><div>Your comment forced me to come back specifically to the particular code and to analyze it a bit more.</div><div> </div><div>My analysis now says that the fallthrough doesn't serve any real functional purpose as there is absolutely no chance of if blocks of the fallthrough case(s) being executed later and not executed in the original case: and hence the fallthrough if it happens still leads to execution of return NULL; at the end of the function only. This is better communicated by adding break; statement in the original case: and in a way, one may agree with the static analyzer that there was a MISSING_BREAK. I should hence follow it up with a v2 patch for this.</div></div><div> </div><div>Ranbir Singh</div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 5, 2023 at 12:17 AM Kinney, Michael D <<a href="mailto:michael.d.kinney@intel.com">michael.d.kinney@intel.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I do not prefer special comments for one static analyzer. Is there an alternative design/implementation of this code to make it more readable and not trigger any static analysis false positives? Mike > -----Original Message----- > From: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>> On Behalf Of Ranbir > Singh > Sent: Tuesday, October 3, 2023 10:48 PM > To: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>; <a href="mailto:rsingh@ventanamicro.com" target="_blank">rsingh@ventanamicro.com</a> > Cc: Wu, Hao A <<a href="mailto:hao.a.wu@intel.com" target="_blank">hao.a.wu@intel.com</a>>; Ni, Ray <<a href="mailto:ray.ni@intel.com" target="_blank">ray.ni@intel.com</a>>; > Veeresh Sangolli <<a href="mailto:veeresh.sangolli@dellteam.com" target="_blank">veeresh.sangolli@dellteam.com</a>> > Subject: [edk2-devel] [PATCH v1 2/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: > Fix MISSING_BREAK Coverity issues > > From: Ranbir Singh <Ranbir.Singh3@Dell.com> > > The function GetNextHidItem has a switch-case code in which the > case 1: falls through to case 2: and then case 2: falls through > to case 3: in the block. > > While this may be intentional, it is not evident to any general > code reader as well as any static analyzer tool. Just adding > > // No break; here as this is an intentional fallthrough. > > as comment in between makes a reader as well as Coverity happy. > > REF: <a href="https://bugzilla.tianocore.org/show_bug.cgi?id=4222" rel="noreferrer" target="_blank">https://bugzilla.tianocore.org/show_bug.cgi?id=4222</a> > > Cc: Hao A Wu <<a href="mailto:hao.a.wu@intel.com" target="_blank">hao.a.wu@intel.com</a>> > Cc: Ray Ni <<a href="mailto:ray.ni@intel.com" target="_blank">ray.ni@intel.com</a>> > Co-authored-by: Veeresh Sangolli <<a href="mailto:veeresh.sangolli@dellteam.com" target="_blank">veeresh.sangolli@dellteam.com</a>> > Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com> > Signed-off-by: Ranbir Singh <<a href="mailto:rsingh@ventanamicro.com" target="_blank">rsingh@ventanamicro.com</a>> > --- > MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c > b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c > index acc19acd98e0..bc9a4824208b 100644 > --- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c > +++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/MouseHid.c > @@ -89,6 +89,10 @@ GetNextHidItem ( > return StartPos; > > } > > > > + // > > + // No break; here as this is an intentional fallthrough > > + // > > + > > case 2: > > // > > // 2-byte data > > @@ -99,6 +103,10 @@ GetNextHidItem ( > return StartPos; > > } > > > > + // > > + // No break; here as this is an intentional fallthrough > > + // > > + > > case 3: > > // > > // 4-byte data, adjust size > > -- > 2.34.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#109309): > <a href="https://edk2.groups.io/g/devel/message/109309" rel="noreferrer" target="_blank">https://edk2.groups.io/g/devel/message/109309</a> > Mute This Topic: <a href="https://groups.io/mt/101750274/1643496" rel="noreferrer" target="_blank">https://groups.io/mt/101750274/1643496</a> > Group Owner: <a href="mailto:devel%2Bowner@edk2.groups.io" target="_blank">devel+owner@edk2.groups.io</a> > Unsubscribe: <a href="https://edk2.groups.io/g/devel/unsub" rel="noreferrer" target="_blank">https://edk2.groups.io/g/devel/unsub</a> > [<a href="mailto:michael.d.kinney@intel.com" target="_blank">michael.d.kinney@intel.com</a>] > -=-=-=-=-=-= > </blockquote></div> <div width="1" style="color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links: You receive all messages sent to this group. <a target="_blank" href="https://edk2.groups.io/g/devel/message/109342">View/Reply Online (#109342)</a> | | <a target="_blank" href="https://groups.io/mt/101750274/1813853">Mute This Topic</a> | <a href="https://edk2.groups.io/g/devel/post">New Topic</a> <a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> | <a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> | <a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a> [edk2-devel-archive@redhat.com] <div width="1" style="color:white;clear:both">_._,_._,_</div>