<div dir="ltr">Thank you for catching this! I will correct it.<div><br></div><div>Thanks,</div><div>Joey</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 6, 2023 at 8:07 PM Li, Yi1 <<a href="mailto:yi1.li@intel.com">yi1.li@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Joey:<br>
<br>
I already give feedback for CryptoPkg part.<br>
<br>
Seems there are two Crypto patch 07/24 and 13/24, but actually 13 is StandaloneMmPkg changes. Please check.<br>
[PATCH v1 13/24] CryptoPkg: CI: Add PrEval entry <br>
<br>
-----Original Message-----<br>
From: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a> <<a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a>> On Behalf Of Li, Yi<br>
Sent: Wednesday, August 2, 2023 12:42 PM<br>
To: Joey Vagedes <<a href="mailto:joey.vagedes@gmail.com" target="_blank">joey.vagedes@gmail.com</a>>; <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a><br>
Cc: Yao, Jiewen <<a href="mailto:jiewen.yao@intel.com" target="_blank">jiewen.yao@intel.com</a>>; Lu, Xiaoyu1 <<a href="mailto:xiaoyu1.lu@intel.com" target="_blank">xiaoyu1.lu@intel.com</a>>; Jiang, Guomin <<a href="mailto:guomin.jiang@intel.com" target="_blank">guomin.jiang@intel.com</a>><br>
Subject: Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry<br>
<br>
<br>
Looks good to me.<br>
Reviewed-by: Yi Li <<a href="mailto:yi1.li@intel.com" target="_blank">yi1.li@intel.com</a>><br>
<br>
-----Original Message-----<br>
From: Joey Vagedes <<a href="mailto:joey.vagedes@gmail.com" target="_blank">joey.vagedes@gmail.com</a>> <br>
Sent: Tuesday, June 27, 2023 5:34 AM<br>
To: <a href="mailto:devel@edk2.groups.io" target="_blank">devel@edk2.groups.io</a><br>
Cc: Yao, Jiewen <<a href="mailto:jiewen.yao@intel.com" target="_blank">jiewen.yao@intel.com</a>>; Li, Yi1 <<a href="mailto:yi1.li@intel.com" target="_blank">yi1.li@intel.com</a>>; Lu, Xiaoyu1 <<a href="mailto:xiaoyu1.lu@intel.com" target="_blank">xiaoyu1.lu@intel.com</a>>; Jiang, Guomin <<a href="mailto:guomin.jiang@intel.com" target="_blank">guomin.jiang@intel.com</a>><br>
Subject: [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry<br>
<br>
Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated.<br>
<br>
When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change.<br>
<br>
Cc: Jiewen Yao <<a href="mailto:jiewen.yao@intel.com" target="_blank">jiewen.yao@intel.com</a>><br>
Cc: Yi Li <<a href="mailto:yi1.li@intel.com" target="_blank">yi1.li@intel.com</a>><br>
Cc: Xiaoyu Lu <<a href="mailto:xiaoyu1.lu@intel.com" target="_blank">xiaoyu1.lu@intel.com</a>><br>
Cc: Guomin Jiang <<a href="mailto:guomin.jiang@intel.com" target="_blank">guomin.jiang@intel.com</a>><br>
Signed-off-by: Joey Vagedes <<a href="mailto:joeyvagedes@gmail.com" target="_blank">joeyvagedes@gmail.com</a>><br>
---<br>
CryptoPkg/CryptoPkg.ci.yaml | 3 +++<br>
1 file changed, 3 insertions(+)<br>
<br>
diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml index 47f29759676d..4cec206477bc 100644<br>
--- a/CryptoPkg/CryptoPkg.ci.yaml<br>
+++ b/CryptoPkg/CryptoPkg.ci.yaml<br>
@@ -6,6 +6,9 @@<br>
# SPDX-License-Identifier: BSD-2-Clause-Patent ## {+ "PrEval": {+ "DscPath": "CryptoPkg.dsc",+ }, "LicenseCheck": { "IgnoreFiles": [ # These directories contain auto-generated OpenSSL content-- <br>
2.41.0.windows.1<br>
<br>
<br>
<br>
<br>
<br>
<br>
</blockquote></div>
<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/109462">View/Reply Online (#109462)</a> |
|
<a target="_blank" href="https://groups.io/mt/99798040/1813853">Mute This Topic</a>
| <a href="https://edk2.groups.io/g/devel/post">New Topic</a>
<br>
<a href="https://edk2.groups.io/g/devel/editsub/1813853">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |
<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>
[edk2-devel-archive@redhat.com]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>