Re: ext3 behaviour when no space on disk

[Andrew Morton <akpm zip com au>]

Andreas Dilger wrote:
> 
> On Jun 03, 2002  23:04 +0200, Duncan Sands wrote:
> > While compiling two kernels and untarring a third, my root fs was remounted
> > r/w and I got the following in dmesg (kernel 2.4.19-pre9):
>   ^^^ r/o I presume...
> 
> > EXT3-fs error (device ide0(3,2)) in ext3_new_inode: error 28
> > Aborting journal on device ide0(3,2).
> > ext3_abort called
> 
> This is a known error, and I thought a fix was submitted by Andrew
> and/or Stephen.  It should not cause a filesystem error just because
> the filesystem was full.

Memory fails me...  But no, we shouldn't be treating ENOSPC in that
manner.  How about this?

--- linux-2.5.20/fs/ext3/ialloc.c	Wed May 29 12:48:15 2002
+++ 25/fs/ext3/ialloc.c	Mon Jun  3 16:05:36 2002
@@ -534,7 +534,8 @@ repeat:
 fail:
 	unlock_super(sb);
 	iput(inode);
-	ext3_std_error(sb, err);
+	if (err != -ENOSPC)
+		ext3_std_error(sb, err);
 	return ERR_PTR(err);
 }