Re: More ext3 fileserver woes ...

[Andrew Morton <akpm zip com au>]

Neil Brown wrote:
> 
> ...
> But with ext3 I see different numbers.
> 
> Jun  6 12:04:44 elfman kernel: buffer on 5 has age 9511
> Jun  6 12:04:44 elfman kernel: buffer on 5 has age 9512
> Jun  6 12:04:44 elfman kernel: buffer on 5 has age 9513

ugh.

I suppose this will fix?

--- 2.4.19-pre10/fs/buffer.c~ext3-flushtime	Wed Jun  5 21:39:14 2002
+++ 2.4.19-pre10-akpm/fs/buffer.c	Wed Jun  5 21:39:22 2002
@@ -1067,6 +1067,8 @@ static void __refile_buffer(struct buffe
 		bh->b_list = dispose;
 		if (dispose == BUF_CLEAN)
 			remove_inode_queue(bh);
+		if (dispose == BUF_DIRTY)
+			set_buffer_flushtime(bh);
 		__insert_into_lru_list(bh, dispose);
 	}
 }
--- 2.4.19-pre10/fs/jbd/transaction.c~ext3-flushtime	Wed Jun  5 21:39:18 2002
+++ 2.4.19-pre10-akpm/fs/jbd/transaction.c	Wed Jun  5 21:39:22 2002
@@ -1101,7 +1101,6 @@ int journal_dirty_metadata (handle_t *ha
 	
 	spin_lock(&journal_datalist_lock);
 	set_bit(BH_JBDDirty, &bh->b_state);
-	set_buffer_flushtime(bh);
 
 	J_ASSERT_JH(jh, jh->b_transaction != NULL);