Re: ext3 behaviour when no space on disk

[Andrew Morton <akpm zip com au>]

"Stephen C. Tweedie" wrote:
> 
> ...
> > Is conditionalising the ext3_std_error call like in Andrew's patch a
> > sensible thing to do in this case?  I've attached the equivalent patch
> > (against 2.4.19-pre10-ac2).
> 
> It's already in the ext3 CVS and in current -ac (not quite Andrew's
> patch, but something equivalent.)
> 

Yup.  And I have this queued up for 2.5:

--- 2.5.20/fs/ext3/ialloc.c~ext3-enospc-fix	Wed Jun  5 15:51:15 2002
+++ 2.5.20-akpm/fs/ext3/ialloc.c	Wed Jun  5 15:52:31 2002
@@ -389,7 +389,7 @@ repeat:
 
 	err = -ENOSPC;
 	if (!gdp)
-		goto fail;
+		goto out;
 
 	err = -EIO;
 	bitmap_nr = load_inode_bitmap (sb, i);
@@ -532,9 +532,10 @@ repeat:
 	return inode;
 
 fail:
+	ext3_std_error(sb, err);
+out:
 	unlock_super(sb);
 	iput(inode);
-	ext3_std_error(sb, err);
 	return ERR_PTR(err);
 }