[PATCH] ext3: Fix sparse -Wbitwise warnings.
Mitchell Blank Jr
mitch at sfgoth.com
Tue Feb 15 23:29:39 UTC 2005
Stephen C. Tweedie wrote:
> If we want to fix this, let's fix the macros: for example, convert
> EXT3_HAS_COMPAT_FEATURE to be
>
> ( le32_to_cpu(EXT3_SB(sb)->s_es->s_feature_compat) & (mask) )
Of course that's less efficient though since "mask" is probably constant..
so now the endian conversion changed from compile-time to run-time.
Would something like
( ( EXT3_SB(sb)->s_es->s_feature_compat & cpu_to_le32(mask) ) != 0)
be enough to satisfy sparse?
-Mitch
More information about the Ext3-users
mailing list