<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> On 07/06/2009 12:20 PM, Rich Megginson wrote: <blockquote cite="mid:4A524E76.7020206@redhat.com" type="cite">Note - the patch does not contain the diffs for configure nor Makefile.in <a class="moz-txt-link-freetext" href="http://rmeggins.fedorapeople.org/0001-OpenLDAP-support.patch">http://rmeggins.fedorapeople.org/0001-OpenLDAP-support.patch</a> </blockquote> There are a few minor log message formatting issues that I noticed: - Do a grep for "insee_if_write_available" for the first one. A space just needs to be added between "in" and "see_if_write_available". - The '\' was left off of a '\n' in the following call to slapi_log_error in slapi_ldap_init_ext(): slapi_log_error(SLAPI_LOG_FATAL, "slapi_ldap_init_ext", "failed: unable to set minimum TLS protocol level to SSL3n"); - The next call to slapi_log_error is also missing the '\n' in slapi_ldap_init_ext(). The patch looks good aside from the above nit-picks (though it's a large patch, so I could have missed something). -NGK <blockquote cite="mid:4A524E76.7020206@redhat.com" type="cite"> <pre wrap=""> <hr size="4" width="90%"> -- 389-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:389-devel@redhat.com">389-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/fedora-directory-devel">https://www.redhat.com/mailman/listinfo/fedora-directory-devel</a> </pre> </blockquote> </body> </html>