<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> On 07/30/2009 05:10 PM, Nathan Kinder wrote: <blockquote cite="mid:4A72367F.7000204@redhat.com" type="cite"> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> On 07/30/2009 03:37 PM, Nathan Kinder wrote: <blockquote cite="mid:4A7220C0.6030507@redhat.com" type="cite"><a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://bugzilla.redhat.com/show_bug.cgi?id=514824">https://bugzilla.redhat.com/show_bug.cgi?id=514824</a> <pre wrap=""><hr size="4" width="90%"> -- 389-devel mailing list <a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:389-devel@redhat.com">389-devel@redhat.com</a> <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/fedora-directory-devel">https://www.redhat.com/mailman/listinfo/fedora-directory-devel</a> </pre> </blockquote> Here's a new patch that addresses some issues Noriko brought up. The list "a" was being set to NULL when we found an attribute match for a macro, but this is no longer necessary now that we reset "a" to NULL when the memory is handed off to the working_list (which covers both the cases of finding/not finding the attribute). We were also accessing element 0 of list "a" right after handing the memory off to the working_list, but we weren't checking if "a" was NULL first. I don't believe that "a" could be NULL at this point, but it's safest to check first in case there is some corner case we're not considering. -NGK <pre wrap=""> <hr size="4" width="90%"> -- 389-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:389-devel@redhat.com">389-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/fedora-directory-devel">https://www.redhat.com/mailman/listinfo/fedora-directory-devel</a> </pre> </blockquote> Looks good. Thanks for considering my questions! --noriko </body> </html>