[Fedora-ia64-list] hald unaligned access

Zhang, Yanmin yanmin_zhang at linux.intel.com
Wed Sep 13 09:23:02 UTC 2006


When booting machine, hald causes unaligned access. As a
matter of fact, it's a bug because sizeof(len) is only
defined as 4 bytes, but getline of glibc looks it as 8 bytes,
so the next variable might be erased.

Below patch fixes it.

Prarit,

Could you accept it into FC?

BTW, I built kernel 2.6.17-1.2630 and kernel also printed unaligned access
in function unmap_single. I will check it tomorrow.
As for other memory bugs when installing FC, I couldn't reproduce them here.

Thanks,
Yanmin

---

diff -Nraup hal-0.5.7.1/hald/linux2/osspec.c hal-0.5.7.1_fix/hald/linux2/osspec.c
--- hal-0.5.7.1/hald/linux2/osspec.c	2006-02-14 00:42:32.000000000 +0800
+++ hal-0.5.7.1_fix/hald/linux2/osspec.c	2006-09-13 07:51:36.000000000 +0800
@@ -444,7 +444,7 @@ set_suspend_hibernate_keys (HalDevice *d
 	int can_suspend;
 	int can_hibernate;
 	ssize_t read;
-	unsigned int len;
+	size_t len;
 	char *poweroptions;
 	FILE *fp;
 




More information about the Fedora-ia64-list mailing list